LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Lawrence <joe.lawrence@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linuxppc-dev@lists.ozlabs.org, Nicholas Piggin <npiggin@gmail.com>
Subject: Re: ppc64le: ftrace self-tests and $(CC_FLAGS_FTRACE) broken?
Date: Mon, 25 Mar 2019 12:07:17 -0400	[thread overview]
Message-ID: <cf749ff7-125c-2b31-0862-19ba6a5981a8@redhat.com> (raw)
In-Reply-To: <16061c33-4b42-8b8c-008c-123b2991677c@redhat.com>

On 3/23/19 1:27 PM, Joe Lawrence wrote:
> On 03/23/2019 12:17 PM, Steven Rostedt wrote:
>> On Sat, 23 Mar 2019 09:19:50 -0400
>> Joe Lawrence <joe.lawrence@redhat.com> wrote:
>>
>>> Perhaps this is gcc version specific?  I didn't see any other reports,
>>> so maybe its specific to my config.  If I run make V=1, I can see that
>>> gcc is called with '-pg -mprofile-kernel', but then the record_mcount
>>> script is skipped.  Any ideas?
>>
>> But you see it running the script if you remove that commit? Do you
>> happen to see -mrecord-mcount at all in a V=1 make?
>>
> 
> See entire make output from the two runs here:
> http://people.redhat.com/~jolawren/ppc64le-mprofile/

Mystery solved!  That other commit inadvertently added a trailing space 
to CC_FLAGS_FTRACE, which then confused the findstring call in the 
cmd_record_mcount Makefile function.

Workaround patch just posted ... kbuild experts can suggest better fixes 
if that one is sub optimal.

Thanks,

-- Joe

      reply	other threads:[~2019-03-25 16:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-23 13:19 ppc64le: ftrace self-tests and $(CC_FLAGS_FTRACE) broken? Joe Lawrence
2019-03-23 16:17 ` Steven Rostedt
2019-03-23 17:01   ` Joe Lawrence
2019-03-23 17:27   ` Joe Lawrence
2019-03-25 16:07     ` Joe Lawrence [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf749ff7-125c-2b31-0862-19ba6a5981a8@redhat.com \
    --to=joe.lawrence@redhat.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=npiggin@gmail.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox