From: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
To: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, Russell Currey <ruscur@russell.cc>
Cc: Philippe Bergheaud <philippe.bergheaud@fr.ibm.com>,
Frederic Barrat <fbarrat@linux.vnet.ibm.com>,
Gavin Shan <gwshan@linux.vnet.ibm.com>,
Ian Munsie <imunsie@au1.ibm.com>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
Christophe Lombard <christophe_lombard@fr.ibm.com>,
Greg Kurz <gkurz@linux.vnet.ibm.com>
Subject: Re: [RESEND-RFC v2 1/3] powerpc/eeh: Refactor eeh_pe_update_time_stamp() to update freeze_count
Date: Wed, 1 Mar 2017 14:39:53 -0300 [thread overview]
Message-ID: <cffa9e2f-0a8f-f076-bff9-0d1f6efd2f8b@linux.vnet.ibm.com> (raw)
In-Reply-To: <87lgsp0xpt.fsf@vajain21.in.ibm.com>
On 03/01/2017 01:26 PM, Vaibhav Jain wrote:
>
> Thanks for reviewing the patch !!
Yw =)
>
> "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com> writes:
>>
>> Not sure why, but many of the words in commit message are missing their
>> first letter. See, for example:
>> reeze_count, roze, eports, ermanently
> Thanks for pointing this out. Will fix this in the subsequent patch
> revision.
>
>>> /**
>>> - * eeh_pe_update_time_stamp - Update PE's frozen time stamp
>>> + * eeh_pe_update_freeze_counter - Update PE's frozen time stamp
>>> + * and freeze counter
>>> * @pe: EEH PE
>>> *
>>> - * We have time stamp for each PE to trace its time of getting
>>> - * frozen in last hour. The function should be called to update
>>> - * the time stamp on first error of the specific PE. On the other
>>> - * handle, we needn't account for errors happened in last hour.
>>
>> s/handle/hand? "On the other hand..."
> Thats part of original comment which this patch is replacing.
.....hehehe
How didn't I notice?
Sorry, my bad!
next prev parent reply other threads:[~2017-03-01 17:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 11:24 [RESEND-RFC v2 0/3] cxl: Reset freeze counter for the adapter before PERST Vaibhav Jain
2017-03-01 11:24 ` [RESEND-RFC v2 1/3] powerpc/eeh: Refactor eeh_pe_update_time_stamp() to update freeze_count Vaibhav Jain
2017-03-01 14:58 ` Guilherme G. Piccoli
2017-03-01 16:26 ` Vaibhav Jain
2017-03-01 17:39 ` Guilherme G. Piccoli [this message]
2017-03-01 23:52 ` Russell Currey
2017-03-02 1:03 ` Andrew Donnellan
2017-03-01 11:24 ` [RESEND-RFC v2 2/3] powerpc/eeh: Introduce function eeh_pe_reset_freeze_counter() Vaibhav Jain
2017-03-02 1:10 ` Andrew Donnellan
2017-03-03 4:21 ` Vaibhav Jain
2017-03-03 4:34 ` Andrew Donnellan
2017-03-03 4:35 ` Russell Currey
2017-03-03 4:39 ` Andrew Donnellan
2017-03-03 5:45 ` Gavin Shan
2017-03-01 11:24 ` [RESEND-RFC v2 3/3] cxl: Reset freeze counters before adapter PERST for flashing new image Vaibhav Jain
2017-03-02 1:46 ` Andrew Donnellan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cffa9e2f-0a8f-f076-bff9-0d1f6efd2f8b@linux.vnet.ibm.com \
--to=gpiccoli@linux.vnet.ibm.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=christophe_lombard@fr.ibm.com \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=imunsie@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=philippe.bergheaud@fr.ibm.com \
--cc=ruscur@russell.cc \
--cc=vaibhav@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).