linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/8] treewide: Remove OOM message after input_alloc_device
@ 2013-10-23 19:14 Joe Perches
  2013-10-23 19:14 ` [PATCH 2/8] cell: Remove OOM message after input_allocate_device Joe Perches
  0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2013-10-23 19:14 UTC (permalink / raw)
  To: linux-kernel
  Cc: cbe-oss-dev, devel, alsa-devel, linux-samsung-soc, linux-doc,
	linux-iio, acpi4asus-user, platform-driver-x86, ibm-acpi-devel,
	linux-input, linuxppc-dev, linux-arm-kernel, linux-media

Joe Perches (8):
  Documentation: Remove OOM message after input_allocate_device
  cell: Remove OOM message after input_allocate_device
  hid: Remove OOM message after input_allocate_device
  input: Remove OOM message after input_allocate_device
  media: Remove OOM message after input_allocate_device
  platform:x86: Remove OOM message after input_allocate_device
  staging: Remove OOM message after input_allocate_device
  sound: Remove OOM message after input_allocate_device

 Documentation/input/input-programming.txt     | 1 -
 arch/powerpc/platforms/cell/cbe_powerbutton.c | 1 -
 drivers/hid/hid-input.c                       | 1 -
 drivers/hid/hid-picolcd_core.c                | 5 ++---
 drivers/input/joystick/as5011.c               | 2 --
 drivers/input/joystick/db9.c                  | 1 -
 drivers/input/joystick/gamecon.c              | 4 +---
 drivers/input/joystick/turbografx.c           | 1 -
 drivers/input/joystick/walkera0701.c          | 1 -
 drivers/input/keyboard/amikbd.c               | 4 +---
 drivers/input/keyboard/davinci_keyscan.c      | 1 -
 drivers/input/keyboard/gpio_keys.c            | 1 -
 drivers/input/keyboard/lpc32xx-keys.c         | 1 -
 drivers/input/keyboard/max7359_keypad.c       | 1 -
 drivers/input/keyboard/mcs_touchkey.c         | 1 -
 drivers/input/keyboard/mpr121_touchkey.c      | 1 -
 drivers/input/keyboard/nomadik-ske-keypad.c   | 1 -
 drivers/input/keyboard/opencores-kbd.c        | 1 -
 drivers/input/keyboard/pmic8xxx-keypad.c      | 1 -
 drivers/input/keyboard/pxa27x_keypad.c        | 1 -
 drivers/input/keyboard/pxa930_rotary.c        | 1 -
 drivers/input/keyboard/qt1070.c               | 1 -
 drivers/input/keyboard/qt2160.c               | 1 -
 drivers/input/keyboard/sh_keysc.c             | 1 -
 drivers/input/keyboard/tc3589x-keypad.c       | 1 -
 drivers/input/keyboard/tnetv107x-keypad.c     | 1 -
 drivers/input/keyboard/w90p910_keypad.c       | 1 -
 drivers/input/misc/88pm80x_onkey.c            | 1 -
 drivers/input/misc/88pm860x_onkey.c           | 1 -
 drivers/input/misc/arizona-haptics.c          | 4 +---
 drivers/input/misc/atlas_btns.c               | 4 +---
 drivers/input/misc/da9052_onkey.c             | 1 -
 drivers/input/misc/da9055_onkey.c             | 4 +---
 drivers/input/misc/ideapad_slidebar.c         | 1 -
 drivers/input/misc/ims-pcu.c                  | 7 +------
 drivers/input/misc/kxtj9.c                    | 4 +---
 drivers/input/misc/max8997_haptic.c           | 1 -
 drivers/input/misc/mc13783-pwrbutton.c        | 4 +---
 drivers/input/misc/mpu3050.c                  | 1 -
 drivers/input/misc/pcf8574_keypad.c           | 1 -
 drivers/input/misc/pm8xxx-vibrator.c          | 1 -
 drivers/input/misc/pmic8xxx-pwrkey.c          | 1 -
 drivers/input/misc/pwm-beeper.c               | 1 -
 drivers/input/misc/twl4030-pwrbutton.c        | 4 +---
 drivers/input/misc/twl6040-vibra.c            | 1 -
 drivers/input/mouse/appletouch.c              | 4 +---
 drivers/input/mouse/bcm5974.c                 | 4 +---
 drivers/input/mouse/cyapa.c                   | 4 +---
 drivers/input/mouse/inport.c                  | 1 -
 drivers/input/mouse/logibm.c                  | 1 -
 drivers/input/mouse/pc110pad.c                | 1 -
 drivers/input/mouse/pxa930_trkball.c          | 1 -
 drivers/input/tablet/aiptek.c                 | 5 +----
 drivers/input/tablet/gtco.c                   | 1 -
 drivers/input/touchscreen/88pm860x-ts.c       | 1 -
 drivers/input/touchscreen/atmel_mxt_ts.c      | 1 -
 drivers/input/touchscreen/atmel_tsadcc.c      | 1 -
 drivers/input/touchscreen/bu21013_ts.c        | 1 -
 drivers/input/touchscreen/cyttsp4_core.c      | 2 --
 drivers/input/touchscreen/da9034-ts.c         | 1 -
 drivers/input/touchscreen/edt-ft5x06.c        | 1 -
 drivers/input/touchscreen/eeti_ts.c           | 5 +----
 drivers/input/touchscreen/htcpen.c            | 1 -
 drivers/input/touchscreen/intel-mid-touch.c   | 1 -
 drivers/input/touchscreen/lpc32xx_ts.c        | 1 -
 drivers/input/touchscreen/mcs5000_ts.c        | 1 -
 drivers/input/touchscreen/migor_ts.c          | 1 -
 drivers/input/touchscreen/mk712.c             | 1 -
 drivers/input/touchscreen/pixcir_i2c_ts.c     | 1 -
 drivers/input/touchscreen/s3c2410_ts.c        | 1 -
 drivers/input/touchscreen/ti_am335x_tsc.c     | 1 -
 drivers/input/touchscreen/tnetv107x-ts.c      | 1 -
 drivers/media/rc/imon.c                       | 8 ++------
 drivers/media/usb/em28xx/em28xx-input.c       | 4 +---
 drivers/media/usb/pwc/pwc-if.c                | 1 -
 drivers/platform/x86/asus-laptop.c            | 5 ++---
 drivers/platform/x86/eeepc-laptop.c           | 4 +---
 drivers/platform/x86/ideapad-laptop.c         | 4 +---
 drivers/platform/x86/intel_mid_powerbtn.c     | 4 +---
 drivers/platform/x86/panasonic-laptop.c       | 5 +----
 drivers/platform/x86/thinkpad_acpi.c          | 1 -
 drivers/platform/x86/topstar-laptop.c         | 4 +---
 drivers/platform/x86/toshiba_acpi.c           | 4 +---
 drivers/staging/cptm1217/clearpad_tm1217.c    | 2 --
 drivers/staging/iio/adc/mxs-lradc.c           | 4 +---
 drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 2 --
 sound/pci/hda/hda_beep.c                      | 4 +---
 87 files changed, 29 insertions(+), 152 deletions(-)

-- 
1.8.1.2.459.gbcd45b4.dirty

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/8] cell: Remove OOM message after input_allocate_device
  2013-10-23 19:14 [PATCH 0/8] treewide: Remove OOM message after input_alloc_device Joe Perches
@ 2013-10-23 19:14 ` Joe Perches
  2013-10-23 20:49   ` [Cbe-oss-dev] " Geoff Levand
  0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2013-10-23 19:14 UTC (permalink / raw)
  To: linux-kernel; +Cc: cbe-oss-dev, Paul Mackerras, linuxppc-dev, Arnd Bergmann

Emitting an OOM message isn't necessary after input_allocate_device
as there's a generic OOM and a dump_stack already done.

Signed-off-by: Joe Perches <joe@perches.com>
---
 arch/powerpc/platforms/cell/cbe_powerbutton.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/platforms/cell/cbe_powerbutton.c b/arch/powerpc/platforms/cell/cbe_powerbutton.c
index 2bb8031..8804dbd 100644
--- a/arch/powerpc/platforms/cell/cbe_powerbutton.c
+++ b/arch/powerpc/platforms/cell/cbe_powerbutton.c
@@ -58,7 +58,6 @@ static int __init cbe_powerbutton_init(void)
 	dev = input_allocate_device();
 	if (!dev) {
 		ret = -ENOMEM;
-		printk(KERN_ERR "%s: Not enough memory.\n", __func__);
 		goto out;
 	}
 
-- 
1.8.1.2.459.gbcd45b4.dirty

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Cbe-oss-dev] [PATCH 2/8] cell: Remove OOM message after input_allocate_device
  2013-10-23 19:14 ` [PATCH 2/8] cell: Remove OOM message after input_allocate_device Joe Perches
@ 2013-10-23 20:49   ` Geoff Levand
  0 siblings, 0 replies; 3+ messages in thread
From: Geoff Levand @ 2013-10-23 20:49 UTC (permalink / raw)
  To: Joe Perches, Arnd Bergmann
  Cc: cbe-oss-dev, linuxppc-dev, Paul Mackerras, linux-kernel

Hi Joe,

On Wed, 2013-10-23 at 12:14 -0700, Joe Perches wrote:
> Emitting an OOM message isn't necessary after input_allocate_device
> as there's a generic OOM and a dump_stack already done.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  arch/powerpc/platforms/cell/cbe_powerbutton.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/cell/cbe_powerbutton.c b/arch/powerpc/platforms/cell/cbe_powerbutton.c
> index 2bb8031..8804dbd 100644
> --- a/arch/powerpc/platforms/cell/cbe_powerbutton.c
> +++ b/arch/powerpc/platforms/cell/cbe_powerbutton.c
> @@ -58,7 +58,6 @@ static int __init cbe_powerbutton_init(void)
>  	dev = input_allocate_device();
>  	if (!dev) {
>  		ret = -ENOMEM;
> -		printk(KERN_ERR "%s: Not enough memory.\n", __func__);
>  		goto out;
>  	}

Arnd is out on leave, so I'll say that this looks OK.

Acked-by: Geoff Levand <geoff@infradead.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-10-23 20:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-23 19:14 [PATCH 0/8] treewide: Remove OOM message after input_alloc_device Joe Perches
2013-10-23 19:14 ` [PATCH 2/8] cell: Remove OOM message after input_allocate_device Joe Perches
2013-10-23 20:49   ` [Cbe-oss-dev] " Geoff Levand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).