From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@au1.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
Michael Ellerman <mpe@ellerman.id.au>,
Anton Blanchard <anton@samba.org>
Subject: Re: Optimised memset64/memset32 for powerpc
Date: Tue, 28 Mar 2017 01:07:39 +0530 [thread overview]
Message-ID: <cover.1490641759.git.naveen.n.rao@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170322193030.GA8008@bombadil.infradead.org>
On 2017/03/22 12:30PM, Matthew Wilcox wrote:
> On Wed, Mar 22, 2017 at 06:18:05AM -0700, Matthew Wilcox wrote:
> > There's one other potential user I've been wondering about, which are the
> > various console drivers. They use 'memsetw' to blank the entire console
> > or lines of the console when scrolling, but the only architecture which
> > ever bothered implementing an optimised version of it was Alpha.
> >
> > Might be worth it on powerpc actually ... better than a loop calling
> > cpu_to_le16() on each iteration. That'd complete the set with a
> > memset16().
>
> All hail plane rides ... This would need to be resplit and merged properly,
> but I think it makes life a little saner.
... not to forget train rides :)
Here's a straight-forward implementation for powerpc64, along with one
other user in bpf. It is obviously non-critical, but given that we have
64K pages on powerpc64, it does help to speed up the BPF JIT.
- Naveen
Naveen N. Rao (2):
powerpc: string: implement optimized memset variants
powerpc: bpf: use memset32() to pre-fill traps in BPF page(s)
arch/powerpc/include/asm/string.h | 24 ++++++++++++++++++++++++
arch/powerpc/lib/mem_64.S | 19 ++++++++++++++++++-
arch/powerpc/net/bpf_jit_comp64.c | 6 +-----
3 files changed, 43 insertions(+), 6 deletions(-)
--
2.11.1
next prev parent reply other threads:[~2017-03-27 19:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 21:14 Optimised memset64/memset32 for powerpc Matthew Wilcox
2017-03-20 21:23 ` Benjamin Herrenschmidt
2017-03-21 12:23 ` Christophe LEROY
2017-03-21 13:29 ` Matthew Wilcox
2017-03-21 16:45 ` Segher Boessenkool
2017-03-21 21:26 ` Benjamin Herrenschmidt
2017-03-22 13:18 ` Matthew Wilcox
2017-03-22 19:30 ` Matthew Wilcox
2017-03-27 19:37 ` Naveen N. Rao [this message]
2017-03-27 19:37 ` [PATCH 1/2] powerpc: string: implement optimized memset variants Naveen N. Rao
2017-03-28 0:44 ` Michael Ellerman
2017-03-28 10:21 ` Naveen N. Rao
2017-03-29 11:36 ` Michael Ellerman
2017-03-30 7:16 ` Naveen N. Rao
2017-04-04 12:00 ` Michael Ellerman
2017-04-18 6:45 ` Michael Ellerman
2017-04-05 5:51 ` PrasannaKumar Muralidharan
2017-04-12 15:05 ` Naveen N. Rao
2017-08-18 12:50 ` [1/2] " Michael Ellerman
2017-03-27 19:37 ` [PATCH 2/2] powerpc: bpf: use memset32() to pre-fill traps in BPF page(s) Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1490641759.git.naveen.n.rao@linux.vnet.ibm.com \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@au1.ibm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).