linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sam Bobroff <sbobroff@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 00/13] EEH refactoring 2
Date: Wed, 2 May 2018 16:34:48 +1000	[thread overview]
Message-ID: <cover.1525242772.git.sbobroff@linux.ibm.com> (raw)

Hello everyone,

Here is a second, somewhat deeper, set of cleanups for the EEH code
(mostly eeh_drver.c).

These changes are not intended to significantly alter the actual processing,
but rather to improve the readability and maintainability of the code. They are
subjective by nature so I would appreciate comments and suggestions.

The earlier changes are mostly to support the last patch, where we're finally
able to use a common infrastructure for the reporting functions (basically
wrappers around the driver's handlers). This allows removal of a fair bit of
code, and the easy addition of some useful messaging which should make future
maintenance easier (as an example, a recent fix in this area "powerpc/eeh: Fix
race with driver un/bind" would have required adding two lines rather than
42+/26-).

Cheers,
Sam.

Sam Bobroff (13):
  powerpc/eeh: Add eeh_max_freezes to initial EEH log line
  powerpc/eeh: Add final message for successful recovery
  powerpc/eeh: Fix use-after-release of EEH driver
  powerpc/eeh: Remove unused eeh_pcid_name()
  powerpc/eeh: Strengthen types of eeh traversal functions
  powerpc/eeh: Add message when PE processing at parent
  powerpc/eeh: Clean up pci_ers_result handling
  powerpc/eeh: Introduce eeh_for_each_pe()
  powerpc/eeh: Introduce eeh_edev_actionable()
  powerpc/eeh: Introduce eeh_set_channel_state()
  powerpc/eeh: Introduce eeh_set_irq_state()
  powerpc/eeh: Cleaner handling of EEH_DEV_NO_HANDLER
  powerpc/eeh: Refactor report functions

 arch/powerpc/include/asm/eeh.h   |  11 +-
 arch/powerpc/kernel/eeh.c        |  19 +-
 arch/powerpc/kernel/eeh_driver.c | 468 ++++++++++++++++++++-------------------
 arch/powerpc/kernel/eeh_pe.c     |  26 +--
 4 files changed, 268 insertions(+), 256 deletions(-)

-- 
2.16.1.74.g9b0b1f47b

             reply	other threads:[~2018-05-02  6:34 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02  6:34 Sam Bobroff [this message]
2018-05-02  6:34 ` [PATCH 01/13] powerpc/eeh: Add eeh_max_freezes to initial EEH log line Sam Bobroff
2018-05-04  5:46   ` Russell Currey
2018-05-02  6:35 ` [PATCH 02/13] powerpc/eeh: Add final message for successful recovery Sam Bobroff
2018-05-04  2:55   ` Michael Ellerman
2018-05-04  6:08     ` Russell Currey
2018-05-07  5:35       ` Sam Bobroff
2018-05-07  5:29     ` Sam Bobroff
2018-05-02  6:35 ` [PATCH 03/13] powerpc/eeh: Fix use-after-release of EEH driver Sam Bobroff
2018-05-04  2:56   ` Michael Ellerman
2018-05-07  5:38     ` Sam Bobroff
2018-05-02  6:35 ` [PATCH 04/13] powerpc/eeh: Remove unused eeh_pcid_name() Sam Bobroff
2018-05-04  6:29   ` Russell Currey
2018-05-02  6:35 ` [PATCH 05/13] powerpc/eeh: Strengthen types of eeh traversal functions Sam Bobroff
2018-05-04  6:32   ` Russell Currey
2018-05-02  6:35 ` [PATCH 06/13] powerpc/eeh: Add message when PE processing at parent Sam Bobroff
2018-05-04  6:51   ` Russell Currey
2018-05-02  6:36 ` [PATCH 07/13] powerpc/eeh: Clean up pci_ers_result handling Sam Bobroff
2018-05-04  2:58   ` Michael Ellerman
2018-05-04  6:58   ` Russell Currey
2018-05-08  1:09     ` Sam Bobroff
2018-05-02  6:36 ` [PATCH 08/13] powerpc/eeh: Introduce eeh_for_each_pe() Sam Bobroff
2018-05-04  6:59   ` Russell Currey
2018-05-02  6:36 ` [PATCH 09/13] powerpc/eeh: Introduce eeh_edev_actionable() Sam Bobroff
2018-05-02  6:36 ` [PATCH 10/13] powerpc/eeh: Introduce eeh_set_channel_state() Sam Bobroff
2018-05-02  6:36 ` [PATCH 11/13] powerpc/eeh: Introduce eeh_set_irq_state() Sam Bobroff
2018-05-04  3:02   ` Michael Ellerman
2018-05-08  1:12     ` Sam Bobroff
2018-05-02  6:36 ` [PATCH 12/13] powerpc/eeh: Cleaner handling of EEH_DEV_NO_HANDLER Sam Bobroff
2018-05-02  6:36 ` [PATCH 13/13] powerpc/eeh: Refactor report functions Sam Bobroff
2018-05-03 13:27   ` Michael Ellerman
2018-05-07  5:23     ` Sam Bobroff
2018-05-09 14:51       ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1525242772.git.sbobroff@linux.ibm.com \
    --to=sbobroff@linux.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).