From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
arnd@arndb.de, tglx@linutronix.de, vincenzo.frascino@arm.com,
luto@kernel.org
Cc: x86@kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org
Subject: [RFC PATCH v2 00/10] powerpc/32: switch VDSO to C implementation.
Date: Mon, 23 Dec 2019 14:31:01 +0000 (UTC) [thread overview]
Message-ID: <cover.1577111363.git.christophe.leroy@c-s.fr> (raw)
This is a second tentative to switch powerpc/32 vdso to generic C implementation.
It will likely not work on 64 bits or even build properly at the moment.
powerpc is a bit special for VDSO as well as system calls in the
way that it requires setting CR SO bit which cannot be done in C.
Therefore, entry/exit and fallback needs to be performed in ASM.
To allow that, the fallback calls are moved out of the common code
and left to the arches.
A few other changes in the common code have allowed performance improvement.
The performance has improved since first RFC, but it is still lower than
current assembly VDSO.
On a powerpc8xx, with current powerpc/32 ASM VDSO:
gettimeofday: vdso: 737 nsec/call
clock-getres-realtime: vdso: 475 nsec/call
clock-gettime-realtime: vdso: 892 nsec/call
clock-getres-monotonic: vdso: 475 nsec/call
clock-gettime-monotonic: vdso: 1014 nsec/call
First try of C implementation:
gettimeofday: vdso: 1533 nsec/call
clock-getres-realtime: vdso: 853 nsec/call
clock-gettime-realtime: vdso: 1570 nsec/call
clock-getres-monotonic: vdso: 835 nsec/call
clock-gettime-monotonic: vdso: 1605 nsec/call
With this series:
gettimeofday: vdso: 1016 nsec/call
clock-getres-realtime: vdso: 560 nsec/call
clock-gettime-realtime: vdso: 1192 nsec/call
clock-getres-monotonic: vdso: 560 nsec/call
clock-gettime-monotonic: vdso: 1192 nsec/call
Changes made to other arches are untested, not even compiled.
Christophe Leroy (10):
lib: vdso: ensure all arches have 32bit fallback
lib: vdso: move call to fallback out of common code.
lib: vdso: Change __cvdso_clock_gettime/getres_common() to
__cvdso_clock_gettime/getres()
lib: vdso: get pointer to vdso data from the arch
lib: vdso: inline do_hres()
lib: vdso: make do_coarse() return 0
lib: vdso: don't use READ_ONCE() in __c_kernel_time()
lib: vdso: Avoid duplication in __cvdso_clock_getres()
powerpc/vdso32: inline __get_datapage()
powerpc/32: Switch VDSO to C implementation.
arch/arm/include/asm/vdso/gettimeofday.h | 26 +++
arch/arm/vdso/vgettimeofday.c | 32 ++-
arch/arm64/include/asm/vdso/compat_gettimeofday.h | 2 -
arch/arm64/include/asm/vdso/gettimeofday.h | 26 +++
arch/arm64/kernel/vdso/vgettimeofday.c | 24 +-
arch/arm64/kernel/vdso32/vgettimeofday.c | 39 +++-
arch/mips/include/asm/vdso/gettimeofday.h | 28 ++-
arch/mips/vdso/vgettimeofday.c | 56 ++++-
arch/powerpc/Kconfig | 2 +
arch/powerpc/include/asm/vdso/gettimeofday.h | 45 ++++
arch/powerpc/include/asm/vdso/vsyscall.h | 27 +++
arch/powerpc/include/asm/vdso_datapage.h | 28 +--
arch/powerpc/kernel/asm-offsets.c | 23 +-
arch/powerpc/kernel/time.c | 92 +-------
arch/powerpc/kernel/vdso.c | 19 +-
arch/powerpc/kernel/vdso32/Makefile | 19 +-
arch/powerpc/kernel/vdso32/cacheflush.S | 9 +-
arch/powerpc/kernel/vdso32/datapage.S | 28 +--
arch/powerpc/kernel/vdso32/gettimeofday.S | 265 +++-------------------
arch/powerpc/kernel/vdso32/vgettimeofday.c | 32 +++
arch/x86/entry/vdso/vclock_gettime.c | 52 ++++-
arch/x86/include/asm/vdso/gettimeofday.h | 28 ++-
lib/vdso/gettimeofday.c | 100 +++-----
23 files changed, 505 insertions(+), 497 deletions(-)
create mode 100644 arch/powerpc/include/asm/vdso/gettimeofday.h
create mode 100644 arch/powerpc/include/asm/vdso/vsyscall.h
create mode 100644 arch/powerpc/kernel/vdso32/vgettimeofday.c
--
2.13.3
next reply other threads:[~2019-12-23 14:34 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 14:31 Christophe Leroy [this message]
2019-12-23 14:31 ` [RFC PATCH v2 01/10] lib: vdso: ensure all arches have 32bit fallback Christophe Leroy
2019-12-24 2:07 ` Andy Lutomirski
2020-01-10 20:56 ` Thomas Gleixner
2020-01-10 21:02 ` Andy Lutomirski
2019-12-30 12:27 ` Arnd Bergmann
2020-01-02 11:29 ` Arnd Bergmann
2020-01-09 15:43 ` Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 02/10] lib: vdso: move call to fallback out of common code Christophe Leroy
2019-12-24 2:24 ` Andy Lutomirski
2019-12-24 11:41 ` christophe leroy
2019-12-24 12:09 ` Andy Lutomirski
2019-12-23 14:31 ` [RFC PATCH v2 03/10] lib: vdso: Change __cvdso_clock_gettime/getres_common() to __cvdso_clock_gettime/getres() Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 04/10] lib: vdso: get pointer to vdso data from the arch Christophe Leroy
2019-12-24 2:27 ` Andy Lutomirski
2019-12-24 11:53 ` christophe leroy
2019-12-24 12:15 ` Andy Lutomirski
2019-12-24 12:41 ` Andy Lutomirski
2019-12-24 14:46 ` Segher Boessenkool
2019-12-23 14:31 ` [RFC PATCH v2 05/10] lib: vdso: inline do_hres() Christophe Leroy
2019-12-24 2:29 ` Andy Lutomirski
2019-12-30 12:07 ` Arnd Bergmann
2020-01-10 21:07 ` Thomas Gleixner
2020-01-11 9:06 ` Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 06/10] lib: vdso: make do_coarse() return 0 Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 07/10] lib: vdso: don't use READ_ONCE() in __c_kernel_time() Christophe Leroy
2019-12-24 1:58 ` Andy Lutomirski
2019-12-24 11:12 ` christophe leroy
2019-12-24 12:04 ` Andy Lutomirski
2020-01-10 21:12 ` Thomas Gleixner
2020-01-11 8:05 ` Christophe Leroy
2020-01-11 11:07 ` Thomas Gleixner
2020-01-13 6:52 ` Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 08/10] lib: vdso: Avoid duplication in __cvdso_clock_getres() Christophe Leroy
2019-12-24 1:59 ` Andy Lutomirski
2019-12-23 14:31 ` [RFC PATCH v2 09/10] powerpc/vdso32: inline __get_datapage() Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 10/10] powerpc/32: Switch VDSO to C implementation Christophe Leroy
2020-01-09 17:52 ` Surprising code generated for vdso_read_begin() Christophe Leroy
2020-01-09 20:07 ` Segher Boessenkool
2020-01-10 6:45 ` Christophe Leroy
2020-01-11 11:33 ` Segher Boessenkool
2020-02-16 18:10 ` Arnd Bergmann
2020-02-19 8:45 ` Christophe Leroy
2020-02-19 9:52 ` Arnd Bergmann
2020-02-19 13:08 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1577111363.git.christophe.leroy@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).