From: Naveen Naidu <naveennaidu479@gmail.com>
To: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com
Cc: Naveen Naidu <naveennaidu479@gmail.com>,
linuxppc-dev@lists.ozlabs.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org
Subject: [PATCH 0/8] Fix long standing AER Error Handling Issues
Date: Mon, 4 Oct 2021 19:22:35 +0530 [thread overview]
Message-ID: <cover.1633353468.git.naveennaidu479@gmail.com> (raw)
This patch series aims at fixing some of the AER error handling issues
we have.
Currently we have the following issues:
- Confusing message in aer_print_error()
- aer_err_info not being initialized completely in DPC path before
we print the AER logs
- A bug [1] in clearing of AER registers in the native AER path
[1] https://lore.kernel.org/linux-pci/20151229155822.GA17321@localhost/
The primary aim of this patch series is to converge the APEI path and the
native AER error handling paths. In our current code, we find that we
have two different behaviours (especially when it comes to clearing of
the AER registers) for the same functionality.
This patch series, tries to bring the same semantics and hence more
commonanlity between the APEI part of code and the native OS
handling of AER errors.
PATCH 1:
- Fixes the first issue
PATCH 2 - 4:
- Fixes the second issue
- "Patch 3/8" is dependent on "Patch 2/3" in the series
PATCH 5 - 7
- Deals with converging the various paths and to bring more
commonality between them
- "Patch 6/8" depends on "Patch 1/8"
PATCH 8:
- Adds extra information in AER error logs.
Thanks,
Naveen Naidu
Naveen Naidu (8):
[PATCH 1/8] PCI/AER: Remove ID from aer_agent_string[]
[PATCH 2/8] PCI: Cleanup struct aer_err_info
[PATCH 3/8] PCI/DPC: Initialize info->id in dpc_process_error()
[PATCH 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error()
[PATCH 5/8] PCI/DPC: Converge EDR and DPC Path of clearing AER registers
[PATCH 6/8] PCI/AER: Clear error device AER registers in aer_irq()
[PATCH 7/8] PCI/ERR: Remove redundant clearing of AER register in pcie_do_recovery()
[PATCH 8/8] PCI/AER: Include DEVCTL in aer_print_error()
drivers/pci/pci.h | 23 +++-
drivers/pci/pcie/aer.c | 265 ++++++++++++++++++++++++++++-------------
drivers/pci/pcie/dpc.c | 9 +-
drivers/pci/pcie/err.c | 9 +-
4 files changed, 207 insertions(+), 99 deletions(-)
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Naveen Naidu <naveennaidu479@gmail.com>
To: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Naveen Naidu <naveennaidu479@gmail.com>,
skhan@linuxfoundation.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: [PATCH v2 0/8] Fix long standing AER Error Handling Issues
Date: Mon, 4 Oct 2021 19:36:26 +0530 [thread overview]
Message-ID: <cover.1633353468.git.naveennaidu479@gmail.com> (raw)
Message-ID: <20211004140626.qfYT6vRwor02wdMnnEjx6syJdNj2DSh3pe2CWUnLB0M@z> (raw)
This patch series aims at fixing some of the AER error handling issues
we have.
Currently we have the following issues:
- Confusing message in aer_print_error()
- aer_err_info not being initialized completely in DPC path before
we print the AER logs
- A bug [1] in clearing of AER registers in the native AER path
[1] https://lore.kernel.org/linux-pci/20151229155822.GA17321@localhost/
The primary aim of this patch series is to converge the APEI path and the
native AER error handling paths. In our current code, we find that we
have two different behaviours (especially when it comes to clearing of
the AER registers) for the same functionality.
This patch series, tries to bring the same semantics and hence more
commonanlity between the APEI part of code and the native OS
handling of AER errors.
PATCH 1:
- Fixes the first issue
PATCH 2 - 4:
- Fixes the second issue
- "Patch 3/8" is dependent on "Patch 2/3" in the series
PATCH 5 - 7
- Deals with converging the various paths and to bring more
commonality between them
- "Patch 6/8" depends on "Patch 1/8"
PATCH 8:
- Adds extra information in AER error logs.
Thanks,
Naveen Naidu
Changelog
=========
v2:
Apologies for the mistake, I forgot to cc the linux-pci mailing list.
Resent the email with cc to linux-pci.
Naveen Naidu (8):
[PATCH v2 1/8] PCI/AER: Remove ID from aer_agent_string[]
[PATCH v2 2/8] PCI: Cleanup struct aer_err_info
[PATCH v2 3/8] PCI/DPC: Initialize info->id in dpc_process_error()
[PATCH v2 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error()
[PATCH v2 5/8] PCI/DPC: Converge EDR and DPC Path of clearing AER registers
[PATCH v2 6/8] PCI/AER: Clear error device AER registers in aer_irq()
[PATCH v2 7/8] PCI/ERR: Remove redundant clearing of AER register in pcie_do_recovery()
[PATCH v2 8/8] PCI/AER: Include DEVCTL in aer_print_error()
drivers/pci/pci.h | 23 +++-
drivers/pci/pcie/aer.c | 265 ++++++++++++++++++++++++++++-------------
drivers/pci/pcie/dpc.c | 9 +-
drivers/pci/pcie/err.c | 9 +-
4 files changed, 207 insertions(+), 99 deletions(-)
--
2.25.1
next reply other threads:[~2021-10-04 22:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 13:52 Naveen Naidu [this message]
2021-10-04 13:52 ` [PATCH 1/8] PCI/AER: Remove ID from aer_agent_string[] Naveen Naidu
2021-10-04 14:06 ` [PATCH v2 " Naveen Naidu
2021-10-04 13:52 ` [PATCH 2/8] PCI: Cleanup struct aer_err_info Naveen Naidu
2021-10-04 14:06 ` [PATCH v2 " Naveen Naidu
2021-10-04 13:52 ` [PATCH 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() Naveen Naidu
2021-10-04 14:06 ` [PATCH v2 " Naveen Naidu
2021-10-04 13:52 ` [PATCH 5/8] PCI/DPC: Converge EDR and DPC Path of clearing AER registers Naveen Naidu
2021-10-04 14:06 ` [PATCH v2 " Naveen Naidu
2021-10-04 13:52 ` [PATCH 6/8] PCI/AER: Clear error device AER registers in aer_irq() Naveen Naidu
2021-10-04 14:06 ` [PATCH v2 " Naveen Naidu
2021-10-04 13:52 ` [PATCH 7/8] PCI/ERR: Remove redundant clearing of AER register in pcie_do_recovery() Naveen Naidu
2021-10-04 14:06 ` [PATCH v2 " Naveen Naidu
2021-10-04 13:52 ` [PATCH 8/8] PCI/AER: Include DEVCTL in aer_print_error() Naveen Naidu
2021-10-04 14:06 ` Naveen Naidu
2021-10-04 14:12 ` [PATCH v2 " Naveen Naidu
2021-10-04 14:06 ` [PATCH v2 0/8] Fix long standing AER Error Handling Issues Naveen Naidu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1633353468.git.naveennaidu479@gmail.com \
--to=naveennaidu479@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
--cc=ruscur@russell.cc \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).