* [Bisected] [commit 2ad56efa80dba89162106c06ebc00b611325e584] [linux-next] WARNING while booting to kernel 6.6.0-rc3-next-20230929
@ 2023-10-04 9:51 Tasmiya Nalatwad
0 siblings, 0 replies; 6+ messages in thread
From: Tasmiya Nalatwad @ 2023-10-04 9:51 UTC (permalink / raw)
To: linux-next, linuxppc-dev, iommu, linux-arm-kernel, linux-arm-msm
Cc: jroedel, gbatra, jgg, aik, mputtash, jsnitsel, sachinp, abdhalee,
alex.williamson, npiggin, baolu.lu
[-- Attachment #1: Type: text/plain, Size: 4227 bytes --]
Greetings,
[linux-next] [6.6.0-rc3-next-20230929] [git bisect ->
2ad56efa80dba89162106c06ebc00b611325e584]WARNING: CPU: 0 PID: 8 at
arch/powerpc/kernel/iommu.c:407 __iommu_free+0x1e4/0x1f0
--- Traces ---
[ 62.578338] WARNING: CPU: 0 PID: 8 at arch/powerpc/kernel/iommu.c:407
__iommu_free+0x1e4/0x1f0
[ 62.578345] Modules linked in: sd_mod t10_pi crc64_rocksoft crc64 sg
ibmvfc mlx5_core(+) scsi_transport_fc ibmveth mlxfw psample dm_multipath
dm_mirror dm_region_hash dm_log dm_mod fuse
[ 62.578362] CPU: 0 PID: 8 Comm: kworker/0:0 Not tainted
6.6.0-rc3-next-20230929-auto #1
[ 62.578366] Hardware name: IBM,9080-HEX POWER10 (raw) 0x800200
0xf000006 of:IBM,FW1030.30 (NH1030_062) hv:phyp pSeries
[ 62.578369] Workqueue: events work_for_cpu_fn
[ 62.578374] NIP: c00000000005f6d4 LR: c00000000005f6d0 CTR:
00000000005ca81c
[ 62.578377] REGS: c000000003a27890 TRAP: 0700 Not tainted
(6.6.0-rc3-next-20230929-auto)
[ 62.578381] MSR: 800000000282b033 <SF,VEC,VSX,EE,FP,ME,IR,DR,RI,LE>
CR: 48000824 XER: 00000008
[ 62.578391] CFAR: c00000000020f738 IRQMASK: 0
[ 62.578391] GPR00: c00000000005f6d0 c000000003a27b30 c000000001481800
0000000000000017
[ 62.578391] GPR04: 00000000ffff7fff c000000003a27950 c000000003a27948
0000000000000027
[ 62.578391] GPR08: c000000c18c07c10 0000000000000001 0000000000000027
c000000002ac8a08
[ 62.578391] GPR12: 0000000000000000 c000000002ff0000 c00000000019cc88
c000000003042300
[ 62.578391] GPR16: 0000000000000000 0000000000000000 0000000000000000
c000000003071ab0
[ 62.578391] GPR20: c00000000349f80d c000000003215440 c000000003215480
61c8864680b583eb
[ 62.578391] GPR24: 0000000000000000 000000007fffffff 0800000020000000
0000000000000010
[ 62.578391] GPR28: 0000000000020000 0000800000020000 c00000000c5dc800
c00000000c5dc880
[ 62.578428] NIP [c00000000005f6d4] __iommu_free+0x1e4/0x1f0
[ 62.578432] LR [c00000000005f6d0] __iommu_free+0x1e0/0x1f0
[ 62.578435] Call Trace:
[ 62.578437] [c000000003a27b30] [c00000000005f6d0]
__iommu_free+0x1e0/0x1f0 (unreliable)
[ 62.578442] [c000000003a27bc0] [c00000000005f848] iommu_free+0x28/0x70
[ 62.578446] [c000000003a27bf0] [c000000000061518]
iommu_free_coherent+0x68/0xa0
[ 62.578450] [c000000003a27c20] [c00000000005e8d4]
dma_iommu_free_coherent+0x24/0x40
[ 62.578455] [c000000003a27c40] [c00000000024698c]
dma_free_attrs+0x10c/0x140
[ 62.578459] [c000000003a27c90] [c008000000dcb8d4]
mlx5_cmd_cleanup+0x5c/0x90 [mlx5_core]
[ 62.578512] [c000000003a27cc0] [c008000000dc45a0]
mlx5_mdev_uninit+0xc8/0x100 [mlx5_core]
[ 62.578558] [c000000003a27d00] [c008000000dc4ac4]
probe_one+0x3ec/0x530 [mlx5_core]
[ 62.578602] [c000000003a27d90] [c0000000008c5edc]
local_pci_probe+0x6c/0x110
[ 62.578607] [c000000003a27e10] [c000000000189c98]
work_for_cpu_fn+0x38/0x60
[ 62.578612] [c000000003a27e40] [c00000000018d1d0]
process_scheduled_works+0x230/0x4f0
[ 62.578616] [c000000003a27f10] [c00000000018ff14]
worker_thread+0x1e4/0x500
[ 62.578619] [c000000003a27f90] [c00000000019cdb8] kthread+0x138/0x140
[ 62.578624] [c000000003a27fe0] [c00000000000df98]
start_kernel_thread+0x14/0x18
[ 62.578628] Code: 481b004d 60000000 e89e0028 3c62ffe0 3863dd20
481b0039 60000000 e89e0038 3c62ffe0 3863dd38 481b0025 60000000
<0fe00000> 4bffff20 60000000 3c4c0142
[ 62.578640] ---[ end trace 0000000000000000 ]---
[ 62.578646] iommu_free: invalid entry
[ 62.578649] entry = 0x8000000203d0
[ 62.578650] dma_addr = 0x8000000203d0000
[ 62.578652] Table = 0xc00000000c5dc800
[ 62.578654] bus# = 0x1
[ 62.578655] size = 0x20000
[ 62.578657] startOff = 0x800000000000
[ 62.578658] index = 0x70200016
[ 62.578660] ------------[ cut here ]------------
gitbisect is pointing to the below commit
commit 2ad56efa80dba89162106c06ebc00b611325e584
Author: Jason Gunthorpe <jgg@nvidia.com>
Date: Wed Sep 13 10:43:36 2023 -0300
powerpc/iommu: Setup a default domain and remove set_platform_dma_ops
--
Regards,
Tasmiya Nalatwad
IBM Linux Technology Center
[-- Attachment #2: Type: text/html, Size: 5533 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bisected] [commit 2ad56efa80dba89162106c06ebc00b611325e584] [linux-next] WARNING while booting to kernel 6.6.0-rc3-next-20230929
@ 2023-10-04 10:15 Tasmiya Nalatwad
0 siblings, 0 replies; 6+ messages in thread
From: Tasmiya Nalatwad @ 2023-10-04 10:15 UTC (permalink / raw)
To: linux-kernel, linux-next, linux-arm-kernel, linux-arm-msm, iommu,
linuxppc-dev
Cc: jroedel, gbatra, abdhalee, jsnitsel, sachinp, jgg, npiggin,
mputtash, baolu.lu
[-- Attachment #1: Type: text/plain, Size: 4144 bytes --]
Greetings,
[linux-next] [6.6.0-rc3-next-20230929] [git bisect ->
2ad56efa80dba89162106c06ebc00b611325e584]WARNING: CPU: 0 PID: 8 at
arch/powerpc/kernel/iommu.c:407 __iommu_free+0x1e4/0x1f0
--- Traces ---
[ 62.578338] WARNING: CPU: 0 PID: 8 at arch/powerpc/kernel/iommu.c:407
__iommu_free+0x1e4/0x1f0
[ 62.578345] Modules linked in: sd_mod t10_pi crc64_rocksoft crc64 sg
ibmvfc mlx5_core(+) scsi_transport_fc ibmveth mlxfw psample dm_multipath
dm_mirror dm_region_hash dm_log dm_mod fuse
[ 62.578362] CPU: 0 PID: 8 Comm: kworker/0:0 Not tainted
6.6.0-rc3-next-20230929-auto #1
[ 62.578366] Hardware name: IBM,9080-HEX POWER10 (raw) 0x800200
0xf000006 of:IBM,FW1030.30 (NH1030_062) hv:phyp pSeries
[ 62.578369] Workqueue: events work_for_cpu_fn
[ 62.578374] NIP: c00000000005f6d4 LR: c00000000005f6d0 CTR:
00000000005ca81c
[ 62.578377] REGS: c000000003a27890 TRAP: 0700 Not tainted
(6.6.0-rc3-next-20230929-auto)
[ 62.578381] MSR: 800000000282b033 <SF,VEC,VSX,EE,FP,ME,IR,DR,RI,LE>
CR: 48000824 XER: 00000008
[ 62.578391] CFAR: c00000000020f738 IRQMASK: 0
[ 62.578391] GPR00: c00000000005f6d0 c000000003a27b30 c000000001481800
0000000000000017
[ 62.578391] GPR04: 00000000ffff7fff c000000003a27950 c000000003a27948
0000000000000027
[ 62.578391] GPR08: c000000c18c07c10 0000000000000001 0000000000000027
c000000002ac8a08
[ 62.578391] GPR12: 0000000000000000 c000000002ff0000 c00000000019cc88
c000000003042300
[ 62.578391] GPR16: 0000000000000000 0000000000000000 0000000000000000
c000000003071ab0
[ 62.578391] GPR20: c00000000349f80d c000000003215440 c000000003215480
61c8864680b583eb
[ 62.578391] GPR24: 0000000000000000 000000007fffffff 0800000020000000
0000000000000010
[ 62.578391] GPR28: 0000000000020000 0000800000020000 c00000000c5dc800
c00000000c5dc880
[ 62.578428] NIP [c00000000005f6d4] __iommu_free+0x1e4/0x1f0
[ 62.578432] LR [c00000000005f6d0] __iommu_free+0x1e0/0x1f0
[ 62.578435] Call Trace:
[ 62.578437] [c000000003a27b30] [c00000000005f6d0]
__iommu_free+0x1e0/0x1f0 (unreliable)
[ 62.578442] [c000000003a27bc0] [c00000000005f848] iommu_free+0x28/0x70
[ 62.578446] [c000000003a27bf0] [c000000000061518]
iommu_free_coherent+0x68/0xa0
[ 62.578450] [c000000003a27c20] [c00000000005e8d4]
dma_iommu_free_coherent+0x24/0x40
[ 62.578455] [c000000003a27c40] [c00000000024698c]
dma_free_attrs+0x10c/0x140
[ 62.578459] [c000000003a27c90] [c008000000dcb8d4]
mlx5_cmd_cleanup+0x5c/0x90 [mlx5_core]
[ 62.578512] [c000000003a27cc0] [c008000000dc45a0]
mlx5_mdev_uninit+0xc8/0x100 [mlx5_core]
[ 62.578558] [c000000003a27d00] [c008000000dc4ac4]
probe_one+0x3ec/0x530 [mlx5_core]
[ 62.578602] [c000000003a27d90] [c0000000008c5edc]
local_pci_probe+0x6c/0x110
[ 62.578607] [c000000003a27e10] [c000000000189c98]
work_for_cpu_fn+0x38/0x60
[ 62.578612] [c000000003a27e40] [c00000000018d1d0]
process_scheduled_works+0x230/0x4f0
[ 62.578616] [c000000003a27f10] [c00000000018ff14]
worker_thread+0x1e4/0x500
[ 62.578619] [c000000003a27f90] [c00000000019cdb8] kthread+0x138/0x140
[ 62.578624] [c000000003a27fe0] [c00000000000df98]
start_kernel_thread+0x14/0x18
[ 62.578628] Code: 481b004d 60000000 e89e0028 3c62ffe0 3863dd20
481b0039 60000000 e89e0038 3c62ffe0 3863dd38 481b0025 60000000
<0fe00000> 4bffff20 60000000 3c4c0142
[ 62.578640] ---[ end trace 0000000000000000 ]---
[ 62.578646] iommu_free: invalid entry
[ 62.578649] entry = 0x8000000203d0
[ 62.578650] dma_addr = 0x8000000203d0000
[ 62.578652] Table = 0xc00000000c5dc800
[ 62.578654] bus# = 0x1
[ 62.578655] size = 0x20000
[ 62.578657] startOff = 0x800000000000
[ 62.578658] index = 0x70200016
[ 62.578660] ------------[ cut here ]------------
gitbisect is pointing to the below commit
commit 2ad56efa80dba89162106c06ebc00b611325e584
powerpc/iommu: Setup a default domain and remove set_platform_dma_ops
--
Regards,
Tasmiya Nalatwad
IBM Linux Technology Center
[-- Attachment #2: Type: text/html, Size: 5353 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bisected] [commit 2ad56efa80dba89162106c06ebc00b611325e584] [linux-next] WARNING while booting to kernel 6.6.0-rc3-next-20230929
@ 2023-10-04 11:07 Tasmiya Nalatwad
2023-10-04 11:38 ` Jason Gunthorpe
0 siblings, 1 reply; 6+ messages in thread
From: Tasmiya Nalatwad @ 2023-10-04 11:07 UTC (permalink / raw)
To: linux-kernel, linux-next
Cc: jroedel, gbatra, abdhalee, ruscur, jsnitsel, npiggin, sachinp,
jgg, mputtash, jgg, gregkh, linuxppc-dev, baolu.lu
[-- Attachment #1: Type: text/plain, Size: 4144 bytes --]
Greetings,
[linux-next] [6.6.0-rc3-next-20230929] [git bisect ->
2ad56efa80dba89162106c06ebc00b611325e584]WARNING: CPU: 0 PID: 8 at
arch/powerpc/kernel/iommu.c:407 __iommu_free+0x1e4/0x1f0
--- Traces ---
[ 62.578338] WARNING: CPU: 0 PID: 8 at arch/powerpc/kernel/iommu.c:407
__iommu_free+0x1e4/0x1f0
[ 62.578345] Modules linked in: sd_mod t10_pi crc64_rocksoft crc64 sg
ibmvfc mlx5_core(+) scsi_transport_fc ibmveth mlxfw psample dm_multipath
dm_mirror dm_region_hash dm_log dm_mod fuse
[ 62.578362] CPU: 0 PID: 8 Comm: kworker/0:0 Not tainted
6.6.0-rc3-next-20230929-auto #1
[ 62.578366] Hardware name: IBM,9080-HEX POWER10 (raw) 0x800200
0xf000006 of:IBM,FW1030.30 (NH1030_062) hv:phyp pSeries
[ 62.578369] Workqueue: events work_for_cpu_fn
[ 62.578374] NIP: c00000000005f6d4 LR: c00000000005f6d0 CTR:
00000000005ca81c
[ 62.578377] REGS: c000000003a27890 TRAP: 0700 Not tainted
(6.6.0-rc3-next-20230929-auto)
[ 62.578381] MSR: 800000000282b033 <SF,VEC,VSX,EE,FP,ME,IR,DR,RI,LE>
CR: 48000824 XER: 00000008
[ 62.578391] CFAR: c00000000020f738 IRQMASK: 0
[ 62.578391] GPR00: c00000000005f6d0 c000000003a27b30 c000000001481800
0000000000000017
[ 62.578391] GPR04: 00000000ffff7fff c000000003a27950 c000000003a27948
0000000000000027
[ 62.578391] GPR08: c000000c18c07c10 0000000000000001 0000000000000027
c000000002ac8a08
[ 62.578391] GPR12: 0000000000000000 c000000002ff0000 c00000000019cc88
c000000003042300
[ 62.578391] GPR16: 0000000000000000 0000000000000000 0000000000000000
c000000003071ab0
[ 62.578391] GPR20: c00000000349f80d c000000003215440 c000000003215480
61c8864680b583eb
[ 62.578391] GPR24: 0000000000000000 000000007fffffff 0800000020000000
0000000000000010
[ 62.578391] GPR28: 0000000000020000 0000800000020000 c00000000c5dc800
c00000000c5dc880
[ 62.578428] NIP [c00000000005f6d4] __iommu_free+0x1e4/0x1f0
[ 62.578432] LR [c00000000005f6d0] __iommu_free+0x1e0/0x1f0
[ 62.578435] Call Trace:
[ 62.578437] [c000000003a27b30] [c00000000005f6d0]
__iommu_free+0x1e0/0x1f0 (unreliable)
[ 62.578442] [c000000003a27bc0] [c00000000005f848] iommu_free+0x28/0x70
[ 62.578446] [c000000003a27bf0] [c000000000061518]
iommu_free_coherent+0x68/0xa0
[ 62.578450] [c000000003a27c20] [c00000000005e8d4]
dma_iommu_free_coherent+0x24/0x40
[ 62.578455] [c000000003a27c40] [c00000000024698c]
dma_free_attrs+0x10c/0x140
[ 62.578459] [c000000003a27c90] [c008000000dcb8d4]
mlx5_cmd_cleanup+0x5c/0x90 [mlx5_core]
[ 62.578512] [c000000003a27cc0] [c008000000dc45a0]
mlx5_mdev_uninit+0xc8/0x100 [mlx5_core]
[ 62.578558] [c000000003a27d00] [c008000000dc4ac4]
probe_one+0x3ec/0x530 [mlx5_core]
[ 62.578602] [c000000003a27d90] [c0000000008c5edc]
local_pci_probe+0x6c/0x110
[ 62.578607] [c000000003a27e10] [c000000000189c98]
work_for_cpu_fn+0x38/0x60
[ 62.578612] [c000000003a27e40] [c00000000018d1d0]
process_scheduled_works+0x230/0x4f0
[ 62.578616] [c000000003a27f10] [c00000000018ff14]
worker_thread+0x1e4/0x500
[ 62.578619] [c000000003a27f90] [c00000000019cdb8] kthread+0x138/0x140
[ 62.578624] [c000000003a27fe0] [c00000000000df98]
start_kernel_thread+0x14/0x18
[ 62.578628] Code: 481b004d 60000000 e89e0028 3c62ffe0 3863dd20
481b0039 60000000 e89e0038 3c62ffe0 3863dd38 481b0025 60000000
<0fe00000> 4bffff20 60000000 3c4c0142
[ 62.578640] ---[ end trace 0000000000000000 ]---
[ 62.578646] iommu_free: invalid entry
[ 62.578649] entry = 0x8000000203d0
[ 62.578650] dma_addr = 0x8000000203d0000
[ 62.578652] Table = 0xc00000000c5dc800
[ 62.578654] bus# = 0x1
[ 62.578655] size = 0x20000
[ 62.578657] startOff = 0x800000000000
[ 62.578658] index = 0x70200016
[ 62.578660] ------------[ cut here ]------------
gitbisect is pointing to the below commit
commit 2ad56efa80dba89162106c06ebc00b611325e584
powerpc/iommu: Setup a default domain and remove set_platform_dma_ops
--
Regards,
Tasmiya Nalatwad
IBM Linux Technology Center
[-- Attachment #2: Type: text/html, Size: 5349 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bisected] [commit 2ad56efa80dba89162106c06ebc00b611325e584] [linux-next] WARNING while booting to kernel 6.6.0-rc3-next-20230929
@ 2023-10-04 11:16 Tasmiya Nalatwad
0 siblings, 0 replies; 6+ messages in thread
From: Tasmiya Nalatwad @ 2023-10-04 11:16 UTC (permalink / raw)
To: linux-kernel, linux-next, linuxppc-dev, linux-arm-kernel,
linux-arm-msm
Cc: jroedel, gbatra, abdhalee, ruscur, jsnitsel, npiggin, sachinp,
jgg, mputtash, jgg, gregkh, baolu.lu
[-- Attachment #1: Type: text/plain, Size: 4141 bytes --]
Greetings,
[linux-next] [6.6.0-rc3-next-20230929] [git bisect ->
2ad56efa80dba89162106c06ebc00b611325e584]WARNING: CPU: 0 PID: 8 at
arch/powerpc/kernel/iommu.c:407__iommu_free+0x1e4/0x1f0
--- Traces ---
[ 62.578338] WARNING: CPU: 0 PID: 8 at
arch/powerpc/kernel/iommu.c:407__iommu_free+0x1e4/0x1f0
[ 62.578345] Modules linked in: sd_mod t10_pi crc64_rocksoft crc64 sg
ibmvfc mlx5_core(+) scsi_transport_fc ibmveth mlxfw psample dm_multipath
dm_mirror dm_region_hash dm_log dm_mod fuse
[ 62.578362] CPU: 0 PID: 8 Comm: kworker/0:0 Not tainted
6.6.0-rc3-next-20230929-auto #1
[ 62.578366] Hardware name: IBM,9080-HEX POWER10 (raw) 0x800200
0xf000006 of:IBM,FW1030.30 (NH1030_062) hv:phyp Series
[ 62.578369] Workqueue: events work_for_cpu_fn
[ 62.578374] NIP: c00000000005f6d4 LR: c00000000005f6d0 CTR:
00000000005ca81c
[ 62.578377] REGS: c000000003a27890 TRAP: 0700 Not tainted
(6.6.0-rc3-next-20230929-auto)
[ 62.578381] MSR: 800000000282b033 <SF,VEC,VSX,EE,FP,ME,IR,DR,RI,LE>
CR: 48000824 XER: 00000008
[ 62.578391] CFAR: c00000000020f738 IRQMASK: 0
[ 62.578391] GPR00: c00000000005f6d0 c000000003a27b30 c000000001481800
0000000000000017
[ 62.578391] GPR04: 00000000ffff7fff c000000003a27950 c000000003a27948
0000000000000027
[ 62.578391] GPR08: c000000c18c07c10 0000000000000001 0000000000000027
c000000002ac8a08
[ 62.578391] GPR12: 0000000000000000 c000000002ff0000 c00000000019cc88
c000000003042300
[ 62.578391] GPR16: 0000000000000000 0000000000000000 0000000000000000
c000000003071ab0
[ 62.578391] GPR20: c00000000349f80d c000000003215440 c000000003215480
61c8864680b583eb
[ 62.578391] GPR24: 0000000000000000 000000007fffffff 0800000020000000
0000000000000010
[ 62.578391] GPR28: 0000000000020000 0000800000020000 c00000000c5dc800
c00000000c5dc880
[ 62.578428] NIP [c00000000005f6d4] __iommu_free+0x1e4/0x1f0
[ 62.578432] LR [c00000000005f6d0] __iommu_free+0x1e0/0x1f0
[ 62.578435] Call Trace:
[ 62.578437] [c000000003a27b30] [c00000000005f6d0]
__iommu_free+0x1e0/0x1f0 (unreliable)
[ 62.578442] [c000000003a27bc0] [c00000000005f848] iommu_free+0x28/0x70
[ 62.578446] [c000000003a27bf0] [c000000000061518]
iommu_free_coherent+0x68/0xa0
[ 62.578450] [c000000003a27c20] [c00000000005e8d4]
dma_iommu_free_coherent+0x24/0x40
[ 62.578455] [c000000003a27c40] [c00000000024698c]
dma_free_attrs+0x10c/0x140
[ 62.578459] [c000000003a27c90] [c008000000dcb8d4]
mlx5_cmd_cleanup+0x5c/0x90 [mlx5_core]
[ 62.578512] [c000000003a27cc0] [c008000000dc45a0]
mlx5_mdev_uninit+0xc8/0x100 [mlx5_core]
[ 62.578558] [c000000003a27d00] [c008000000dc4ac4]
probe_one+0x3ec/0x530 [mlx5_core]
[ 62.578602] [c000000003a27d90] [c0000000008c5edc]
local_pci_probe+0x6c/0x110
[ 62.578607] [c000000003a27e10] [c000000000189c98]
work_for_cpu_fn+0x38/0x60
[ 62.578612] [c000000003a27e40] [c00000000018d1d0]
process_scheduled_works+0x230/0x4f0
[ 62.578616] [c000000003a27f10] [c00000000018ff14]
worker_thread+0x1e4/0x500
[ 62.578619] [c000000003a27f90] [c00000000019cdb8] kthread+0x138/0x140
[ 62.578624] [c000000003a27fe0] [c00000000000df98]
start_kernel_thread+0x14/0x18
[ 62.578628] Code: 481b004d 60000000 e89e0028 3c62ffe0 3863dd20
481b0039 60000000 e89e0038 3c62ffe0 3863dd38 481b0025 60000000
<0fe00000> 4bffff20 60000000 3c4c0142
[ 62.578640] ---[ end trace 0000000000000000 ]---
[ 62.578646] iommu_free: invalid entry
[ 62.578649] entry = 0x8000000203d0
[ 62.578650] dma_addr = 0x8000000203d0000
[ 62.578652] Table = 0xc00000000c5dc800
[ 62.578654] bus# = 0x1
[ 62.578655] size = 0x20000
[ 62.578657] startOff = 0x800000000000
[ 62.578658] index = 0x70200016
[ 62.578660] ------------[ cut here ]------------
gitbisect is pointing to the below commit
commit 2ad56efa80dba89162106c06ebc00b611325e584
powerpc/iommu: Setup a default domain and remove set_platform_dma_ops
--
Regards,
Tasmiya Nalatwad
IBM Linux Technology Center
[-- Attachment #2: Type: text/html, Size: 5448 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Bisected] [commit 2ad56efa80dba89162106c06ebc00b611325e584] [linux-next] WARNING while booting to kernel 6.6.0-rc3-next-20230929
2023-10-04 11:07 [Bisected] [commit 2ad56efa80dba89162106c06ebc00b611325e584] [linux-next] WARNING while booting to kernel 6.6.0-rc3-next-20230929 Tasmiya Nalatwad
@ 2023-10-04 11:38 ` Jason Gunthorpe
2023-10-04 14:11 ` Tasmiya Nalatwad
0 siblings, 1 reply; 6+ messages in thread
From: Jason Gunthorpe @ 2023-10-04 11:38 UTC (permalink / raw)
To: Tasmiya Nalatwad
Cc: jroedel, mputtash, gbatra, ruscur, jsnitsel, linux-kernel,
npiggin, sachinp, abdhalee, linux-next, gregkh, linuxppc-dev,
baolu.lu
On Wed, Oct 04, 2023 at 04:37:10PM +0530, Tasmiya Nalatwad wrote:
> Greetings,
>
> [linux-next] [6.6.0-rc3-next-20230929] [git bisect ->
> 2ad56efa80dba89162106c06ebc00b611325e584]WARNING: CPU: 0 PID: 8 at
> arch/powerpc/kernel/[1]iommu.c:407 __iommu_free+0x1e4/0x1f0
> gitbisect is pointing to the below commit
> commit 2ad56efa80dba89162106c06ebc00b611325e584
> powerpc/iommu: Setup a default domain and remove set_platform_dma_ops
I assume this means there are still sequencing problems with power at
boot time. eg we turned on the dma ops in the wrong order or something
like that
As far as I can see the only difference here is that we do the
operation to claim dma ops during the iommu drive probe. We can avoid that.
Does this work for you?
diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c
index d6ad3fde85a212..115b9031badac7 100644
--- a/arch/powerpc/kernel/iommu.c
+++ b/arch/powerpc/kernel/iommu.c
@@ -1280,13 +1280,19 @@ struct iommu_table_group_ops spapr_tce_table_group_ops = {
/*
* A simple iommu_ops to allow less cruft in generic VFIO code.
*/
-static int spapr_tce_platform_iommu_attach_dev(struct iommu_domain *dom,
- struct device *dev)
+static int
+spapr_tce_platform_iommu_attach_dev(struct iommu_domain *platform_domain,
+ struct device *dev)
{
+ struct iommu_domain *domain = iommu_get_domain_for_dev(dev);
struct iommu_group *grp = iommu_group_get(dev);
struct iommu_table_group *table_group;
int ret = -EINVAL;
+ /* At first attach the ownership is already set */
+ if (!domain)
+ return 0;
+
if (!grp)
return -ENODEV;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Bisected] [commit 2ad56efa80dba89162106c06ebc00b611325e584] [linux-next] WARNING while booting to kernel 6.6.0-rc3-next-20230929
2023-10-04 11:38 ` Jason Gunthorpe
@ 2023-10-04 14:11 ` Tasmiya Nalatwad
0 siblings, 0 replies; 6+ messages in thread
From: Tasmiya Nalatwad @ 2023-10-04 14:11 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: jroedel, mputtash, gbatra, ruscur, jsnitsel, linux-kernel,
npiggin, sachinp, abdhalee, linux-next, gregkh, linuxppc-dev,
baolu.lu
Thanks Jason. Yes the suggested changes works and Warnings are not seen.
On 10/4/23 17:08, Jason Gunthorpe wrote:
> On Wed, Oct 04, 2023 at 04:37:10PM +0530, Tasmiya Nalatwad wrote:
>> Greetings,
>>
>> [linux-next] [6.6.0-rc3-next-20230929] [git bisect ->
>> 2ad56efa80dba89162106c06ebc00b611325e584]WARNING: CPU: 0 PID: 8 at
>> arch/powerpc/kernel/[1]iommu.c:407 __iommu_free+0x1e4/0x1f0
>> gitbisect is pointing to the below commit
>> commit 2ad56efa80dba89162106c06ebc00b611325e584
>> powerpc/iommu: Setup a default domain and remove set_platform_dma_ops
> I assume this means there are still sequencing problems with power at
> boot time. eg we turned on the dma ops in the wrong order or something
> like that
>
> As far as I can see the only difference here is that we do the
> operation to claim dma ops during the iommu drive probe. We can avoid that.
>
> Does this work for you?
>
> diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c
> index d6ad3fde85a212..115b9031badac7 100644
> --- a/arch/powerpc/kernel/iommu.c
> +++ b/arch/powerpc/kernel/iommu.c
> @@ -1280,13 +1280,19 @@ struct iommu_table_group_ops spapr_tce_table_group_ops = {
> /*
> * A simple iommu_ops to allow less cruft in generic VFIO code.
> */
> -static int spapr_tce_platform_iommu_attach_dev(struct iommu_domain *dom,
> - struct device *dev)
> +static int
> +spapr_tce_platform_iommu_attach_dev(struct iommu_domain *platform_domain,
> + struct device *dev)
> {
> + struct iommu_domain *domain = iommu_get_domain_for_dev(dev);
> struct iommu_group *grp = iommu_group_get(dev);
> struct iommu_table_group *table_group;
> int ret = -EINVAL;
>
> + /* At first attach the ownership is already set */
> + if (!domain)
> + return 0;
> +
> if (!grp)
> return -ENODEV;
>
>
--
Regards,
Tasmiya Nalatwad
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-10-04 14:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-04 11:07 [Bisected] [commit 2ad56efa80dba89162106c06ebc00b611325e584] [linux-next] WARNING while booting to kernel 6.6.0-rc3-next-20230929 Tasmiya Nalatwad
2023-10-04 11:38 ` Jason Gunthorpe
2023-10-04 14:11 ` Tasmiya Nalatwad
-- strict thread matches above, loose matches on Subject: below --
2023-10-04 11:16 Tasmiya Nalatwad
2023-10-04 10:15 Tasmiya Nalatwad
2023-10-04 9:51 Tasmiya Nalatwad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).