From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEC6BC4828D for ; Wed, 7 Feb 2024 11:52:47 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=QX6XU+s2; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TVJQP6hTvz3bvX for ; Wed, 7 Feb 2024 22:52:45 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=QX6XU+s2; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=198.175.65.15; helo=mgamail.intel.com; envelope-from=ilpo.jarvinen@linux.intel.com; receiver=lists.ozlabs.org) X-Greylist: delayed 64 seconds by postgrey-1.37 at boromir; Wed, 07 Feb 2024 22:51:59 AEDT Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TVJPW3zF3z2yVL for ; Wed, 7 Feb 2024 22:51:59 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707306720; x=1738842720; h=from:date:to:cc:subject:in-reply-to:message-id: references:mime-version:content-id; bh=SfvJn+xoupBR1MbkXFoDnA5hLXb3/g/1CcV8cOlXD/A=; b=QX6XU+s2YzXZmbv2AaQ54CIEcAtDAOJXEW8w/77+wKUkA0RuHN7AEsaG 2dVxmEZzbffvtQ8Ssx+jjtSUoGxNyDyrivzbba2O0WmPmeDi+5vggaWse wLLTgmannTCWprvTguPDMrl3y+B3iqcPhAoGkxttvb1Nn08Ek/lxXFsn0 yhB7zgt++QSrPE/sYfcAtyFjlN87QaMQO5RWaBp+fAxJFEclAy/jWrV7X KS0qxHtiKSY+QgcuCIWzbptHo1z2IJNQy2IcZKafz5cT+zmIWToFlioLE 8ZWh46L42RPhlQufpW2SyMiEkxflgQP18iu4zhCJtZYtGlEDlo+aAcFnz g==; X-IronPort-AV: E=McAfee;i="6600,9927,10976"; a="4837025" X-IronPort-AV: E=Sophos;i="6.05,250,1701158400"; d="scan'208";a="4837025" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2024 03:50:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10976"; a="909976005" X-IronPort-AV: E=Sophos;i="6.05,250,1701158400"; d="scan'208";a="909976005" Received: from ijarvine-desk1.ger.corp.intel.com (HELO localhost) ([10.246.51.96]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2024 03:50:43 -0800 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Date: Wed, 7 Feb 2024 13:50:37 +0200 (EET) To: linux-pci@vger.kernel.org, "Wang, Qingshun" Subject: Re: [PATCH 0/4] PCI: Consolidate TLP Log reading and printing In-Reply-To: <20240206135717.8565-1-ilpo.jarvinen@linux.intel.com> Message-ID: References: <20240206135717.8565-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323328-2015099635-1707302934=:1119" Content-ID: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oliver O'Halloran , linux-efi@vger.kernel.org, Borislav Petkov , Tony Luck , Paolo Abeni , LKML , Jesse Brandeburg , "David S. Miller" , Eric Dumazet , Netdev , Tony Nguyen , Jakub Kicinski , Bjorn Helgaas , intel-wired-lan@lists.osuosl.org, Mahesh J Salgaonkar , linuxppc-dev@lists.ozlabs.org, Ard Biesheuvel , linux-edac@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-2015099635-1707302934=:1119 Content-Type: text/plain; CHARSET=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Content-ID: <5d24dca6-e3dc-f4f5-8d6c-ee0d65616a2f@linux.intel.com> Adding Cc Quigshun which I ended up forgotting despite thinking it at one= =20 point. --=20 i. On Tue, 6 Feb 2024, Ilpo J=E4rvinen wrote: > This series consolidates AER & DPC TLP Log handling code. Helpers are > added for reading and printing the TLP Log and the format is made to > include E-E Prefixes in both cases (previously only one DPC RP PIO > displayed the E-E Prefixes). >=20 > I'd appreciate if people familiar with ixgbe could check the error > handling conversion within the driver is correct. >=20 > Ilpo J=E4rvinen (4): > PCI/AER: Cleanup register variable > PCI: Generalize TLP Header Log reading > PCI: Add TLP Prefix reading into pcie_read_tlp_log() > PCI: Create helper to print TLP Header and Prefix Log >=20 > drivers/firmware/efi/cper.c | 4 +- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 39 +++------ > drivers/pci/ats.c | 2 +- > drivers/pci/pci.c | 79 +++++++++++++++++++ > drivers/pci/pci.h | 2 +- > drivers/pci/pcie/aer.c | 28 ++----- > drivers/pci/pcie/dpc.c | 31 ++++---- > drivers/pci/probe.c | 14 ++-- > include/linux/aer.h | 16 ++-- > include/linux/pci.h | 2 +- > include/ras/ras_event.h | 10 +-- > include/uapi/linux/pci_regs.h | 2 + > 12 files changed, 145 insertions(+), 84 deletions(-) >=20 >=20 --8323328-2015099635-1707302934=:1119--