From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.197]) by ozlabs.org (Postfix) with ESMTP id 28D2F68869 for ; Fri, 16 Dec 2005 08:38:54 +1100 (EST) Received: by wproxy.gmail.com with SMTP id i2so793681wra for ; Thu, 15 Dec 2005 13:38:53 -0800 (PST) Message-ID: Date: Thu, 15 Dec 2005 16:38:52 -0500 From: Dmitry Torokhov To: Michael Hanselmann In-Reply-To: <20051215212635.GA6195@hansmi.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20051213223659.GB20017@hansmi.ch> <1134568620.3875.6.camel@localhost> <20051214213923.GB17548@hansmi.ch> <20051214233108.GA20127@hansmi.ch> <20051215195017.GA7195@pb15.lixom.net> <20051215212635.GA6195@hansmi.ch> Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, linux-input@atrey.karlin.mff.cuni.cz, kernel-stuff@comcast.net Subject: Re: [PATCH 2.6 1/2] usb/input: Add relayfs support to appletouch driver Reply-To: dtor_core@ameritech.net List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 12/15/05, Michael Hanselmann wrote: > On Thu, Dec 15, 2005 at 11:50:17AM -0800, Olof Johansson wrote: > > I think I agree with previous comments regarding debug code in the driv= er: > > It's unlikely to ever be used by more than a couple of people at very > > rare occasions (new hardware releases), and the barrier to using it is > > still high; new users need to learn how to parse the data anyway. I don= 't > > see a reason to include this in mainline. > > Okay, based on your comments, please drop that patch. How about the one > to support the Geyser 2 device? Should I do a rediff without relayfs > support? > If you could rediff it without relayfs I would add it to the input tree. Altough I am not sure if manually unrolling that loop is such a good idea. Maybe we should leave it to the compiler? -- Dmitry