From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nz-out-0506.google.com (nz-out-0506.google.com [64.233.162.232]) by ozlabs.org (Postfix) with ESMTP id 45679DDECA for ; Sat, 21 Jul 2007 03:47:39 +1000 (EST) Received: by nz-out-0506.google.com with SMTP id l1so834421nzf for ; Fri, 20 Jul 2007 10:47:37 -0700 (PDT) Message-ID: Date: Fri, 20 Jul 2007 13:47:36 -0400 From: "Dmitry Torokhov" To: "Geert Uytterhoeven" Subject: Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible In-Reply-To: <20070720164323.625963918@mail.of.borg> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed References: <20070720164043.523003359@mail.of.borg> <20070720164323.625963918@mail.of.borg> Cc: linux-input@atrey.karlin.mff.cuni.cz, linuxppc-dev@ozlabs.org, Andrew Morton , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Geert, On 7/20/07, Geert Uytterhoeven wrote: > From: Geert Uytterhoeven > > m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible > > drivers/char/keyboard.c: In function 'kbd_keycode': > drivers/char/keyboard.c:1142: error: implicit declaration of function 'mac_hid_mouse_emulate_buttons' > > The forward declaration of mac_hid_mouse_emulate_buttons() is not visible on > m68k because it's hidden in the middle of a big #ifdef block. > > Move it to , correct the type of the second parameter, and > include where needed. linux/hid.h contains definitions needed for drivers speaking HID protocol, I don't think we want to put quirks for legacy keyboard driver there. I'd just move the #ifdef within drivers/char/keyboard.c for now. BTW, I don't think that mac button emulation will work well when x86 evdev-based driver gains popularity - it "grabs" the device and so no event will flow through keyboard driver... We'd need a new solution... -- Dmitry