From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Anton Ekblad <valderman@gmail.com>
Subject: Re: [PATCH] fix appletouch geyser 1 breakage
Date: Wed, 24 Oct 2007 08:55:58 -0400 [thread overview]
Message-ID: <d120d5000710240555m545a4f95v8bfc1ac790273001@mail.gmail.com> (raw)
In-Reply-To: <1193222676.4510.5.camel@johannes.berg>
Hi Johannes,
On 10/24/07, Johannes Berg <johannes@sipsolutions.net> wrote:
> The patch 46249ea60fbb61a72ee6929b831b1f3e6865f024 was obviously done
> without testing on a Geyser 1,
My fault, sorry. However Anton's device has product ID of 90x30B which
is Geyser 1 as far as I understand... But yes, we should not expect
other geysers respond to Geyser 3-specific commands.
> and I'm a very annoyed that it was
> applied. It causes appletouch to continuously printk:
>
> drivers/input/mouse/appletouch.c: Could not do mode read request from device (Geyser 3 mode)
>
> because the Geyser 1 doesn't respond to that. The patch description also
> states:
>
> > if we see 10 empty packets the touchpad needs to be reset; good
> > touchpads should not send empty packets anyway.
>
> which is *TOTALLY* bogus since Geyser 1 touchpads have no notion of
> empty packets, the simply continuously send measurements. One look at
> the specification would have confirmed that.
>
Is there a way to "plug" these Geysers? Waking up the kernel
continuously is not nice.
--
Dmitry
next prev parent reply other threads:[~2007-10-24 12:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 10:44 [PATCH] fix appletouch geyser 1 breakage Johannes Berg
2007-10-24 11:22 ` Johannes Berg
2007-10-24 11:29 ` [PATCH v2] appletouch: fix fountain touchpad breakage Johannes Berg
2007-10-24 12:55 ` Dmitry Torokhov [this message]
2007-10-24 13:05 ` [PATCH] fix appletouch geyser 1 breakage Johannes Berg
2007-10-24 13:34 ` Dmitry Torokhov
2007-10-24 13:36 ` Johannes Berg
2007-10-24 14:29 ` Dmitry Torokhov
2007-10-25 13:23 ` Johannes Berg
2007-10-25 18:28 ` Benjamin Berg
2007-10-26 16:05 ` Dmitry Torokhov
2007-10-26 20:31 ` Johannes Berg
2007-10-28 5:00 ` Dmitry Torokhov
2007-10-28 10:31 ` Johannes Berg
2007-10-28 14:54 ` Dmitry Torokhov
2007-10-28 15:08 ` Johannes Berg
2007-10-29 5:09 ` Dmitry Torokhov
2007-10-29 8:12 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000710240555m545a4f95v8bfc1ac790273001@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=valderman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).