From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ew0-f21.google.com (mail-ew0-f21.google.com [209.85.219.21]) by ozlabs.org (Postfix) with ESMTP id DC14DDDDB6 for ; Fri, 20 Feb 2009 03:48:05 +1100 (EST) Received: by ewy14 with SMTP id 14so765373ewy.9 for ; Thu, 19 Feb 2009 08:48:03 -0800 (PST) MIME-Version: 1.0 Sender: sylvain.joyeau@gmail.com In-Reply-To: <43EB80E07C42E1408726E4905FB96B04C07700@CYBORG3.cyclone.com> References: <43EB80E07C42E1408726E4905FB96B04C0769D@CYBORG3.cyclone.com> <43EB80E07C42E1408726E4905FB96B04C076B1@CYBORG3.cyclone.com> <6BBF4AB4-FFB0-46ED-B591-17DEC3BE547F@kernel.crashing.org> <43EB80E07C42E1408726E4905FB96B04C07700@CYBORG3.cyclone.com> Date: Thu, 19 Feb 2009 17:48:03 +0100 Message-ID: Subject: Re: Gianfar tx-babbling-errors From: "sjoyeau@wanadoo.fr" To: Scott Coulter Content-Type: multipart/alternative; boundary=0015174c0f86bc79570463484c73 Cc: linuxppc-dev@ozlabs.org Reply-To: sjoyeau@wanadoo.fr List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --0015174c0f86bc79570463484c73 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi Scott, Your issue may come from data setup (or corruption) instead of code path: babbling error may occurs when a TSEC TX descriptor hasn't its "last frame" bit set or when the data length is greated than max frame length. -- sj 2009/2/19 Scott Coulter > > > Kumar, > > > > > can't think of any. How about adding a BUG_ON() in the tx path to see > > if the buffer size > MTU and re-run your tests. > > > > So, here are the checks I've tried in gfar_start_xmit(): > > BUG_ON(skb->len > DEFAULT_RX_BUFFER_SIZE) > > BUG_ON(skb->len > priv->regs->maxfrm) > > Neither produces a bug check yet ethtool reports non-zero > tx-babbling-errors. The last check appears to be the definition of > tx-babbling-errors. Is there a transmit path that I have missed? > > Scott > > ___________________________________________________________________ > > Scott N. Coulter > Senior Software Engineer > > Cyclone Microsystems > 370 James Street Phone: 203.786.5536 ext. 118 > New Haven, CT 06513-3051 Email: scott.coulter@cyclone.com > U.S.A. Web: http://www.cyclone.com > ___________________________________________________________________ > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev > --=20 ------------------ Sylvain JOYEAU Freelance Engineer Software RT-OS R&D sylvain.joyeau@gmail.com T=E9l: +33-(0)667 477 052 "A good idea is one side of the coin. The other side is the practical usefulness". J. Liedke. --0015174c0f86bc79570463484c73 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi Scott,

Your issue may come from data setup (or corruption) instea= d of code path: babbling error may occurs when a TSEC TX descriptor hasn= 9;t its "last frame" bit set or when the data length is greated t= han max frame length.

--
sj

2009/2/19 Scott Coulter <scott.coulter@cyclone.com>


Kumar,

>
> can't think of any.  How about adding a BUG_ON() in the tx pa= th to see
> if the buffer size > MTU and re-run your tests.
>

So, here are the checks I've tried in gfar_start_xmit():

BUG_ON(skb->len > DEFAULT_RX_BUFFER_SIZE)

BUG_ON(skb->len > priv->regs->maxfrm)

Neither produces a bug check yet ethtool reports non-zero
tx-babbling-errors.  The last check appears to be the definition of tx-babbling-errors.  Is there a transmit path that I have missed?

Scott

___________________________________________________________________

 Scott N. Coulter
 Senior Software Engineer

 Cyclone Microsystems
 370 James Street              Pho= ne:  203.786.5536 ext. 118
 New Haven, CT 06513-3051      Email:  scott.coulter@cyclone.= com
 U.S.A.                  = ;      Web:    http://www.cyclone.com
___________________________________________________________________

_______________________________________________



--
-----------= -------
Sylvain JOYEAU
Freelance Engineer
Software RT-OS R&Dsylvain.joy= eau@gmail.com
T=E9l: +33-(0)667 477 052
"A good idea is one side of the coin. The= other side is the practical usefulness". J. Liedke.
--0015174c0f86bc79570463484c73--