From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ABEFC433E0 for ; Fri, 5 Mar 2021 08:54:52 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B069764FD4 for ; Fri, 5 Mar 2021 08:54:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B069764FD4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4DsM4V140jz3dHG for ; Fri, 5 Mar 2021 19:54:50 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@csgroup.eu; receiver=) Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DsM470nLYz30Ml for ; Fri, 5 Mar 2021 19:54:29 +1100 (AEDT) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4DsM406713z9twsP; Fri, 5 Mar 2021 09:54:24 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id T8CJAndR9POI; Fri, 5 Mar 2021 09:54:24 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4DsM405JP6z9twsN; Fri, 5 Mar 2021 09:54:24 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id B77808B78B; Fri, 5 Mar 2021 09:54:25 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id ODY3hqu1EVFa; Fri, 5 Mar 2021 09:54:25 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 4D8ED8B818; Fri, 5 Mar 2021 09:54:25 +0100 (CET) Subject: Re: [PATCH v5 05/22] powerpc/irq: Add helper to set regs->softe To: Nicholas Piggin , Benjamin Herrenschmidt , Michael Ellerman , msuchanek@suse.de, Paul Mackerras References: <5f37d1177a751fdbca79df461d283850ca3a34a2.1612796617.git.christophe.leroy@csgroup.eu> <1612832745.vhjk6358hf.astroid@bobo.none> <5987787e-ee80-ed0e-0c34-9884f6aad3c5@csgroup.eu> <1612856863.0x6ebz3hce.astroid@bobo.none> From: Christophe Leroy Message-ID: Date: Fri, 5 Mar 2021 09:54:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1612856863.0x6ebz3hce.astroid@bobo.none> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 09/02/2021 à 08:49, Nicholas Piggin a écrit : > Excerpts from Christophe Leroy's message of February 9, 2021 4:18 pm: >> >> >> Le 09/02/2021 à 02:11, Nicholas Piggin a écrit : >>> Excerpts from Christophe Leroy's message of February 9, 2021 1:10 am: >>>> regs->softe doesn't exist on PPC32. >>>> >>>> Add irq_soft_mask_regs_set_state() helper to set regs->softe. >>>> This helper will void on PPC32. >>>> >>>> Signed-off-by: Christophe Leroy >>>> --- >>> >>> You could do the same with the kuap_ functions to change some ifdefs >>> to IS_ENABLED. >>> >>> That's just my preference but if you prefer this way I guess that's >>> okay. >>> >> >> >> That's also my preference on the long term. >> >> Here it is ephemeral, I have a follow up series implementing interrupt exit/entry in C and getting >> rid of all the assembly kuap hence getting rid of those ifdefs. > > I thought it might have been because you hate ifdef more tha most :) > >> The issue I see when using IS_ENABLED() is that you have to indent to the right, then you interfere >> with the file history and 'git blame' > > Valid point if it's just going to indent back the other way in your next > series. > >> Thanks for reviewing my series and looking forward to your feedback on my series on the interrupt >> entry/exit that I will likely release later today. > > Cool, I'm eager to see them. > Hi Nick, have you been able to look at it ? https://patchwork.ozlabs.org/project/linuxppc-dev/cover/cover.1612864003.git.christophe.leroy@csgroup.eu/ Thanks Christophe