From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F84DC4338F for ; Thu, 12 Aug 2021 15:42:25 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AB4760F91 for ; Thu, 12 Aug 2021 15:42:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5AB4760F91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GlrXt0spbz3cP2 for ; Fri, 13 Aug 2021 01:42:22 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=G6RCX9QE; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=G6RCX9QE; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=pbonzini@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=G6RCX9QE; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=G6RCX9QE; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GlrWz5r3Vz30B9 for ; Fri, 13 Aug 2021 01:41:33 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628782888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wVAySSNkRIQjjk+QH2YkijF+uGWoxw5I4DLvZClTw1U=; b=G6RCX9QEnL4Zf8vfwUjHYbM4kSdslBkMX3aCmO5/Z4t57VUaBHV/d+HZBrzfwIwfMk3v2y j5i6sC7AOSXC5dxJ98EYEw0iIv2YlE4RpLDnEGL9uFjlG9+gvrXaZu/8AfqGT+whsAmtAZ ppQGXoMzB1k8VCpKK+0jHf9iPLFCa2Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628782888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wVAySSNkRIQjjk+QH2YkijF+uGWoxw5I4DLvZClTw1U=; b=G6RCX9QEnL4Zf8vfwUjHYbM4kSdslBkMX3aCmO5/Z4t57VUaBHV/d+HZBrzfwIwfMk3v2y j5i6sC7AOSXC5dxJ98EYEw0iIv2YlE4RpLDnEGL9uFjlG9+gvrXaZu/8AfqGT+whsAmtAZ ppQGXoMzB1k8VCpKK+0jHf9iPLFCa2Y= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-514-m7OHyrC9Py2npyqhBt1cDg-1; Thu, 12 Aug 2021 11:41:26 -0400 X-MC-Unique: m7OHyrC9Py2npyqhBt1cDg-1 Received: by mail-ed1-f70.google.com with SMTP id e3-20020a50ec830000b02903be5be2fc73so3204957edr.16 for ; Thu, 12 Aug 2021 08:41:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wVAySSNkRIQjjk+QH2YkijF+uGWoxw5I4DLvZClTw1U=; b=IEpF8WS7MSx7PG/1fVGWx43OJOmuVCPxf8xq28G56U2p30yoebiH7vM55cWN3GyypB I3nczs4O8pDo82iAOjnPs6c/5JXYo1ynSsqnrn3m/GlEqjyXFW7vGnETj5V3Y70Xjc0Z u8P5F+DYH1jAislHyb/ZkhukNjMRHH4LlQUF63+lCzHmI1x4iBFvaeJbRbw3Hrs6QZ00 2WRbSMFZhlJKSkmhgk9eBVJtEPRTdMPvu14yJCHUysj7Yv0v2bv+XEN/x0MEt+bFGP+i DYfjrhWsqHFQNo+tDiJMPHpken4ONUwseejkAdZd/52g4njTN2a8XY7HJKg6fI1GBQoO yZWQ== X-Gm-Message-State: AOAM532stzfT0dpqnuCLaiWL2YOO5x71C098xvCvIFRbMhMaDusb2u32 iBdO71DJnClOB7be91sOKKwBtlSpMMRimAHIOWitp+AROAD49b1EyUZAKh+nOE6100AHRF+1lJh mfai9C6tIbHLDDfcglZS+TFyr8g== X-Received: by 2002:a50:ef11:: with SMTP id m17mr6095944eds.233.1628782885251; Thu, 12 Aug 2021 08:41:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbkauFimraFjcUcxW/s5naeDzEHblJnwTGW5kN8SFMxVNVXXtWI2AkXQ1TgeG7maJbDTkRTw== X-Received: by 2002:a50:ef11:: with SMTP id m17mr6095860eds.233.1628782884809; Thu, 12 Aug 2021 08:41:24 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id s18sm988134ejh.12.2021.08.12.08.41.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Aug 2021 08:41:24 -0700 (PDT) Subject: Re: [PATCH v2 1/2] KVM: Refactor kvm_arch_vcpu_fault() to return a struct page pointer To: David Hildenbrand , Hou Wenlong , kvm@vger.kernel.org References: <1c510b24fc1d7cbae8aa4b69c0799ebd32e65b82.1628739116.git.houwenlong93@linux.alibaba.com> <98adbd3c-ec6f-5689-1686-2a8a7909951a@redhat.com> From: Paolo Bonzini Message-ID: Date: Thu, 12 Aug 2021 17:41:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <98adbd3c-ec6f-5689-1686-2a8a7909951a@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, Wanpeng Li , linux-mips@vger.kernel.org, "H. Peter Anvin" , Claudio Imbrenda , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org, Janosch Frank , Marc Zyngier , Joerg Roedel , Huacai Chen , Christian Borntraeger , Aleksandar Markovic , Ingo Molnar , Catalin Marinas , Vasily Gorbik , Suzuki K Poulose , Heiko Carstens , kvm-ppc@vger.kernel.org, Borislav Petkov , Thomas Gleixner , Alexandru Elisei , linux-arm-kernel@lists.infradead.org, Jim Mattson , Thomas Bogendoerfer , Sean Christopherson , Cornelia Huck , linux-kernel@vger.kernel.org, James Morse , Vitaly Kuznetsov , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 12/08/21 11:04, David Hildenbrand wrote: > > Reviewed-by: David Hildenbrand > > But at the same time I wonder if we should just get rid of > CONFIG_KVM_S390_UCONTROL and consequently kvm_arch_vcpu_fault(). > > In practice CONFIG_KVM_S390_UCONTROL, is never enabled in any reasonable > kernel build and consequently it's never tested; further, exposing the > sie_block to user space allows user space to generate random SIE > validity intercepts. > > CONFIG_KVM_S390_UCONTROL feels like something that should just be > maintained out of tree by someone who really needs to hack deep into hw > virtualization for testing purposes etc. I have no preference either way. It should definitely have selftests, but in x86 land there are some features that are not covered by QEMU and were nevertheless accepted upstream with selftests. Paolo