Re: [PATCH] ocxl: Fix misleading comment

[Frederic Barrat <fbarrat@linux.ibm.com>]

Le 26/02/2020 à 05:39, Andrew Donnellan a écrit :
> In ocxl_context_free() we note that the AFU reference we're releasing was
> taken in "ocxl_context_init", a function that doesn't actually exist.
> 
> Fix it to say ocxl_context_alloc() instead, which I expect was what was
> intended.
> 
> Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices")
> Cc: Frederic Barrat <fbarrat@linux.ibm.com>
> Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
> ---



ocxl_context_init() used to exist. It was renamed to 
ocxl_context_alloc() for good reasons as part of later work. So it 
should really be:
Fixes: b9721d275cc2 ("ocxl: Allow external drivers to use OpenCAPI 
contexts")

Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>


>   drivers/misc/ocxl/context.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/ocxl/context.c b/drivers/misc/ocxl/context.c
> index de8a66b9d76b..c21f65a5c762 100644
> --- a/drivers/misc/ocxl/context.c
> +++ b/drivers/misc/ocxl/context.c
> @@ -287,7 +287,7 @@ void ocxl_context_free(struct ocxl_context *ctx)
>   
>   	ocxl_afu_irq_free_all(ctx);
>   	idr_destroy(&ctx->irq_idr);
> -	/* reference to the AFU taken in ocxl_context_init */
> +	/* reference to the AFU taken in ocxl_context_alloc() */
>   	ocxl_afu_put(ctx->afu);
>   	kfree(ctx);
>   }
>