From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qy0-f123.google.com (mail-qy0-f123.google.com [209.85.221.123]) by ozlabs.org (Postfix) with ESMTP id 2A44EDDE1B for ; Fri, 29 May 2009 06:10:57 +1000 (EST) Received: by qyk29 with SMTP id 29so1892046qyk.17 for ; Thu, 28 May 2009 13:10:56 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20090528171726.GE3112@pengutronix.de> References: <4A124202.4010201@doredevelopment.dk> <20090526213351.GG23114@fluff.org.uk> <20090528171726.GE3112@pengutronix.de> Date: Thu, 28 May 2009 22:10:56 +0200 Message-ID: Subject: Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg From: Esben Haabendal To: Wolfram Sang Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev@ozlabs.org, Esben Haabendal , linux-i2c@vger.kernel.org, Ben Dooks List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, May 28, 2009 at 7:17 PM, Wolfram Sang wrote: >> > Any blockers to get this accepted? >> >> It would be nice to get an ack from someone who can actually test >> the driver before getting this merged. > > I wanted to test it, but it does not apply due to line breaks (check > @@-line). Also, I don't really have the time to dig into the topic, so I > would only test it and give a tested-by-tag if it doesn't break anything > here. I think Joakim would be a good candidate for an acked-by . I've checked both my copy in my "Sent" folder and the copy received from the list, and I cannot see any "line break" breakage of the patch. It must be your mail client that is messing with it, so I cannot really do it much better in that way. If necessary, I can push a branch to a public repo you can pull from. /Esben