From: Tirumala Marri <tmarri@apm.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: neilb@suse.de, yur@emcraft.com, linux-raid@vger.kernel.org,
herbert@gondor.hengli.com.au, linux-crypto@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: RE: [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c
Date: Thu, 23 Sep 2010 15:39:47 -0700 [thread overview]
Message-ID: <d2d7c3068b5582bde7529ccc65d71e52@mail.gmail.com> (raw)
In-Reply-To: <4C9BB6EB.7020802@intel.com>
>
> Will both versions of this driver exist in the same kernel build? For
> example the iop-adma driver supports iop13xx and iop3xx, but we select
> the archtitecture at build time? Or, as I assume in this case, will
> the
> two (maybe more?) ppc4xx adma drivers all be built in the same image,
> more like ioatdma?
[Marri] We select the architecture at build time.
>
> In the latter case I would recommend a file structure like:
>
> drivers/dma/ppc4xx/adma.c
> drivers/dma/ppc4xx/adma_440spe.c
> drivers/dma/ppc4xx/adma_460ex.c
>
> With patches to move the chipset specific pieces to their own file.
> Minimizing the code churn in adma.c, or at least showing a progression
> of what is unique and needs to be moved.
>
> This would be similar to how ioatdma is structured and compiles a
> single
> driver to cover the three major hardware revisions.
[Marri]Looks like this driver is similar to iop-adma driver.
next prev parent reply other threads:[~2010-09-23 22:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-18 1:42 [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c tmarri
2010-09-18 21:09 ` Wolfgang Denk
2010-09-20 18:00 ` Tirumala Marri
2010-09-20 21:31 ` Wolfgang Denk
2010-09-19 20:00 ` Ilya Yanok
2010-09-21 16:51 ` Tirumala Marri
2010-09-23 20:22 ` Dan Williams
2010-09-23 22:39 ` Tirumala Marri [this message]
2010-09-24 6:58 ` Stefan Roese
2010-09-24 18:52 ` Tirumala Marri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2d7c3068b5582bde7529ccc65d71e52@mail.gmail.com \
--to=tmarri@apm.com \
--cc=dan.j.williams@intel.com \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=neilb@suse.de \
--cc=yur@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).