linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: Don't use HOSTCFLAGS in BOOTCFLAGS
Date: Tue, 29 May 2007 07:12:21 +0200	[thread overview]
Message-ID: <d35e07648ef5813bd9e3572eec36bfb3@kernel.crashing.org> (raw)
In-Reply-To: <20070529032924.GA30266@localhost.localdomain>

>  #	To this end we need to define BOOTCC, etc, as the tools
> -#	needed to build the 32 bit image.  These are normally HOSTCC,
> +#	needed to build the 32 bit image.
>  #	but may be a third compiler if, for example, you are cross

You've broken this comment, you should pay for it now :-)

> -HOSTCC		:= gcc
> -BOOTCFLAGS	:= $(HOSTCFLAGS) -fno-builtin -fno-unit-at-a-time 
> -nostdinc -isystem \
> -		   $(shell $(CROSS32CC) -print-file-name=include) -fPIC
> +BOOTCFLAGS	:= -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
> +		   -fno-strict-aliasing -O2 -msoft-float -pipe \

-Os instead?

> +		   -fomit-frame-pointer -fno-builtin -fno-unit-at-a-time \

Why -fno-unit-at-a-time ?

> +		   -fPIC -nostdinc \
> +		   -isystem $(shell $(CROSS32CC) -print-file-name=include)

Also, is there any reason why you can't simply use $(CC) -m32 with
the kernel $(CFLAGS) ?


Segher

  reply	other threads:[~2007-05-29  5:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-29  3:29 Don't use HOSTCFLAGS in BOOTCFLAGS David Gibson
2007-05-29  5:12 ` Segher Boessenkool [this message]
2007-05-29  5:34   ` David Gibson
2007-05-29  6:26     ` Segher Boessenkool
2007-05-29  6:33       ` David Gibson
  -- strict thread matches above, loose matches on Subject: below --
2007-05-29  5:37 David Gibson
2007-05-29 14:21 ` Josh Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d35e07648ef5813bd9e3572eec36bfb3@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).