linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH 12/13] powerpc: Add bootwrapper support for Motorola PrPMC2800 platform
@ 2007-04-30 16:15 Milton Miller
  2007-04-30 18:19 ` Mark A. Greer
  0 siblings, 1 reply; 8+ messages in thread
From: Milton Miller @ 2007-04-30 16:15 UTC (permalink / raw)
  To: Mark A. Greer; +Cc: ppcdev, Paul Mackerras

On Thu Apr 26 10:02:27 EST 2007, Mark A. Greer wrote:
> Add support for Motorola ECC PrPMC280/PrPMC2800 Platform.
> The PrPMC280 sits on an F101 baseboard and the PrPMC2800 sits on a
> F101e baseboard.  Logic has been added to determine which board
> (and variant thereof) the code is being run on.

>
> +       /* Update /mv64x60/device_type, if this is a mv64362 */
> +       if (bip->bridge_type == BRIDGE_TYPE_MV64362) {
> +               devp = finddevice("/mv64x60");
> +               if (devp == NULL)
> +                       fatal("Error: Missing /mv64x60 device tree 
> node\n\r");
> +               setprop(devp, "device_type", "mv64362", 
> strlen("mv64362") + 1);
> +       }
> +

That is not a device_type.   It might be a model,   Or even a 
compatable.
but not a type.

> +       platform_ops.exit = prpmc2800_reset;

No delay to let the user know see what is wrong?

> +
> +/* Following code is put at very beginning of zImage (64KB into ELF 
> file) */
> +asm (" .globl _zimage_start\n\
> +       _zimage_start:\n\
> +               mfmsr   10\n\
> +               rlwinm  10,10,0,~(1<<15)        /* Clear MSR_EE */\n\
> +               sync\n\
> +               mtmsr   10\n\
> +               isync\n\
> +               b _zimage_start_lib\n\
> +");
>

That comment is very wrong.   This object might be the first to be 
linked,
and the text will be near the top.  But there is nothing in that 
fragment
to make it be the beginning of the image.  Not even in the text section.

That label will be the entrypoiint, so make the comment to that effect.

Also, the 1<<15 seems magic.  I would like to see it as a constant in
reg.h, but to use that you would have to pass it as an i parameter, so
I'm not sure it would improve.

milton

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH 0/13] powerpc: Add support for Marvell/mv64x60 and prpmc2800
@ 2007-05-12  0:46 Mark A. Greer
  2007-05-12  0:58 ` [PATCH 12/13] powerpc: Add bootwrapper support for Motorola PrPMC2800 platform Mark A. Greer
  0 siblings, 1 reply; 8+ messages in thread
From: Mark A. Greer @ 2007-05-12  0:46 UTC (permalink / raw)
  To: Paul Mackerras; +Cc: linuxppc-dev


Latest respin of these patches.  Should address all comments except David's
comment about the '$(obj)/zImage.dts:' rules.  I will address those next
week but if I get this out now, it may get in to 2.6.22. :)

Thanks,

Mark

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH 0/13] powerpc: Add support for Marvell/mv64x60 and prpmc2800
@ 2007-05-10 20:02 Mark A. Greer
  2007-05-10 20:09 ` [PATCH 12/13] powerpc: Add bootwrapper support for Motorola PrPMC2800 platform Mark A. Greer
  0 siblings, 1 reply; 8+ messages in thread
From: Mark A. Greer @ 2007-05-10 20:02 UTC (permalink / raw)
  To: Paul Mackerras; +Cc: linuxppc-dev

This is the latest and hopefully last round of patches for adding mv64x60
and prpmc2800 support to arch/powerpc.  It would be great if this could
still get into 2.6.22.

Thanks,

Mark

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH 0/13] powerpc: Add support for Marvell/mv64x60 and prpmc2800
@ 2007-04-25 23:46 Mark A. Greer
  2007-04-26  0:02 ` [PATCH 12/13] powerpc: Add bootwrapper support for Motorola PrPMC2800 platform Mark A. Greer
  0 siblings, 1 reply; 8+ messages in thread
From: Mark A. Greer @ 2007-04-25 23:46 UTC (permalink / raw)
  To: Paul Mackerras; +Cc: linuxppc-dev

The following set of patches add support for the Motorola prpmc2800/f101e platform.
To support that platform, several other patches are required that can be grouped as
follows:

	- 1 patch to add Makefile rules that automatically compile & wrap a dts into
	  a zImage
	- 1 patch to add a new interface to the dt_xlate code.
	- 3 mv64x60 bootwrapper patches
	- 5 mv64x60 kernel patches
	- 3 prpmc2800 patches

Mark

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2007-05-12  0:58 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-30 16:15 [PATCH 12/13] powerpc: Add bootwrapper support for Motorola PrPMC2800 platform Milton Miller
2007-04-30 18:19 ` Mark A. Greer
2007-05-01  4:10   ` Milton Miller
2007-05-07 18:23     ` Mark A. Greer
2007-05-01 17:06   ` Milton Miller
  -- strict thread matches above, loose matches on Subject: below --
2007-05-12  0:46 [PATCH 0/13] powerpc: Add support for Marvell/mv64x60 and prpmc2800 Mark A. Greer
2007-05-12  0:58 ` [PATCH 12/13] powerpc: Add bootwrapper support for Motorola PrPMC2800 platform Mark A. Greer
2007-05-10 20:02 [PATCH 0/13] powerpc: Add support for Marvell/mv64x60 and prpmc2800 Mark A. Greer
2007-05-10 20:09 ` [PATCH 12/13] powerpc: Add bootwrapper support for Motorola PrPMC2800 platform Mark A. Greer
2007-04-25 23:46 [PATCH 0/13] powerpc: Add support for Marvell/mv64x60 and prpmc2800 Mark A. Greer
2007-04-26  0:02 ` [PATCH 12/13] powerpc: Add bootwrapper support for Motorola PrPMC2800 platform Mark A. Greer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).