From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E419DC43381 for ; Fri, 15 Mar 2019 09:39:24 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4138121872 for ; Fri, 15 Mar 2019 09:39:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4138121872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=metux.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44LLBf0bQpzDqRr for ; Fri, 15 Mar 2019 20:39:22 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=metux.net (client-ip=212.227.17.24; helo=mout.kundenserver.de; envelope-from=lkml@metux.net; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=metux.net X-Greylist: delayed 1512 seconds by postgrey-1.36 at bilbo; Fri, 15 Mar 2019 20:37:48 AEDT Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44LL8r51DFzDqRm for ; Fri, 15 Mar 2019 20:37:47 +1100 (AEDT) Received: from [192.168.1.110] ([77.2.38.11]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N4Q8u-1gwW680DNW-011QXn; Fri, 15 Mar 2019 10:37:14 +0100 Subject: Re: [PATCH v2 02/45] drivers: tty: serial: 8250_dw: use devm_ioremap_resource() To: Andy Shevchenko , "Enrico Weigelt, metux IT consult" References: <1552602855-26086-1-git-send-email-info@metux.net> <1552602855-26086-3-git-send-email-info@metux.net> From: "Enrico Weigelt, metux IT consult" Organization: metux IT consult Message-ID: Date: Fri, 15 Mar 2019 10:37:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:LMbGrgS1Fw3sbm3BX4m+19HQ5xTGusRRe0UWXpP0ztIQVQgQrlc m53H4MQDK/RM1nKPWCag0ezzxjT0wbjDa/N87KZImrFRriiJckuCAztY6IZagfpoEJntLOq nR2WhNIHqdTuNxUilfS9+Zd8kAWSBCOmM7u7UouBs0uNFHrI07s+K5WRHezpTZz+6g55hnn 5awtt6qM+v1ChFGU/1Qzw== X-UI-Out-Filterresults: notjunk:1;V03:K0:9yl8hjgmV4o=:qa/ooxfQuXBNMJTkd2wlcR Jw/fZubKj2Que3t0FPCECdniDQk2yOI5tSLsLYxL0OlYOMJBp8cthnB21miHDJVVndcoxTtEB 0qot9dVVlpVC9Oi965cbNDllBml8Hufy2WCwPaCEmDReH3IxuA7SLW8gIKc/M+c4mn7Sk42bR HNFhlmkISgobr3RuMwUKF6TWzaUzz/eK73n2Py/5S425fJyWSL0RpIXZlrY31V+GCCuX6bGjk KBFwZZ3Gahd4D4J0DhXrqdZ2TPU79oFdS1YEt70M382z/fAF+LS+owfknLuQUWBixQHTD4+xw bv7KzuY+SH9gmERV2Cc7ShXyDzjoF9uYnXLrngClY1ECj06unYyGAQuqIUAJ2AE78V93W8d0c baqT7D0/aNb8JibxCHlEjxM9tnXUuLSCq11fveazwuMJSWlBs7KEQvp+AZgajDXHWVaK63tV9 QDWQE9bI3VSBA0P1mxONwdL6ClTKbU50XdEYW/p+/y3O0AzR0De6G7DHnQdMZTVLNIteupKXm 4vvwOaFIXDhDbCqHXWU257N3CsAXaVLqXSCwBImubVFSN89Y6o+An/xAo8hmouhMMdsJZwl6K Zknww/47T5BMDfduJqxseSz/+nLikMzgHDC5rvywnEQSMlhsh5nk2vQ4zYQmUlfIjigXmPhkn sthMjOrxzn2RcnHJf3/W9Jk/ah/KlUGIzPFgAsL8wcG7Qr/ypb5/vt7B0Yh7Y14dbqpuCbUvi mLOvAw6A3AFkBatEoo70z5+f1ApgzAV10DNl9pjAdv97E2b5i9d07N8aEpE= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, Masahiro Yamada , macro@linux-mips.org, Peter Korsgaard , Fabio Estevam , Stefan Wahren , Florian Fainelli , bcm-kernel-feedback-list , dl-linux-imx , "open list:SERIAL DRIVERS" , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Andy Gross , Tobias Klauser , David Brown , Ray Jui , Sascha Hauer , slemieux.tyco@gmail.com, "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" , Vladimir Zapolskiy , Matthias Brugger , Andy Shevchenko , baohua@kernel.org, Scott Branden , Eric Anholt , Richard Genoud , Greg Kroah-Hartman , Linux Kernel Mailing List , Sascha Hauer , Shawn Guo Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 15.03.19 10:04, Andy Shevchenko wrote: > On Fri, Mar 15, 2019 at 12:41 AM Enrico Weigelt, metux IT consult > wrote: >> >> Instead of fetching out data from a struct resource for passing >> it to devm_ioremap(), directly use devm_ioremap_resource() > > I don't see any advantage of this change. > See also below. I see that the whole story wasn't clear. Please see my reply to Greg, hope that clears it up a little bit. >> --- a/drivers/tty/serial/8250/8250_dw.c >> +++ b/drivers/tty/serial/8250/8250_dw.c >> @@ -526,7 +526,7 @@ static int dw8250_probe(struct platform_device *pdev) >> p->set_ldisc = dw8250_set_ldisc; >> p->set_termios = dw8250_set_termios; >> >> - p->membase = devm_ioremap(dev, regs->start, resource_size(regs)); >> + p->membase = devm_ioremap_resource(dev, regs); >> if (!p->membase) > > And how did you test this? devm_ioremap_resource() returns error > pointer in case of error. hmm, devm_ioremap_resource() does so, but devm_ioremap() does not ? I really didn't expect that. Thanks for pointing that out. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287