From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40LHzq5WWxzF2SP for ; Wed, 11 Apr 2018 05:58:47 +1000 (AEST) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3AJwebw034496 for ; Tue, 10 Apr 2018 15:58:45 -0400 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0a-001b2d01.pphosted.com with ESMTP id 2h90ffhsua-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Tue, 10 Apr 2018 15:58:44 -0400 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 10 Apr 2018 15:58:43 -0400 Subject: Re: [PATCH, RESEND, pci, v2] pci: Delete PCI disabling informational messages To: Bjorn Helgaas Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, bhelgaas@google.com References: <20180404151035.12140-1-desnesn@linux.vnet.ibm.com> <20180410193631.GC54986@bhelgaas-glaptop.roam.corp.google.com> <20180410195556.GF54986@bhelgaas-glaptop.roam.corp.google.com> From: "Desnes A. Nunes do Rosario" Date: Tue, 10 Apr 2018 16:58:38 -0300 MIME-Version: 1.0 In-Reply-To: <20180410195556.GF54986@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=utf-8; format=flowed Message-Id: List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Bjorn, On 04/10/2018 04:55 PM, Bjorn Helgaas wrote: > On Tue, Apr 10, 2018 at 02:36:31PM -0500, Bjorn Helgaas wrote: >> On Wed, Apr 04, 2018 at 12:10:35PM -0300, Desnes A. Nunes do Rosario wrote: >>> The disabling informational messages on the PCI subsystem should be deleted >>> since they do not represent any real value for the system logs. >>> >>> These messages are either not presented, or presented for all PCI devices >>> (e.g., powerpc now realigns all PCI devices to its page size). Thus, they >>> are flooding system logs and can be interpreted as a false positive for >>> total PCI failure on the system. >>> >>> [root@system user]# dmesg | grep -i disabling >>> [ 0.692270] pci 0000:00:00.0: Disabling memory decoding and releasing memory resources >>> [ 0.692324] pci 0000:00:00.0: disabling bridge mem windows >>> [ 0.729134] pci 0001:00:00.0: Disabling memory decoding and releasing memory resources >>> [ 0.737352] pci 0001:00:00.0: disabling bridge mem windows >>> [ 0.776295] pci 0002:00:00.0: Disabling memory decoding and releasing memory resources >>> [ 0.784509] pci 0002:00:00.0: disabling bridge mem windows >>> ... and goes on for all PCI devices on the system ... >>> >>> Fixes: 38274637699 ("powerpc/powernv: Override pcibios_default_alignment() to force PCI devices to be page aligned") >>> Signed-off-by: Desnes A. Nunes do Rosario >> >> Applied to pci/resource for v4.18, thanks! >> >> I should have gotten this in for v4.17, but I didn't; sorry about that. > > This is trivial and I'm planning to squeeze a few more things into v4.17, > so I moved this to my "for-linus" branch for v4.17. No need for apologies. On the contrary, thank you very much for your review and branch change. > >>> --- >>> drivers/pci/pci.c | 1 - >>> drivers/pci/setup-res.c | 2 -- >>> 2 files changed, 3 deletions(-) >>> >>> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c >>> index 8c71d1a66cdd..1563ce1ee091 100644 >>> --- a/drivers/pci/pci.c >>> +++ b/drivers/pci/pci.c >>> @@ -5505,7 +5505,6 @@ void pci_reassigndev_resource_alignment(struct pci_dev *dev) >>> return; >>> } >>> >>> - pci_info(dev, "Disabling memory decoding and releasing memory resources\n"); >>> pci_read_config_word(dev, PCI_COMMAND, &command); >>> command &= ~PCI_COMMAND_MEMORY; >>> pci_write_config_word(dev, PCI_COMMAND, command); >>> diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c >>> index 369d48d6c6f1..6bd35e8e7cde 100644 >>> --- a/drivers/pci/setup-res.c >>> +++ b/drivers/pci/setup-res.c >>> @@ -172,8 +172,6 @@ EXPORT_SYMBOL(pci_claim_resource); >>> >>> void pci_disable_bridge_window(struct pci_dev *dev) >>> { >>> - pci_info(dev, "disabling bridge mem windows\n"); >>> - >>> /* MMIO Base/Limit */ >>> pci_write_config_dword(dev, PCI_MEMORY_BASE, 0x0000fff0); >>> >>> -- >>> 2.14.3 >>> > -- Desnes A. Nunes do Rosario -------------------------- Linux Developer - IBM