From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 404FCC001E0 for ; Tue, 15 Aug 2023 00:58:06 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=VlU2P5f9; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RPtDD5Jvqz2yTN for ; Tue, 15 Aug 2023 10:58:04 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=VlU2P5f9; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.20; helo=mgamail.intel.com; envelope-from=baolu.lu@linux.intel.com; receiver=lists.ozlabs.org) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RPtCC1hYxz2xpv for ; Tue, 15 Aug 2023 10:57:08 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692061031; x=1723597031; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=EMtekiFoo0Tblby6wZQ8ziVNSJFBHzBXovBoPNar8KU=; b=VlU2P5f9L85KyrhzQ3En9OVMKyjleXTBWUwLBjvH+S8+MGhHHH+TVXCJ s5u1429hqYUWZ9Msm28Co0SZOHnhUHk3Jw5vzcQyRDNvodnBZjZKwdpGV SWs2O3sFJWUP9ccxkdXHdW9J0Po13gJ6rVAx24Dmd1cw1o6tgEd3upb/j qIbx7cicmCmNW6w7wq0pDOK1E/dGWaWimr2ve0g8feJZwZqKJSBmkKlwl 4m3w/IXSfoPYiTCTw/IaNDES0whL/SFvPRH5Bh6om4quBzUmk3pnWQr2m HR7dU3QBaJlL10b3yv1Ev7L57gmA115AlUlVn1VZSHYNtxD6VfKvJ6cym A==; X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="362322796" X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; d="scan'208";a="362322796" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 17:56:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="857243905" X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; d="scan'208";a="857243905" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.254.215.149]) ([10.254.215.149]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 17:56:42 -0700 Message-ID: Date: Tue, 15 Aug 2023 08:56:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v6 17/25] iommu/qcom_iommu: Add an IOMMU_IDENTITIY_DOMAIN Content-Language: en-US To: Jason Gunthorpe References: <17-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com> <8cef9a0d-15ba-f8af-7e22-d4d3063c97bf@linux.intel.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Matthew Rosato , Matthias Brugger , Thierry Reding , Jernej Skrabec , Alim Akhtar , Dmitry Osipenko , Steven Price , Will Deacon , Marek Szyprowski , linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Samuel Holland , Joerg Roedel , Russell King , Jonathan Hunter , linux-rockchip@lists.infradead.org, iommu@lists.linux.dev, Andy Gross , Nicolin Chen , Yong Wu , Orson Zhai , Gerald Schaefer , Thierry Reding , linux-sunxi@lists.linux.dev, Rob Clark , Kevin Tian , Niklas Schnelle , linux-arm-msm@vger.kernel.org, Nicholas Piggin , Krishna Reddy , linux-mediatek@lists.infradead.org, Baolin Wang , linux-tegra@vger.kernel.org, Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Robin Murphy , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Chunyan Zhang , linuxppc-dev@lists.ozlabs.org, baolu.lu@linux.intel.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 2023/8/14 23:36, Jason Gunthorpe wrote: > On Mon, Aug 14, 2023 at 02:32:33PM +0800, Baolu Lu wrote: > >>> + pm_runtime_get_sync(qcom_iommu->dev); >>> + for (i = 0; i < fwspec->num_ids; i++) { >>> + struct qcom_iommu_ctx *ctx = to_ctx(qcom_domain, fwspec->ids[i]); >>> + >>> + /* Disable the context bank: */ >>> + iommu_writel(ctx, ARM_SMMU_CB_SCTLR, 0); >>> + >>> + ctx->domain = NULL; >> Does setting ctx->domain to NULL still match this semantics? > Yes, I did not try to fix this driver. NULL means identity in the > ctx->domain. Okay. Best regards, baolu