linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: paulus@samba.org, henrik.sorensen@gmail.com,
	Stephane Marchesin <marchesin@icps.u-strasbg.fr>,
	linuxppc-dev@ozlabs.org
Subject: Re: V4L2: __ucmpdi2 undefined on ppc
Date: Tue, 4 Mar 2008 21:32:50 +0100	[thread overview]
Message-ID: <d65fa0ae5361ca507c0988d8a7f1d009@kernel.crashing.org> (raw)
In-Reply-To: <1204648648.3891.439.camel@pmac.infradead.org>

>> Every occurrence of r7 here is wrong (and some of the r6).
>
> Can you elucidate?

Sure!  It should read either "7" or "cr7".

>>   Is there any reason to do this in assembler code at all?
>
> Is there any particular reason not to?

1) If written in assembler, it needs to be written for every 
architecture
separately, and sometimes even for every architecture variant (32 vs. 64
bit is only the tip of the iceberg).

2) As shown here as well as in the recent strncmp() patch, it is a lot 
harder
to write correct assembler code than it is to write correct C code(*), 
and
the C code isn't less efficient either.


Segher

(*) Well, the generic C strncmp() code in the kernel is broken too, bad
example perhaps :-)

  parent reply	other threads:[~2008-03-04 20:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.SOC.4.61.0612131359430.10721@math.ut.ee>
     [not found] ` <1166053317.909.19.camel@praia>
     [not found]   ` <20061214195842.GA14041@athena.road.mcmartin.ca>
2006-12-17 13:29     ` V4L2: __ucmpdi2 undefined on ppc David Woodhouse
2008-02-06 14:39       ` Stephane Marchesin
2008-03-02 18:48         ` Stephane Marchesin
2008-03-02 21:53         ` Segher Boessenkool
2008-03-04 16:37           ` David Woodhouse
2008-03-04 16:58             ` Scott Wood
2008-03-04 20:32             ` Segher Boessenkool [this message]
2008-03-04 21:44           ` Paul Mackerras
2008-03-04 21:47             ` Scott Wood
2008-03-04 22:43             ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d65fa0ae5361ca507c0988d8a7f1d009@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=dwmw2@infradead.org \
    --cc=henrik.sorensen@gmail.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=marchesin@icps.u-strasbg.fr \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).