From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BE8EC43613 for ; Fri, 21 Jun 2019 05:20:25 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBD352084E for ; Fri, 21 Jun 2019 05:20:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=fossix-org.20150623.gappssmtp.com header.i=@fossix-org.20150623.gappssmtp.com header.b="RFeXWbc7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBD352084E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fossix.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45VRpZ72kGzDqcv for ; Fri, 21 Jun 2019 15:20:22 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=fossix.org (client-ip=2607:f8b0:4864:20::543; helo=mail-pg1-x543.google.com; envelope-from=santosh@fossix.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=fossix.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=fossix-org.20150623.gappssmtp.com header.i=@fossix-org.20150623.gappssmtp.com header.b="RFeXWbc7"; dkim-atps=neutral Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45VRHD0GmpzDqR1 for ; Fri, 21 Jun 2019 14:56:40 +1000 (AEST) Received: by mail-pg1-x543.google.com with SMTP id w10so2730884pgj.7 for ; Thu, 20 Jun 2019 21:56:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fossix-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zg9/MCsEmO5YxM49HNSLCK5IX7UZFuSStDBR38tGins=; b=RFeXWbc72re6CTiFZ/W5PvY2Wd26pgFB97LE0kDoLo/Huk5PHtBO7wslBHPTudVRFp Gol2y8r7ktjplohQJE6IU4OkPx3YjnyLIoyFFuFxbS1Fg2ZPSYghvQI5HyCB9MJoxCnh h4V+o96bbY8oPgWxVcffqbg0n+sEbGpuT+XFSiPNhDiibY0o6uWHW2FjMxQN+31ygyhG LwAgy/THKcOOMv46EFULlBmS3zGvb1aBUW3Ro6iVoVnRfWAOK5VB8KLIl52E0/yGhwam AsqmcbQCBg9Avmw/GDO2rm6GnkEnNHMW2enxzVH17DL8EzFwsQpYNhEKbHkBe8QQK1E5 Q4vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zg9/MCsEmO5YxM49HNSLCK5IX7UZFuSStDBR38tGins=; b=EZbB6jK7vWQ8AAv+i2tdXi072atAoyPlusTjflyC7lWO99Aw5PLWOWEvABgfvCgoQO 9VaTpukB8YXKqbvmq57ef//4jDccyzfowoRX/jtnRWhmK4Q7IO47kl50M3cdYtzeTuUr Jc1KzIqRFC9gCHQzgx+b9wqj5wiQ6sQgSLvGnqu7j8uNruGg4Havuz8D6vtq7+x8FJEv JR2XUT/hlALkFpk1b+7Cv05oqhsQ2pPVTINIJavbYwAjE2lLlPooI+5EqDCCnVffDqmb KpthxCS0khd/Ouykwkg+IarKF7dtI+YH+qbCWWrOdkT9qSVeiToew713Q3XpYzhOZOGP hHpQ== X-Gm-Message-State: APjAAAVUf3sFcd0W3SmGwme+PXOStEwJvIOkoRegsm8i3EUFpx5hjRJn NVdZKluPdnwLrZ6KY0y9GLsTwkwfvoqbrw== X-Google-Smtp-Source: APXvYqxSIngo5E5byxUdxxBT/Q4nMEo9dn7N4+vSP+9RBYTk1VbBaeY/PlksNrUV9zDrU2hjAvmPFw== X-Received: by 2002:a17:90a:36a9:: with SMTP id t38mr3925867pjb.19.1561092997681; Thu, 20 Jun 2019 21:56:37 -0700 (PDT) Received: from santosiv.in.ibm.com ([129.41.84.77]) by smtp.gmail.com with ESMTPSA id q131sm1392069pfq.157.2019.06.20.21.56.34 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 20 Jun 2019 21:56:37 -0700 (PDT) From: Santosh Sivaraj To: linuxppc-dev Subject: [PATCH 11/13] powerpc/64s: Save r13 in machine_check_common_early Date: Fri, 21 Jun 2019 10:25:53 +0530 Message-Id: X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Aneesh Kumar K.V" , Mahesh Salgaonkar , Nicholas Piggin , Chandan Rajendra , Reza Arbab Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Reza Arbab Testing my memcpy_mcsafe() work in progress with an injected UE, I get an error like this immediately after the function returns: BUG: Unable to handle kernel data access at 0x7fff84dec8f8 Faulting instruction address: 0xc0080000009c00b0 Oops: Kernel access of bad area, sig: 11 [#1] LE PAGE_SIZE=64K MMU=Radix MMU=Hash SMP NR_CPUS=2048 NUMA PowerNV Modules linked in: mce(O+) vmx_crypto crc32c_vpmsum CPU: 0 PID: 1375 Comm: modprobe Tainted: G O 5.1.0-rc6 #267 NIP: c0080000009c00b0 LR: c0080000009c00a8 CTR: c000000000095f90 REGS: c0000000ee197790 TRAP: 0300 Tainted: G O (5.1.0-rc6) MSR: 900000000280b033 CR: 88002826 XER: 00040000 CFAR: c000000000095f8c DAR: 00007fff84dec8f8 DSISR: 40000000 IRQMASK: 0 GPR00: 000000006c6c6568 c0000000ee197a20 c0080000009c8400 fffffffffffffff2 GPR04: c0080000009c02e0 0000000000000006 0000000000000000 c000000003c834c8 GPR08: 0080000000000000 776a6681b7fb5100 0000000000000000 c0080000009c01c8 GPR12: c000000000095f90 00007fff84debc00 000000004d071440 0000000000000000 GPR16: 0000000100000601 c0080000009e0000 c000000000c98dd8 c000000000c98d98 GPR20: c000000003bba970 c0080000009c04d0 c0080000009c0618 c0000000001e5820 GPR24: 0000000000000000 0000000000000100 0000000000000001 c000000003bba958 GPR28: c0080000009c02e8 c0080000009c0318 c0080000009c02e0 0000000000000000 NIP [c0080000009c00b0] cause_ue+0xa8/0xe8 [mce] LR [c0080000009c00a8] cause_ue+0xa0/0xe8 [mce] To fix, ensure that r13 is properly restored after an MCE. Signed-off-by: Reza Arbab --- arch/powerpc/kernel/exceptions-64s.S | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S index 311f1392a2ec..932d8d05892c 100644 --- a/arch/powerpc/kernel/exceptions-64s.S +++ b/arch/powerpc/kernel/exceptions-64s.S @@ -265,6 +265,7 @@ ALT_FTR_SECTION_END_IFSET(CPU_FTR_HVMODE) EXC_REAL_END(machine_check, 0x200, 0x100) EXC_VIRT_NONE(0x4200, 0x100) TRAMP_REAL_BEGIN(machine_check_common_early) + SET_SCRATCH0(r13) /* save r13 */ EXCEPTION_PROLOG_1(PACA_EXMC, NOTEST, 0x200) /* * Register contents: -- 2.20.1