From: baomingtong001@208suo.com
To: mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu, shuah@kernel.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org
Subject: [PATCH] selftests/powerpc: remove unneeded variable
Date: Wed, 14 Jun 2023 14:51:18 +0800 [thread overview]
Message-ID: <d71a676bc9e2af23b3a89459c7320f74@208suo.com> (raw)
In-Reply-To: <20230614064848.5648-1-luojianhong@cdjrlc.com>
fix the following coccicheck warning:
tools/testing/selftests/powerpc/alignment/alignment_handler.c:530:5-7:
Unneeded variable: "rc". Return "0".
tools/testing/selftests/powerpc/alignment/alignment_handler.c:558:5-7:
Unneeded variable: "rc". Return "0".
tools/testing/selftests/powerpc/alignment/alignment_handler.c:576:5-7:
Unneeded variable: "rc". Return "0".
tools/testing/selftests/powerpc/alignment/alignment_handler.c:591:5-7:
Unneeded variable: "rc". Return "0".
tools/testing/selftests/powerpc/alignment/alignment_handler.c:407:5-7:
Unneeded variable: "rc". Return "0".
tools/testing/selftests/powerpc/alignment/alignment_handler.c:466:5-7:
Unneeded variable: "rc". Return "0".
tools/testing/selftests/powerpc/alignment/alignment_handler.c:481:5-7:
Unneeded variable: "rc". Return "0".
tools/testing/selftests/powerpc/alignment/alignment_handler.c:502:5-7:
Unneeded variable: "rc". Return "0".
tools/testing/selftests/powerpc/alignment/alignment_handler.c:322:5-7:
Unneeded variable: "rc". Return "0".
tools/testing/selftests/powerpc/alignment/alignment_handler.c:340:5-7:
Unneeded variable: "rc". Return "0".
tools/testing/selftests/powerpc/alignment/alignment_handler.c:356:5-7:
Unneeded variable: "rc". Return "0".
tools/testing/selftests/powerpc/alignment/alignment_handler.c:388:5-7:
Unneeded variable: "rc". Return "0".
Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
---
.../powerpc/alignment/alignment_handler.c | 36 +++++++------------
1 file changed, 12 insertions(+), 24 deletions(-)
diff --git
a/tools/testing/selftests/powerpc/alignment/alignment_handler.c
b/tools/testing/selftests/powerpc/alignment/alignment_handler.c
index 33ee34fc0828..56fc26c2b75a 100644
--- a/tools/testing/selftests/powerpc/alignment/alignment_handler.c
+++ b/tools/testing/selftests/powerpc/alignment/alignment_handler.c
@@ -319,7 +319,6 @@ static bool can_open_cifile(void)
int test_alignment_handler_vsx_206(void)
{
- int rc = 0;
SKIP_IF(!can_open_cifile());
SKIP_IF(!have_hwcap(PPC_FEATURE_ARCH_2_06));
@@ -332,12 +331,11 @@ int test_alignment_handler_vsx_206(void)
STORE_VSX_XFORM_TEST(stxvd2x);
STORE_VSX_XFORM_TEST(stxvw4x);
STORE_VSX_XFORM_TEST(stxsdx);
- return rc;
+ return 0;
}
int test_alignment_handler_vsx_207(void)
{
- int rc = 0;
SKIP_IF(!can_open_cifile());
SKIP_IF(!have_hwcap2(PPC_FEATURE2_ARCH_2_07));
@@ -348,12 +346,11 @@ int test_alignment_handler_vsx_207(void)
LOAD_VSX_XFORM_TEST(lxsiwzx);
STORE_VSX_XFORM_TEST(stxsspx);
STORE_VSX_XFORM_TEST(stxsiwx);
- return rc;
+ return 0;
}
int test_alignment_handler_vsx_300(void)
{
- int rc = 0;
SKIP_IF(!can_open_cifile());
@@ -380,12 +377,11 @@ int test_alignment_handler_vsx_300(void)
STORE_VSX_XFORM_TEST(stxvx);
STORE_VSX_XFORM_TEST(stxvl);
STORE_VSX_XFORM_TEST(stxvll);
- return rc;
+ return 0;
}
int test_alignment_handler_vsx_prefix(void)
{
- int rc = 0;
SKIP_IF(!can_open_cifile());
SKIP_IF(!have_hwcap2(PPC_FEATURE2_ARCH_3_1));
@@ -399,12 +395,11 @@ int test_alignment_handler_vsx_prefix(void)
STORE_VSX_8LS_PREFIX_TEST(PSTXSSP, 0);
STORE_VSX_8LS_PREFIX_TEST(PSTXV0, 0);
STORE_VSX_8LS_PREFIX_TEST(PSTXV1, 1);
- return rc;
+ return 0;
}
int test_alignment_handler_integer(void)
{
- int rc = 0;
SKIP_IF(!can_open_cifile());
@@ -458,12 +453,11 @@ int test_alignment_handler_integer(void)
STORE_DFORM_TEST(stmw);
#endif
- return rc;
+ return 0;
}
int test_alignment_handler_integer_206(void)
{
- int rc = 0;
SKIP_IF(!can_open_cifile());
SKIP_IF(!have_hwcap(PPC_FEATURE_ARCH_2_06));
@@ -473,12 +467,11 @@ int test_alignment_handler_integer_206(void)
LOAD_XFORM_TEST(ldbrx);
STORE_XFORM_TEST(stdbrx);
- return rc;
+ return 0;
}
int test_alignment_handler_integer_prefix(void)
{
- int rc = 0;
SKIP_IF(!can_open_cifile());
SKIP_IF(!have_hwcap2(PPC_FEATURE2_ARCH_3_1));
@@ -494,12 +487,11 @@ int test_alignment_handler_integer_prefix(void)
STORE_MLS_PREFIX_TEST(PSTH);
STORE_MLS_PREFIX_TEST(PSTW);
STORE_8LS_PREFIX_TEST(PSTD);
- return rc;
+ return 0;
}
int test_alignment_handler_vmx(void)
{
- int rc = 0;
SKIP_IF(!can_open_cifile());
SKIP_IF(!have_hwcap(PPC_FEATURE_HAS_ALTIVEC));
@@ -522,12 +514,11 @@ int test_alignment_handler_vmx(void)
STORE_VMX_XFORM_TEST(stvehx);
STORE_VMX_XFORM_TEST(stvewx);
STORE_VMX_XFORM_TEST(stvxl);
- return rc;
+ return 0;
}
int test_alignment_handler_fp(void)
{
- int rc = 0;
SKIP_IF(!can_open_cifile());
@@ -550,12 +541,11 @@ int test_alignment_handler_fp(void)
STORE_FLOAT_XFORM_TEST(stfsux);
STORE_FLOAT_XFORM_TEST(stfiwx);
- return rc;
+ return 0;
}
int test_alignment_handler_fp_205(void)
{
- int rc = 0;
SKIP_IF(!can_open_cifile());
SKIP_IF(!have_hwcap(PPC_FEATURE_ARCH_2_05));
@@ -568,12 +558,11 @@ int test_alignment_handler_fp_205(void)
STORE_FLOAT_DFORM_TEST(stfdp);
STORE_FLOAT_XFORM_TEST(stfdpx);
- return rc;
+ return 0;
}
int test_alignment_handler_fp_206(void)
{
- int rc = 0;
SKIP_IF(!can_open_cifile());
SKIP_IF(!have_hwcap(PPC_FEATURE_ARCH_2_06));
@@ -582,13 +571,12 @@ int test_alignment_handler_fp_206(void)
LOAD_FLOAT_XFORM_TEST(lfiwzx);
- return rc;
+ return 0;
}
int test_alignment_handler_fp_prefix(void)
{
- int rc = 0;
SKIP_IF(!can_open_cifile());
SKIP_IF(!have_hwcap2(PPC_FEATURE2_ARCH_3_1));
@@ -599,7 +587,7 @@ int test_alignment_handler_fp_prefix(void)
LOAD_FLOAT_MLS_PREFIX_TEST(PLFD);
STORE_FLOAT_MLS_PREFIX_TEST(PSTFS);
STORE_FLOAT_MLS_PREFIX_TEST(PSTFD);
- return rc;
+ return 0;
}
void usage(char *prog)
next parent reply other threads:[~2023-06-14 6:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230614064848.5648-1-luojianhong@cdjrlc.com>
2023-06-14 6:51 ` baomingtong001 [this message]
[not found] <20230614070926.36395-1-zhanglibing@cdjrlc.com>
2023-06-14 7:12 ` [PATCH] selftests/powerpc: Remove unneeded variable wuyonggang001
2023-06-15 3:51 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d71a676bc9e2af23b3a89459c7320f74@208suo.com \
--to=baomingtong001@208suo.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).