From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Jin Zhengxiong" <Jason.Jin@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 4/4] booting-without-of for Freescale MSI
Date: Tue, 6 May 2008 12:44:22 +0200 [thread overview]
Message-ID: <d731595be98f00bf5387444b88de4883@kernel.crashing.org> (raw)
In-Reply-To: <CC27DED0F8F39E48A7E75FD768688B7A8C1399@zch01exm27.fsl.freescale.net>
>>> + - compatible : should be "fsl,MPIC-MSI" for 85xx/86xx cpu,
>>> + and "fsl,IPIC-MSI" for 83xx cpu.
>>
>> Please use a more specific name, "fsl,8599-msi" or similar?
>>
>
> Thanks for your input. I think the name "fsl,MPIC-MSI" and
> "fsl,IPIC-MSI"
> is somethind specific.
This is the third MSI-on-MPIC I've seen, and I doubt it will be the
last. It is likely FSL will make some different one in the future,
as well.
Please don't use generic names for specific devices.
Segher
next prev parent reply other threads:[~2008-05-06 10:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 7:47 [PATCH 1/4 V3] MSI support on 83xx/85xx/86xx board Jason Jin
2008-05-05 7:47 ` [PATCH 2/4 V2] Enable MSI support for MPC8610HPCD board Jason Jin
2008-05-05 7:47 ` [PATCH 3/4] Enable MSI support for 85xxds board Jason Jin
2008-05-05 7:47 ` [PATCH 4/4] booting-without-of for Freescale MSI Jason Jin
2008-05-05 18:00 ` Segher Boessenkool
2008-05-06 9:23 ` Jin Zhengxiong
2008-05-06 10:44 ` Segher Boessenkool [this message]
2008-05-07 9:35 ` Jin Zhengxiong
2008-05-05 11:24 ` [PATCH 1/4 V3] MSI support on 83xx/85xx/86xx board Michael Ellerman
2008-05-06 9:23 ` Jin Zhengxiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d731595be98f00bf5387444b88de4883@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=Jason.Jin@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).