From: Laurent Dufour <ldufour@linux.vnet.ibm.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: paulmck@linux.vnet.ibm.com, peterz@infradead.org,
akpm@linux-foundation.org, ak@linux.intel.com, mhocko@kernel.org,
dave@stgolabs.net, jack@suse.cz,
Matthew Wilcox <willy@infradead.org>,
benh@kernel.crashing.org, mpe@ellerman.id.au, paulus@samba.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
hpa@zytor.com, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
haren@linux.vnet.ibm.com, khandual@linux.vnet.ibm.com,
npiggin@gmail.com, bsingharora@gmail.com,
Tim Chen <tim.c.chen@linux.intel.com>,
linuxppc-dev@lists.ozlabs.org, x86@kernel.org
Subject: Re: [PATCH 02/16] mm: Prepare for FAULT_FLAG_SPECULATIVE
Date: Wed, 9 Aug 2017 12:54:06 +0200 [thread overview]
Message-ID: <d75b8f01-4fc0-bb29-cf80-0e91d91f238f@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170809100835.5kz3zf5sd3oqrrj4@node.shutemov.name>
On 09/08/2017 12:08, Kirill A. Shutemov wrote:
> On Tue, Aug 08, 2017 at 04:35:35PM +0200, Laurent Dufour wrote:
>> @@ -2295,7 +2302,11 @@ static int wp_page_copy(struct vm_fault *vmf)
>> /*
>> * Re-check the pte - we dropped the lock
>> */
>> - vmf->pte = pte_offset_map_lock(mm, vmf->pmd, vmf->address, &vmf->ptl);
>> + if (!pte_map_lock(vmf)) {
>> + mem_cgroup_cancel_charge(new_page, memcg, false);
>> + ret = VM_FAULT_RETRY;
>> + goto oom_free_new;
>
> With the change, label is misleading.
That's right.
But I'm wondering renaming it out to 'out_free_new' and replacing all the
matching 'goto' where the label was making sense will help readability ?
Have you better idea ?
next prev parent reply other threads:[~2017-08-09 10:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 14:35 [PATCH 00/16] Speculative page faults Laurent Dufour
2017-08-08 14:35 ` [PATCH 01/16] mm: Dont assume page-table invariance during faults Laurent Dufour
2017-08-08 14:35 ` [PATCH 02/16] mm: Prepare for FAULT_FLAG_SPECULATIVE Laurent Dufour
2017-08-09 10:08 ` Kirill A. Shutemov
2017-08-09 10:54 ` Laurent Dufour [this message]
2017-08-08 14:35 ` [PATCH 03/16] mm: Introduce pte_spinlock " Laurent Dufour
2017-08-08 14:35 ` [PATCH 04/16] mm: VMA sequence count Laurent Dufour
2017-08-08 14:35 ` [PATCH 05/16] mm: Protect VMA modifications using " Laurent Dufour
2017-08-09 10:12 ` Kirill A. Shutemov
2017-08-09 10:43 ` Laurent Dufour
2017-08-10 0:58 ` Kirill A. Shutemov
2017-08-10 8:27 ` Laurent Dufour
2017-08-10 13:43 ` Kirill A. Shutemov
2017-08-10 18:16 ` Laurent Dufour
2017-08-08 14:35 ` [PATCH 06/16] mm: RCU free VMAs Laurent Dufour
2017-08-08 14:35 ` [PATCH 07/16] mm: Provide speculative fault infrastructure Laurent Dufour
2017-08-08 14:35 ` [PATCH 08/16] mm: Try spin lock in speculative path Laurent Dufour
2017-08-08 14:35 ` [PATCH 09/16] x86/mm: Add speculative pagefault handling Laurent Dufour
2017-08-08 14:35 ` [PATCH 10/16] powerpc/mm: Add speculative page fault Laurent Dufour
2017-08-08 14:35 ` [PATCH 11/16] mm: Introduce __page_add_new_anon_rmap() Laurent Dufour
2017-08-08 14:35 ` [PATCH 12/16] mm: Protect SPF handler against anon_vma changes Laurent Dufour
2017-08-08 14:35 ` [PATCH 13/16] perf: Add a speculative page fault sw events Laurent Dufour
2017-08-09 13:18 ` Michael Ellerman
2017-08-09 13:25 ` Laurent Dufour
2017-08-08 14:35 ` [PATCH 14/16] x86/mm: Add support for SPF events Laurent Dufour
2017-08-08 14:35 ` [PATCH 15/16] powerpc/mm: " Laurent Dufour
2017-08-08 14:35 ` [PATCH 16/16] perf tools: " Laurent Dufour
2017-08-09 1:43 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d75b8f01-4fc0-bb29-cf80-0e91d91f238f@linux.vnet.ibm.com \
--to=ldufour@linux.vnet.ibm.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bsingharora@gmail.com \
--cc=dave@stgolabs.net \
--cc=haren@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=jack@suse.cz \
--cc=khandual@linux.vnet.ibm.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=will.deacon@arm.com \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).