From: Janosch Frank <frankja@linux.ibm.com>
To: Sean Christopherson <seanjc@google.com>,
Marc Zyngier <maz@kernel.org>,
Oliver Upton <oliver.upton@linux.dev>,
Tianrui Zhao <zhaotianrui@loongson.cn>,
Bibo Mao <maobibo@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Anup Patel <anup@brainfault.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
kvm@vger.kernel.org, loongarch@lists.linux.dev,
linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, Anish Ghulati <aghulati@google.com>,
Colton Lewis <coltonlewis@google.com>,
Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH 7/8] KVM: s390: Stop adding virt/kvm to the arch include path
Date: Thu, 12 Jun 2025 15:01:08 +0200 [thread overview]
Message-ID: <d794e153-3442-45b0-9913-13967859ff7d@linux.ibm.com> (raw)
In-Reply-To: <20250611001042.170501-8-seanjc@google.com>
On 6/11/25 2:10 AM, Sean Christopherson wrote:
> Don't add virt/kvm to KVM s390's include path, the headers in virt/kvm are
> intended to be used only by other code in virt/kvm, i.e. are "private" to
> the core KVM code. It's not clear that s390 *ever* included a header from
> virt/kvm, i.e. odds are good the "-Ivirt/kvm" was copied from a x86's
> Makefile when s390 support was first added.
>
> The only headers in virt/kvm at the time were the x86 specific ioapic.h,
> and iodev.h, neither of which shows up as an #include in the diff for the
> commit range 37817f2982d0f..e976a2b997fc4.
>
> Acked-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
next prev parent reply other threads:[~2025-06-12 13:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 0:10 [PATCH 0/8] KVM: Remove include/kvm, standardize includes Sean Christopherson
2025-06-11 0:10 ` [PATCH 1/8] KVM: arm64: Move arm_{psci,hypercalls}.h to an internal KVM path Sean Christopherson
2025-06-11 0:10 ` [PATCH 2/8] KVM: arm64: Include KVM headers to get forward declarations Sean Christopherson
2025-06-11 0:10 ` [PATCH 3/8] KVM: arm64: Move ARM specific headers in include/kvm to arch directory Sean Christopherson
2025-06-16 11:10 ` Zenghui Yu
2025-06-11 0:10 ` [PATCH 4/8] KVM: Move include/kvm/iodev.h to include/linux as kvm_iodev.h Sean Christopherson
2025-06-16 1:13 ` Bibo Mao
2025-06-11 0:10 ` [PATCH 5/8] KVM: MIPS: Stop adding virt/kvm to the arch include path Sean Christopherson
2025-06-11 0:10 ` [PATCH 6/8] KVM: PPC: " Sean Christopherson
2025-06-16 7:15 ` Gautam Menghani
2025-06-11 0:10 ` [PATCH 7/8] KVM: s390: " Sean Christopherson
2025-06-12 13:01 ` Janosch Frank [this message]
2025-06-11 0:10 ` [PATCH 8/8] KVM: Standardize include paths across all architectures Sean Christopherson
2025-06-12 4:56 ` [PATCH 0/8] KVM: Remove include/kvm, standardize includes Paolo Bonzini
2025-06-13 21:02 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d794e153-3442-45b0-9913-13967859ff7d@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=aghulati@google.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=borntraeger@linux.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=coltonlewis@google.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=maddy@linux.ibm.com \
--cc=maobibo@loongson.cn \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=thuth@redhat.com \
--cc=zhaotianrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).