Re: [PATCH v2 2/2] powerpc/crash: Update backup region offset in elfcorehdr on memory hotplug

[Sourabh Jain <sourabhjain@linux.ibm.com>]

On 08/03/26 01:43, Aditya Gupta wrote:
> On 26/03/07 10:50AM, Sourabh Jain wrote:
>> <...snip...>
>>
>> +#ifdef CONFIG_CRASH_DUMP
>> +/**
>> + * sync_backup_region_phdr - synchronize backup region offset between
>> + *			    kexec image and ELF core header.
>> + * @image: Kexec image.
>> + * @ehdr: ELF core header.
>> + * @phdr_to_kimage: If true, read the offset from the ELF program header
>> + *		    and update the kimage backup region. If false, update
>> + *		    the ELF program header offset from the kimage backup
>> + *		    region.
> nit: if sending a v4, can we add a comment in 'phdr_to_kimage' description that
> it is true in case of kexec_load and false in kexec_file_load, or maybe a
> different name for the boolean eg 'use_phdr_offset' or simply 'is_kexec_load' ?

I will update the comment and add how this function is called for 
kexec_load and kexec_file_load
syscall and keep the function arguments same.

>
> fwiw, part of the commit description mentions problem already fixed by patch 1
>
> Looks good. Tested in pseries qemu.
>
> Reviewed-by: Aditya Gupta <adityag@linux.ibm.com>
Thanks for the review.

- Sourabh Jain