linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: shriyak <shriyak@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	paulus@samba.org, ego@linux.vnet.ibm.com, mikey@neuling.org,
	aneesh.kumar@linux.vnet.ibm.com,
	Linuxppc-dev
	<linuxppc-dev-bounces+shriyak=linux.vnet.ibm.com@lists.ozlabs.org>
Subject: Re: [PATCH] cpufreq: powernv: Return the actual CPU frequency in /proc/cpuinfo
Date: Fri, 06 Oct 2017 16:52:48 +0530	[thread overview]
Message-ID: <d88b1fb751964b14977a4281369de122@linux.vnet.ibm.com> (raw)
In-Reply-To: <87mv544lgz.fsf@concordia.ellerman.id.au>

On 2017-10-06 16:00, Michael Ellerman wrote:
> Shriya <shriyak@linux.vnet.ibm.com> writes:
> 
>> Make /proc/cpuinfo read the frequency of the CPU it is running at
>> instead of reading the cached value of the last requested frequency.
>> In conditions like WOF/throttle CPU can be running at a different
>> frequency than the requested frequency.
> 
> Sounds like a bug fix to me ?
> 
> cheers
> 
>> diff --git a/arch/powerpc/platforms/powernv/setup.c 
>> b/arch/powerpc/platforms/powernv/setup.c
>> index 897aa14..55ea4bf 100644
>> --- a/arch/powerpc/platforms/powernv/setup.c
>> +++ b/arch/powerpc/platforms/powernv/setup.c
>> @@ -311,7 +311,7 @@ static unsigned long pnv_get_proc_freq(unsigned 
>> int cpu)
>>  {
>>  	unsigned long ret_freq;
>> 
>> -	ret_freq = cpufreq_quick_get(cpu) * 1000ul;
>> +	ret_freq = cpufreq_get(cpu) * 1000ul;
>> 
>>  	/*
>>  	 * If the backend cpufreq driver does not exist,
>> --
>> 1.9.1

Yes, its a bug fix.

Thanks.

  reply	other threads:[~2017-10-06 11:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06  7:24 [PATCH] cpufreq: powernv: Return the actual CPU frequency in /proc/cpuinfo Shriya
2017-10-06 10:30 ` Michael Ellerman
2017-10-06 11:22   ` shriyak [this message]
2017-11-16 15:14 ` Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d88b1fb751964b14977a4281369de122@linux.vnet.ibm.com \
    --to=shriyak@linux.vnet.ibm.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=ego@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev-bounces+shriyak=linux.vnet.ibm.com@lists.ozlabs.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).