From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76294CCA471 for ; Mon, 6 Oct 2025 04:04:18 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4cg5Hh494Sz303B; Mon, 6 Oct 2025 15:04:16 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2600:3c04:e001:324:0:1991:8:25" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1759723456; cv=none; b=R1hnPPa0k4T+eMLd3sP1mUzy9KQaMoJUcjDaiw5aZMnQGX/CT4IRbrAziib6IrsQtZ91NyihQUcT4UvrjCDSEP8mpMk+FLVJjWj+Ix8hilfpIk6bwdsU/M/rQQCXrw/uS2IDxO4oQoSEQMkLpidse+a7eewqMf90AwevNm/TAq0LCtiOgNc7WnDeQLctK84KQDRlJFfySgiUvgWvs+8TycXTq/kAwWjPNltcRT/HVgPgvmRiMXj0oLUfWtkuGV9eV7EP4S/VVIALg1wWEdTH7MSE1Vn5kBSfqBEcCEG+BCVL13slxDKavZ66L+WdKJSbaG9bxD7Nmu5L8nln6U2+2g== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1759723456; c=relaxed/relaxed; bh=V0xxJjR/aWnVZlhSQoZ/liem0KiMSdTrOEVmyyiFsA8=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=CcRuSsug/5y7VVT2n70PcY1UdQpAcN3ADIAAcY/YzD185wGp9VUgBCqNa2OmHThFcBDIOVd0hSu3T0ciajA5/o6fwviBqBBKWN1BGoFDU+nhuBtRxhe0AkTo+snqeluLZlXWXE+eris1jDOgjvn3d0MifcHBGD9YQqmGypiDpCPBcRU3vHzZs23AQO4RE/lkzzVLBJ9MLee1otiwuwNphECepxkqVKpcsTj2lMGtwXt65W92f7Wf4cTVEbpd+Mj6UR5d5Tdh/8p8nvq5xSce+HBhL1F3eQO9HSmZSfdWWjLMLSkTmNpFEoZHY930AmBQSASJ7r1vNppLSXkx1gMrjA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=dx6gZOcR; dkim-atps=neutral; spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=leon@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=dx6gZOcR; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=leon@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4cg5Hg3FMSz2xQ6 for ; Mon, 6 Oct 2025 15:04:15 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id BA4606036E; Mon, 6 Oct 2025 04:04:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 939FAC4CEF5; Mon, 6 Oct 2025 04:04:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759723452; bh=84injLzOLRzdmbDYcF7g7essdb0dt9odOMPRFgL8OhA=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=dx6gZOcRbqZU+4kUH56naw+qthiBcZkT1qtIonANRtUnPXGgZSzKl9WgCt0SFdIhm UbVwoHC4Vs5XWd+JXXmA7hVHDHHcljPxzABSrPU51Ilo+qPPKD4b50iM60t7KVVjsb SMzmXH2mA9VXny2uTwbYaN5+nstbvZoog7xyFS4WtMcvFaxYJ3i1X4/aK2vr9AVBnQ f0YfFDMNeIIwcHvnhWFJp9a2t2UhTULfUIaQQ+5l6+IR5madltMoqZysTSG0SPagkr ukbTi0OjnBiX86Vpr47x0xqWuIEElCfBCKo/rFvEhZv8rGQQRLNt3XkZDanjZzNwxN maoDHGG6tUMAQ== Received: from phl-compute-12.internal (phl-compute-12.internal [10.202.2.52]) by mailfauth.phl.internal (Postfix) with ESMTP id 6D24EF40066; Mon, 6 Oct 2025 00:04:10 -0400 (EDT) Received: from phl-imap-08 ([10.202.2.84]) by phl-compute-12.internal (MEProxy); Mon, 06 Oct 2025 00:04:10 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdelieehgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefoggffhffvvefkjghfufgtgfesthejredtredttdenucfhrhhomhepfdfnvghonhcu tfhomhgrnhhovhhskhihfdcuoehlvghonheskhgvrhhnvghlrdhorhhgqeenucggtffrrg htthgvrhhnpeejvefflefgledvgfevvdetleehhfdvffehgeffkeevleeiveefjeetieel ueeuvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hlvghonhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidquddvfedtheefleek gedqvdejjeeljeejvdekqdhlvghonheppehkvghrnhgvlhdrohhrgheslhgvohhnrdhnuh dpnhgspghrtghpthhtohepfedupdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegs phesrghlihgvnhekrdguvgdprhgtphhtthhopehtshgsohhgvghnugesrghlphhhrgdrfh hrrghnkhgvnhdruggvpdhrtghpthhtohepuggrvhgvmhesuggrvhgvmhhlohhfthdrnhgv thdprhgtphhtthhopehmphgvsegvlhhlvghrmhgrnhdrihgurdgruhdprhgtphhtthhope grnhgurhgvrghssehgrghishhlvghrrdgtohhmpdhrtghpthhtoheplhhinhhmrghgjees ghhmrghilhdrtghomhdprhgtphhtthhopehmrghtthhsthekkeesghhmrghilhdrtghomh dprhgtphhtthhopeguvghllhgvrhesghhmgidruggvpdhrtghpthhtohepjhgrmhgvshdr sghothhtohhmlhgvhieshhgrnhhsvghnphgrrhhtnhgvrhhshhhiphdrtghomh X-ME-Proxy: Feedback-ID: i927946fb:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 14BDB2CE0072; Mon, 6 Oct 2025 00:04:10 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 X-ThreadId: AYer2uYmcW7k Date: Mon, 06 Oct 2025 07:03:49 +0300 From: "Leon Romanovsky" To: "Jason Gunthorpe" Cc: "Marek Szyprowski" , "Andreas Larsson" , "Borislav Petkov" , "Dave Hansen" , "David Miller" , "Geoff Levand" , "Helge Deller" , "Ingo Molnar" , iommu@lists.linux.dev, "James E.J. Bottomley" , "Jason Wang" , "Juergen Gross" , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "Madhavan Srinivasan" , "Matt Turner" , "Michael Ellerman" , "Michael S. Tsirkin" , "Richard Henderson" , sparclinux@vger.kernel.org, "Stefano Stabellini" , "Thomas Bogendoerfer" , "Thomas Gleixner" , virtualization@lists.linux.dev, x86@kernel.org, xen-devel@lists.xenproject.org, "Magnus Lindholm" Message-Id: In-Reply-To: <20251005233133.GL3360665@nvidia.com> References: <333ec4dabec16d3d913a93780bc6e7ddb5240fcf.1759071169.git.leon@kernel.org> <20251003150144.GC3360665@nvidia.com> <20251005132259.GA21221@unreal> <20251005233133.GL3360665@nvidia.com> Subject: Re: [PATCH v1 3/9] parisc: Convert DMA map_page to map_phys interface Content-Type: text/plain Content-Transfer-Encoding: 7bit On Mon, Oct 6, 2025, at 02:31, Jason Gunthorpe wrote: > On Sun, Oct 05, 2025 at 04:22:59PM +0300, Leon Romanovsky wrote: >> @@ -582,7 +582,7 @@ ccio_io_pdir_entry(__le64 *pdir_ptr, space_t sid, unsigned long vba, >> ** Grab virtual index [0:11] >> ** Deposit virt_idx bits into I/O PDIR word >> */ >> - asm volatile ("lci %%r0(%1), %0" : "=r" (ci) : "r" (vba)); >> + asm volatile ("lci %%r0(%1), %0" : "=r" (ci) : "r" (pba)); > > Don't know how I missed this, but this is the virtual address for the > cache invalidate James mentioned > > So the optimal is to drop the lpa() and to use phys_to_virt() to get > vba for this instruction. The optimal is to keep parisc arch code as I did in v1 and don't change it too much. > > Jason