* Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
[not found] <20230602140143.0af52cee@canb.auug.org.au>
@ 2023-06-02 20:56 ` Randy Dunlap
2023-06-04 0:22 ` Michael Ellerman
0 siblings, 1 reply; 9+ messages in thread
From: Randy Dunlap @ 2023-06-02 20:56 UTC (permalink / raw)
To: Stephen Rothwell, Linux Next Mailing List
Cc: Alexey Kardashevskiy, Timothy Pearson, linuxppc-dev,
Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 4385 bytes --]
On 6/1/23 21:01, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20230601:
>
On powerpc64, a randconfig failed with:
In file included from ../include/linux/list.h:5,
from ../include/linux/preempt.h:11,
from ../include/linux/spinlock.h:56,
from ../include/linux/mmzone.h:8,
from ../include/linux/gfp.h:7,
from ../include/linux/slab.h:15,
from ../arch/powerpc/kernel/iommu.c:15:
../arch/powerpc/kernel/iommu.c: In function 'spapr_tce_setup_phb_iommus_initcall':
../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use in this function); did you mean 'zonelist'?
1391 | list_for_each_entry(hose, &hose_list, list_node) {
| ^~~~~~~~~
../include/linux/container_of.h:19:33: note: in definition of macro 'container_of'
19 | void *__mptr = (void *)(ptr); \
| ^~~
../include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
531 | list_entry((ptr)->next, type, member)
| ^~~~~~~~~~
../include/linux/list.h:689:20: note: in expansion of macro 'list_first_entry'
689 | for (pos = list_first_entry(head, typeof(*pos), member); \
| ^~~~~~~~~~~~~~~~
../arch/powerpc/kernel/iommu.c:1391:9: note: in expansion of macro 'list_for_each_entry'
1391 | list_for_each_entry(hose, &hose_list, list_node) {
| ^~~~~~~~~~~~~~~~~~~
../arch/powerpc/kernel/iommu.c:1391:36: note: each undeclared identifier is reported only once for each function it appears in
1391 | list_for_each_entry(hose, &hose_list, list_node) {
| ^~~~~~~~~
../include/linux/container_of.h:19:33: note: in definition of macro 'container_of'
19 | void *__mptr = (void *)(ptr); \
| ^~~
../include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
531 | list_entry((ptr)->next, type, member)
| ^~~~~~~~~~
../include/linux/list.h:689:20: note: in expansion of macro 'list_first_entry'
689 | for (pos = list_first_entry(head, typeof(*pos), member); \
| ^~~~~~~~~~~~~~~~
../arch/powerpc/kernel/iommu.c:1391:9: note: in expansion of macro 'list_for_each_entry'
1391 | list_for_each_entry(hose, &hose_list, list_node) {
| ^~~~~~~~~~~~~~~~~~~
In file included from ../include/linux/init.h:5,
from ../arch/powerpc/kernel/iommu.c:13:
./../include/linux/compiler_types.h:338:27: error: expression in static assertion is not an integer
338 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
../include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
../include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~
../include/linux/list.h:520:9: note: in expansion of macro 'container_of'
520 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
../include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
531 | list_entry((ptr)->next, type, member)
| ^~~~~~~~~~
../include/linux/list.h:689:20: note: in expansion of macro 'list_first_entry'
689 | for (pos = list_first_entry(head, typeof(*pos), member); \
| ^~~~~~~~~~~~~~~~
../arch/powerpc/kernel/iommu.c:1391:9: note: in expansion of macro 'list_for_each_entry'
1391 | list_for_each_entry(hose, &hose_list, list_node) {
| ^~~~~~~~~~~~~~~~~~~
CONFIG_IOMMU_API=y
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_IOMMU_HELPER=y
Full randconfig file is attached.
--
~Randy
[-- Attachment #2: config-r9531.gz --]
[-- Type: application/gzip, Size: 27539 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
2023-06-02 20:56 ` linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c) Randy Dunlap
@ 2023-06-04 0:22 ` Michael Ellerman
2023-06-04 3:57 ` Timothy Pearson
0 siblings, 1 reply; 9+ messages in thread
From: Michael Ellerman @ 2023-06-04 0:22 UTC (permalink / raw)
To: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List
Cc: Alexey Kardashevskiy, Timothy Pearson, linuxppc-dev,
Linux Kernel Mailing List
Randy Dunlap <rdunlap@infradead.org> writes:
> On 6/1/23 21:01, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20230601:
>>
>
> On powerpc64, a randconfig failed with:
>
> In file included from ../include/linux/list.h:5,
> from ../include/linux/preempt.h:11,
> from ../include/linux/spinlock.h:56,
> from ../include/linux/mmzone.h:8,
> from ../include/linux/gfp.h:7,
> from ../include/linux/slab.h:15,
> from ../arch/powerpc/kernel/iommu.c:15:
> ../arch/powerpc/kernel/iommu.c: In function 'spapr_tce_setup_phb_iommus_initcall':
> ../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use in this function); did you mean 'zonelist'?
> 1391 | list_for_each_entry(hose, &hose_list, list_node) {
> | ^~~~~~~~~
...
hose_list is in pci-common.c which is built when PCI=y.
PSERIES and POWERNV force PCI=y.
But this config has neither:
# CONFIG_PPC_POWERNV is not set
# CONFIG_PPC_PSERIES is not set
CONFIG_HAVE_PCI=y
# CONFIG_PCI is not set
# CONFIG_COMMON_CLK_RS9_PCIE is not set
Probably the spapr_tce code should be wrapped in an #ifdef that is only
enabled when POWERNV || PSERIES is enabled.
cheers
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
2023-06-04 0:22 ` Michael Ellerman
@ 2023-06-04 3:57 ` Timothy Pearson
2023-06-04 21:55 ` Randy Dunlap
2023-06-15 16:00 ` Randy Dunlap
0 siblings, 2 replies; 9+ messages in thread
From: Timothy Pearson @ 2023-06-04 3:57 UTC (permalink / raw)
To: Michael Ellerman
Cc: Stephen Rothwell, Alexey Kardashevskiy, Randy Dunlap,
linux-kernel, Linux Next Mailing List, linuxppc-dev
----- Original Message -----
> From: "Michael Ellerman" <mpe@ellerman.id.au>
> To: "Randy Dunlap" <rdunlap@infradead.org>, "Stephen Rothwell" <sfr@canb.auug.org.au>, "Linux Next Mailing List"
> <linux-next@vger.kernel.org>
> Cc: "linux-kernel" <linux-kernel@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>, "Alexey
> Kardashevskiy" <aik@ozlabs.ru>, "Timothy Pearson" <tpearson@raptorengineering.com>
> Sent: Saturday, June 3, 2023 7:22:51 PM
> Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
> Randy Dunlap <rdunlap@infradead.org> writes:
>> On 6/1/23 21:01, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20230601:
>>>
>>
>> On powerpc64, a randconfig failed with:
>>
>> In file included from ../include/linux/list.h:5,
>> from ../include/linux/preempt.h:11,
>> from ../include/linux/spinlock.h:56,
>> from ../include/linux/mmzone.h:8,
>> from ../include/linux/gfp.h:7,
>> from ../include/linux/slab.h:15,
>> from ../arch/powerpc/kernel/iommu.c:15:
>> ../arch/powerpc/kernel/iommu.c: In function
>> 'spapr_tce_setup_phb_iommus_initcall':
>> ../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use
>> in this function); did you mean 'zonelist'?
>> 1391 | list_for_each_entry(hose, &hose_list, list_node) {
>> | ^~~~~~~~~
> ...
>
> hose_list is in pci-common.c which is built when PCI=y.
>
> PSERIES and POWERNV force PCI=y.
>
> But this config has neither:
>
> # CONFIG_PPC_POWERNV is not set
> # CONFIG_PPC_PSERIES is not set
> CONFIG_HAVE_PCI=y
> # CONFIG_PCI is not set
> # CONFIG_COMMON_CLK_RS9_PCIE is not set
>
>
> Probably the spapr_tce code should be wrapped in an #ifdef that is only
> enabled when POWERNV || PSERIES is enabled.
>
> cheers
Sounds reasonable, I was going to look into this further over the weekend. I can put together a patch for Monday if that works?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
2023-06-04 3:57 ` Timothy Pearson
@ 2023-06-04 21:55 ` Randy Dunlap
2023-06-15 16:00 ` Randy Dunlap
1 sibling, 0 replies; 9+ messages in thread
From: Randy Dunlap @ 2023-06-04 21:55 UTC (permalink / raw)
To: Timothy Pearson, Michael Ellerman
Cc: Alexey Kardashevskiy, Stephen Rothwell, Linux Next Mailing List,
linuxppc-dev, linux-kernel
On 6/3/23 20:57, Timothy Pearson wrote:
>
>
> ----- Original Message -----
>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>> To: "Randy Dunlap" <rdunlap@infradead.org>, "Stephen Rothwell" <sfr@canb.auug.org.au>, "Linux Next Mailing List"
>> <linux-next@vger.kernel.org>
>> Cc: "linux-kernel" <linux-kernel@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>, "Alexey
>> Kardashevskiy" <aik@ozlabs.ru>, "Timothy Pearson" <tpearson@raptorengineering.com>
>> Sent: Saturday, June 3, 2023 7:22:51 PM
>> Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
>
>> Randy Dunlap <rdunlap@infradead.org> writes:
>>> On 6/1/23 21:01, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> Changes since 20230601:
>>>>
>>>
>>> On powerpc64, a randconfig failed with:
>>>
>>> In file included from ../include/linux/list.h:5,
>>> from ../include/linux/preempt.h:11,
>>> from ../include/linux/spinlock.h:56,
>>> from ../include/linux/mmzone.h:8,
>>> from ../include/linux/gfp.h:7,
>>> from ../include/linux/slab.h:15,
>>> from ../arch/powerpc/kernel/iommu.c:15:
>>> ../arch/powerpc/kernel/iommu.c: In function
>>> 'spapr_tce_setup_phb_iommus_initcall':
>>> ../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use
>>> in this function); did you mean 'zonelist'?
>>> 1391 | list_for_each_entry(hose, &hose_list, list_node) {
>>> | ^~~~~~~~~
>> ...
>>
>> hose_list is in pci-common.c which is built when PCI=y.
>>
>> PSERIES and POWERNV force PCI=y.
>>
>> But this config has neither:
>>
>> # CONFIG_PPC_POWERNV is not set
>> # CONFIG_PPC_PSERIES is not set
>> CONFIG_HAVE_PCI=y
>> # CONFIG_PCI is not set
>> # CONFIG_COMMON_CLK_RS9_PCIE is not set
>>
>>
>> Probably the spapr_tce code should be wrapped in an #ifdef that is only
>> enabled when POWERNV || PSERIES is enabled.
>>
>> cheers
>
> Sounds reasonable, I was going to look into this further over the weekend. I can put together a patch for Monday if that works?
Works for me. Go for it.
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
2023-06-04 3:57 ` Timothy Pearson
2023-06-04 21:55 ` Randy Dunlap
@ 2023-06-15 16:00 ` Randy Dunlap
2023-06-15 16:05 ` Timothy Pearson
1 sibling, 1 reply; 9+ messages in thread
From: Randy Dunlap @ 2023-06-15 16:00 UTC (permalink / raw)
To: Timothy Pearson, Michael Ellerman
Cc: Alexey Kardashevskiy, Stephen Rothwell, Linux Next Mailing List,
linuxppc-dev, linux-kernel
Hi Timothy,
On 6/3/23 20:57, Timothy Pearson wrote:
>
>
> ----- Original Message -----
>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>> To: "Randy Dunlap" <rdunlap@infradead.org>, "Stephen Rothwell" <sfr@canb.auug.org.au>, "Linux Next Mailing List"
>> <linux-next@vger.kernel.org>
>> Cc: "linux-kernel" <linux-kernel@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>, "Alexey
>> Kardashevskiy" <aik@ozlabs.ru>, "Timothy Pearson" <tpearson@raptorengineering.com>
>> Sent: Saturday, June 3, 2023 7:22:51 PM
>> Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
>
>> Randy Dunlap <rdunlap@infradead.org> writes:
>>> On 6/1/23 21:01, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> Changes since 20230601:
>>>>
>>>
>>> On powerpc64, a randconfig failed with:
>>>
>>> In file included from ../include/linux/list.h:5,
>>> from ../include/linux/preempt.h:11,
>>> from ../include/linux/spinlock.h:56,
>>> from ../include/linux/mmzone.h:8,
>>> from ../include/linux/gfp.h:7,
>>> from ../include/linux/slab.h:15,
>>> from ../arch/powerpc/kernel/iommu.c:15:
>>> ../arch/powerpc/kernel/iommu.c: In function
>>> 'spapr_tce_setup_phb_iommus_initcall':
>>> ../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use
>>> in this function); did you mean 'zonelist'?
>>> 1391 | list_for_each_entry(hose, &hose_list, list_node) {
>>> | ^~~~~~~~~
>> ...
>>
>> hose_list is in pci-common.c which is built when PCI=y.
>>
>> PSERIES and POWERNV force PCI=y.
>>
>> But this config has neither:
>>
>> # CONFIG_PPC_POWERNV is not set
>> # CONFIG_PPC_PSERIES is not set
>> CONFIG_HAVE_PCI=y
>> # CONFIG_PCI is not set
>> # CONFIG_COMMON_CLK_RS9_PCIE is not set
>>
>>
>> Probably the spapr_tce code should be wrapped in an #ifdef that is only
>> enabled when POWERNV || PSERIES is enabled.
>>
>> cheers
>
> Sounds reasonable, I was going to look into this further over the weekend. I can put together a patch for Monday if that works?
Did you prepare a patch for this? I am still seeing this build error.
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
2023-06-15 16:00 ` Randy Dunlap
@ 2023-06-15 16:05 ` Timothy Pearson
2023-06-15 16:13 ` Randy Dunlap
0 siblings, 1 reply; 9+ messages in thread
From: Timothy Pearson @ 2023-06-15 16:05 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, Alexey Kardashevskiy, linux-kernel,
Timothy Pearson, Linux Next Mailing List, linuxppc-dev
----- Original Message -----
> From: "Randy Dunlap" <rdunlap@infradead.org>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "Michael Ellerman" <mpe@ellerman.id.au>
> Cc: "Stephen Rothwell" <sfr@canb.auug.org.au>, "Linux Next Mailing List" <linux-next@vger.kernel.org>, "linux-kernel"
> <linux-kernel@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>, "Alexey Kardashevskiy" <aik@ozlabs.ru>
> Sent: Thursday, June 15, 2023 11:00:08 AM
> Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
> Hi Timothy,
>
> On 6/3/23 20:57, Timothy Pearson wrote:
>>
>>
>> ----- Original Message -----
>>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>>> To: "Randy Dunlap" <rdunlap@infradead.org>, "Stephen Rothwell"
>>> <sfr@canb.auug.org.au>, "Linux Next Mailing List"
>>> <linux-next@vger.kernel.org>
>>> Cc: "linux-kernel" <linux-kernel@vger.kernel.org>, "linuxppc-dev"
>>> <linuxppc-dev@lists.ozlabs.org>, "Alexey
>>> Kardashevskiy" <aik@ozlabs.ru>, "Timothy Pearson"
>>> <tpearson@raptorengineering.com>
>>> Sent: Saturday, June 3, 2023 7:22:51 PM
>>> Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
>>
>>> Randy Dunlap <rdunlap@infradead.org> writes:
>>>> On 6/1/23 21:01, Stephen Rothwell wrote:
>>>>> Hi all,
>>>>>
>>>>> Changes since 20230601:
>>>>>
>>>>
>>>> On powerpc64, a randconfig failed with:
>>>>
>>>> In file included from ../include/linux/list.h:5,
>>>> from ../include/linux/preempt.h:11,
>>>> from ../include/linux/spinlock.h:56,
>>>> from ../include/linux/mmzone.h:8,
>>>> from ../include/linux/gfp.h:7,
>>>> from ../include/linux/slab.h:15,
>>>> from ../arch/powerpc/kernel/iommu.c:15:
>>>> ../arch/powerpc/kernel/iommu.c: In function
>>>> 'spapr_tce_setup_phb_iommus_initcall':
>>>> ../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use
>>>> in this function); did you mean 'zonelist'?
>>>> 1391 | list_for_each_entry(hose, &hose_list, list_node) {
>>>> | ^~~~~~~~~
>>> ...
>>>
>>> hose_list is in pci-common.c which is built when PCI=y.
>>>
>>> PSERIES and POWERNV force PCI=y.
>>>
>>> But this config has neither:
>>>
>>> # CONFIG_PPC_POWERNV is not set
>>> # CONFIG_PPC_PSERIES is not set
>>> CONFIG_HAVE_PCI=y
>>> # CONFIG_PCI is not set
>>> # CONFIG_COMMON_CLK_RS9_PCIE is not set
>>>
>>>
>>> Probably the spapr_tce code should be wrapped in an #ifdef that is only
>>> enabled when POWERNV || PSERIES is enabled.
>>>
>>> cheers
>>
>> Sounds reasonable, I was going to look into this further over the weekend. I
>> can put together a patch for Monday if that works?
>
> Did you prepare a patch for this? I am still seeing this build error.
>
> thanks.
> --
> ~Randy
Yes, it was sent in to the linuxppc-dev list some weeks ago. Did it not arrive?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
2023-06-15 16:05 ` Timothy Pearson
@ 2023-06-15 16:13 ` Randy Dunlap
2023-06-15 16:34 ` Randy Dunlap
0 siblings, 1 reply; 9+ messages in thread
From: Randy Dunlap @ 2023-06-15 16:13 UTC (permalink / raw)
To: Timothy Pearson
Cc: Stephen Rothwell, Alexey Kardashevskiy, linux-kernel,
Linux Next Mailing List, linuxppc-dev
On 6/15/23 09:05, Timothy Pearson wrote:
>
>
> ----- Original Message -----
>> From: "Randy Dunlap" <rdunlap@infradead.org>
>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "Michael Ellerman" <mpe@ellerman.id.au>
>> Cc: "Stephen Rothwell" <sfr@canb.auug.org.au>, "Linux Next Mailing List" <linux-next@vger.kernel.org>, "linux-kernel"
>> <linux-kernel@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>, "Alexey Kardashevskiy" <aik@ozlabs.ru>
>> Sent: Thursday, June 15, 2023 11:00:08 AM
>> Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
>
>> Hi Timothy,
>>
>> On 6/3/23 20:57, Timothy Pearson wrote:
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>>>> To: "Randy Dunlap" <rdunlap@infradead.org>, "Stephen Rothwell"
>>>> <sfr@canb.auug.org.au>, "Linux Next Mailing List"
>>>> <linux-next@vger.kernel.org>
>>>> Cc: "linux-kernel" <linux-kernel@vger.kernel.org>, "linuxppc-dev"
>>>> <linuxppc-dev@lists.ozlabs.org>, "Alexey
>>>> Kardashevskiy" <aik@ozlabs.ru>, "Timothy Pearson"
>>>> <tpearson@raptorengineering.com>
>>>> Sent: Saturday, June 3, 2023 7:22:51 PM
>>>> Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
>>>
>>>> Randy Dunlap <rdunlap@infradead.org> writes:
>>>>> On 6/1/23 21:01, Stephen Rothwell wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> Changes since 20230601:
>>>>>>
>>>>>
>>>>> On powerpc64, a randconfig failed with:
>>>>>
>>>>> In file included from ../include/linux/list.h:5,
>>>>> from ../include/linux/preempt.h:11,
>>>>> from ../include/linux/spinlock.h:56,
>>>>> from ../include/linux/mmzone.h:8,
>>>>> from ../include/linux/gfp.h:7,
>>>>> from ../include/linux/slab.h:15,
>>>>> from ../arch/powerpc/kernel/iommu.c:15:
>>>>> ../arch/powerpc/kernel/iommu.c: In function
>>>>> 'spapr_tce_setup_phb_iommus_initcall':
>>>>> ../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use
>>>>> in this function); did you mean 'zonelist'?
>>>>> 1391 | list_for_each_entry(hose, &hose_list, list_node) {
>>>>> | ^~~~~~~~~
>>>> ...
>>>>
>>>> hose_list is in pci-common.c which is built when PCI=y.
>>>>
>>>> PSERIES and POWERNV force PCI=y.
>>>>
>>>> But this config has neither:
>>>>
>>>> # CONFIG_PPC_POWERNV is not set
>>>> # CONFIG_PPC_PSERIES is not set
>>>> CONFIG_HAVE_PCI=y
>>>> # CONFIG_PCI is not set
>>>> # CONFIG_COMMON_CLK_RS9_PCIE is not set
>>>>
>>>>
>>>> Probably the spapr_tce code should be wrapped in an #ifdef that is only
>>>> enabled when POWERNV || PSERIES is enabled.
>>>>
>>>> cheers
>>>
>>> Sounds reasonable, I was going to look into this further over the weekend. I
>>> can put together a patch for Monday if that works?
>>
>> Did you prepare a patch for this? I am still seeing this build error.
>>
>> thanks.
>> --
>> ~Randy
>
> Yes, it was sent in to the linuxppc-dev list some weeks ago. Did it not arrive?
I don't know - I'm not subscribed to that list.
It's probably still in the patchworks review cycle
so it hasn't been applied anywhere that gets into linux-next.
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
2023-06-15 16:13 ` Randy Dunlap
@ 2023-06-15 16:34 ` Randy Dunlap
2023-06-15 22:46 ` Christophe Leroy
0 siblings, 1 reply; 9+ messages in thread
From: Randy Dunlap @ 2023-06-15 16:34 UTC (permalink / raw)
To: Timothy Pearson
Cc: Stephen Rothwell, Alexey Kardashevskiy, linux-kernel,
Linux Next Mailing List, linuxppc-dev
On 6/15/23 09:13, Randy Dunlap wrote:
>
>
> On 6/15/23 09:05, Timothy Pearson wrote:
>>
>>
>> ----- Original Message -----
>>> From: "Randy Dunlap" <rdunlap@infradead.org>
>>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "Michael Ellerman" <mpe@ellerman.id.au>
>>> Cc: "Stephen Rothwell" <sfr@canb.auug.org.au>, "Linux Next Mailing List" <linux-next@vger.kernel.org>, "linux-kernel"
>>> <linux-kernel@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>, "Alexey Kardashevskiy" <aik@ozlabs.ru>
>>> Sent: Thursday, June 15, 2023 11:00:08 AM
>>> Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
>>
>>> Hi Timothy,
>>>
>>> On 6/3/23 20:57, Timothy Pearson wrote:
>>>>
>>>>
>>>> ----- Original Message -----
>>>>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>>>>> To: "Randy Dunlap" <rdunlap@infradead.org>, "Stephen Rothwell"
>>>>> <sfr@canb.auug.org.au>, "Linux Next Mailing List"
>>>>> <linux-next@vger.kernel.org>
>>>>> Cc: "linux-kernel" <linux-kernel@vger.kernel.org>, "linuxppc-dev"
>>>>> <linuxppc-dev@lists.ozlabs.org>, "Alexey
>>>>> Kardashevskiy" <aik@ozlabs.ru>, "Timothy Pearson"
>>>>> <tpearson@raptorengineering.com>
>>>>> Sent: Saturday, June 3, 2023 7:22:51 PM
>>>>> Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
>>>>
>>>>> Randy Dunlap <rdunlap@infradead.org> writes:
>>>>>> On 6/1/23 21:01, Stephen Rothwell wrote:
>>>>>>> Hi all,
>>>>>>>
>>>>>>> Changes since 20230601:
>>>>>>>
>>>>>>
>>>>>> On powerpc64, a randconfig failed with:
>>>>>>
>>>>>> In file included from ../include/linux/list.h:5,
>>>>>> from ../include/linux/preempt.h:11,
>>>>>> from ../include/linux/spinlock.h:56,
>>>>>> from ../include/linux/mmzone.h:8,
>>>>>> from ../include/linux/gfp.h:7,
>>>>>> from ../include/linux/slab.h:15,
>>>>>> from ../arch/powerpc/kernel/iommu.c:15:
>>>>>> ../arch/powerpc/kernel/iommu.c: In function
>>>>>> 'spapr_tce_setup_phb_iommus_initcall':
>>>>>> ../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use
>>>>>> in this function); did you mean 'zonelist'?
>>>>>> 1391 | list_for_each_entry(hose, &hose_list, list_node) {
>>>>>> | ^~~~~~~~~
>>>>> ...
>>>>>
>>>>> hose_list is in pci-common.c which is built when PCI=y.
>>>>>
>>>>> PSERIES and POWERNV force PCI=y.
>>>>>
>>>>> But this config has neither:
>>>>>
>>>>> # CONFIG_PPC_POWERNV is not set
>>>>> # CONFIG_PPC_PSERIES is not set
>>>>> CONFIG_HAVE_PCI=y
>>>>> # CONFIG_PCI is not set
>>>>> # CONFIG_COMMON_CLK_RS9_PCIE is not set
>>>>>
>>>>>
>>>>> Probably the spapr_tce code should be wrapped in an #ifdef that is only
>>>>> enabled when POWERNV || PSERIES is enabled.
>>>>>
>>>>> cheers
>>>>
>>>> Sounds reasonable, I was going to look into this further over the weekend. I
>>>> can put together a patch for Monday if that works?
>>>
>>> Did you prepare a patch for this? I am still seeing this build error.
>>>
>>> thanks.
>>> --
>>> ~Randy
>>
>> Yes, it was sent in to the linuxppc-dev list some weeks ago. Did it not arrive?
>
> I don't know - I'm not subscribed to that list.
>
> It's probably still in the patchworks review cycle
> so it hasn't been applied anywhere that gets into linux-next.
OK, it's here, mark with Success:
http://patchwork.ozlabs.org/project/linuxppc-dev/patch/2015925968.3546872.1685990936823.JavaMail.zimbra@raptorengineeringinc.com/
I don't know what happens to it next or when.
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
2023-06-15 16:34 ` Randy Dunlap
@ 2023-06-15 22:46 ` Christophe Leroy
0 siblings, 0 replies; 9+ messages in thread
From: Christophe Leroy @ 2023-06-15 22:46 UTC (permalink / raw)
To: Randy Dunlap, Timothy Pearson
Cc: Alexey Kardashevskiy, Stephen Rothwell, Linux Next Mailing List,
linuxppc-dev, linux-kernel
Le 15/06/2023 à 18:34, Randy Dunlap a écrit :
>
>
> On 6/15/23 09:13, Randy Dunlap wrote:
>>
>>
>> On 6/15/23 09:05, Timothy Pearson wrote:
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Randy Dunlap" <rdunlap@infradead.org>
>>>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "Michael Ellerman" <mpe@ellerman.id.au>
>>>> Cc: "Stephen Rothwell" <sfr@canb.auug.org.au>, "Linux Next Mailing List" <linux-next@vger.kernel.org>, "linux-kernel"
>>>> <linux-kernel@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>, "Alexey Kardashevskiy" <aik@ozlabs.ru>
>>>> Sent: Thursday, June 15, 2023 11:00:08 AM
>>>> Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
>>>
>>>> Hi Timothy,
>>>>
>>>> On 6/3/23 20:57, Timothy Pearson wrote:
>>>>>
>>>>>
>>>>> ----- Original Message -----
>>>>>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>>>>>> To: "Randy Dunlap" <rdunlap@infradead.org>, "Stephen Rothwell"
>>>>>> <sfr@canb.auug.org.au>, "Linux Next Mailing List"
>>>>>> <linux-next@vger.kernel.org>
>>>>>> Cc: "linux-kernel" <linux-kernel@vger.kernel.org>, "linuxppc-dev"
>>>>>> <linuxppc-dev@lists.ozlabs.org>, "Alexey
>>>>>> Kardashevskiy" <aik@ozlabs.ru>, "Timothy Pearson"
>>>>>> <tpearson@raptorengineering.com>
>>>>>> Sent: Saturday, June 3, 2023 7:22:51 PM
>>>>>> Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
>>>>>
>>>>>> Randy Dunlap <rdunlap@infradead.org> writes:
>>>>>>> On 6/1/23 21:01, Stephen Rothwell wrote:
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> Changes since 20230601:
>>>>>>>>
>>>>>>>
>>>>>>> On powerpc64, a randconfig failed with:
>>>>>>>
>>>>>>> In file included from ../include/linux/list.h:5,
>>>>>>> from ../include/linux/preempt.h:11,
>>>>>>> from ../include/linux/spinlock.h:56,
>>>>>>> from ../include/linux/mmzone.h:8,
>>>>>>> from ../include/linux/gfp.h:7,
>>>>>>> from ../include/linux/slab.h:15,
>>>>>>> from ../arch/powerpc/kernel/iommu.c:15:
>>>>>>> ../arch/powerpc/kernel/iommu.c: In function
>>>>>>> 'spapr_tce_setup_phb_iommus_initcall':
>>>>>>> ../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use
>>>>>>> in this function); did you mean 'zonelist'?
>>>>>>> 1391 | list_for_each_entry(hose, &hose_list, list_node) {
>>>>>>> | ^~~~~~~~~
>>>>>> ...
>>>>>>
>>>>>> hose_list is in pci-common.c which is built when PCI=y.
>>>>>>
>>>>>> PSERIES and POWERNV force PCI=y.
>>>>>>
>>>>>> But this config has neither:
>>>>>>
>>>>>> # CONFIG_PPC_POWERNV is not set
>>>>>> # CONFIG_PPC_PSERIES is not set
>>>>>> CONFIG_HAVE_PCI=y
>>>>>> # CONFIG_PCI is not set
>>>>>> # CONFIG_COMMON_CLK_RS9_PCIE is not set
>>>>>>
>>>>>>
>>>>>> Probably the spapr_tce code should be wrapped in an #ifdef that is only
>>>>>> enabled when POWERNV || PSERIES is enabled.
>>>>>>
>>>>>> cheers
>>>>>
>>>>> Sounds reasonable, I was going to look into this further over the weekend. I
>>>>> can put together a patch for Monday if that works?
>>>>
>>>> Did you prepare a patch for this? I am still seeing this build error.
>>>>
>>>> thanks.
>>>> --
>>>> ~Randy
>>>
>>> Yes, it was sent in to the linuxppc-dev list some weeks ago. Did it not arrive?
>>
>> I don't know - I'm not subscribed to that list.
>>
>> It's probably still in the patchworks review cycle
>> so it hasn't been applied anywhere that gets into linux-next.
>
> OK, it's here, mark with Success:
> http://patchwork.ozlabs.org/project/linuxppc-dev/patch/2015925968.3546872.1685990936823.JavaMail.zimbra@raptorengineeringinc.com/
>
> I don't know what happens to it next or when.
Is that supposed to fix anything ? I doesn't have any Fixes: tag
Christophe
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-06-15 22:47 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230602140143.0af52cee@canb.auug.org.au>
2023-06-02 20:56 ` linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c) Randy Dunlap
2023-06-04 0:22 ` Michael Ellerman
2023-06-04 3:57 ` Timothy Pearson
2023-06-04 21:55 ` Randy Dunlap
2023-06-15 16:00 ` Randy Dunlap
2023-06-15 16:05 ` Timothy Pearson
2023-06-15 16:13 ` Randy Dunlap
2023-06-15 16:34 ` Randy Dunlap
2023-06-15 22:46 ` Christophe Leroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).