From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1948BC7EE23 for ; Sun, 4 Jun 2023 21:56:36 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QZ9YZ4TTcz3dyB for ; Mon, 5 Jun 2023 07:56:34 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=1jblcwa+; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=rdunlap@infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QZ9XX32dtz3cjW for ; Mon, 5 Jun 2023 07:55:40 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=NUSwhZy1/res6awhW/S7wR5GlEYRXerBv2gBnZJoqgk=; b=1jblcwa+kVG/RLLzLxxruy/Dha 6cqd8127kzAxwgpGf4/0eSSSt0dHgm2fYBCy22Tva4wwOT2WSwohRSAjJ7H5zOa/fxrK/KbvYVaKP AU1JeZsf5RZVLizwWmoaceBBxeXysK+vH4FTFESUwMkIwZFlHSG9CjlMuaFXCZg9CK1yLPYmI3T6f 6odvsfZoixeHSfS1AT7OsbgC4BP/JkxAuwFrIXCZFxJIct0XPxmhooUnNCZa73+w9Z5WgnsOsL5Cx qJtAAEBAYtZ+YWk3iCKJS5nOsC5UTbJGR+JVEw7mVyCEL/BgGF6ga7KbwH1JGzrfeQb4zWrqRAN0M 2VskWFPQ==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1q5vhF-00DGFK-09; Sun, 04 Jun 2023 21:55:33 +0000 Message-ID: Date: Sun, 4 Jun 2023 14:55:32 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c) Content-Language: en-US To: Timothy Pearson , Michael Ellerman References: <20230602140143.0af52cee@canb.auug.org.au> <2d188c87-ef34-3812-7330-a985f756d959@infradead.org> <87h6rogjok.fsf@mail.lhotse> <586983120.3136676.1685851048873.JavaMail.zimbra@raptorengineeringinc.com> From: Randy Dunlap In-Reply-To: <586983120.3136676.1685851048873.JavaMail.zimbra@raptorengineeringinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Kardashevskiy , Stephen Rothwell , Linux Next Mailing List , linuxppc-dev , linux-kernel Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 6/3/23 20:57, Timothy Pearson wrote: > > > ----- Original Message ----- >> From: "Michael Ellerman" >> To: "Randy Dunlap" , "Stephen Rothwell" , "Linux Next Mailing List" >> >> Cc: "linux-kernel" , "linuxppc-dev" , "Alexey >> Kardashevskiy" , "Timothy Pearson" >> Sent: Saturday, June 3, 2023 7:22:51 PM >> Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c) > >> Randy Dunlap writes: >>> On 6/1/23 21:01, Stephen Rothwell wrote: >>>> Hi all, >>>> >>>> Changes since 20230601: >>>> >>> >>> On powerpc64, a randconfig failed with: >>> >>> In file included from ../include/linux/list.h:5, >>> from ../include/linux/preempt.h:11, >>> from ../include/linux/spinlock.h:56, >>> from ../include/linux/mmzone.h:8, >>> from ../include/linux/gfp.h:7, >>> from ../include/linux/slab.h:15, >>> from ../arch/powerpc/kernel/iommu.c:15: >>> ../arch/powerpc/kernel/iommu.c: In function >>> 'spapr_tce_setup_phb_iommus_initcall': >>> ../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use >>> in this function); did you mean 'zonelist'? >>> 1391 | list_for_each_entry(hose, &hose_list, list_node) { >>> | ^~~~~~~~~ >> ... >> >> hose_list is in pci-common.c which is built when PCI=y. >> >> PSERIES and POWERNV force PCI=y. >> >> But this config has neither: >> >> # CONFIG_PPC_POWERNV is not set >> # CONFIG_PPC_PSERIES is not set >> CONFIG_HAVE_PCI=y >> # CONFIG_PCI is not set >> # CONFIG_COMMON_CLK_RS9_PCIE is not set >> >> >> Probably the spapr_tce code should be wrapped in an #ifdef that is only >> enabled when POWERNV || PSERIES is enabled. >> >> cheers > > Sounds reasonable, I was going to look into this further over the weekend. I can put together a patch for Monday if that works? Works for me. Go for it. Thanks. -- ~Randy