From: Milton Miller <miltonm@bga.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: ppcdev <linuxppc-dev@ozlabs.org>, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/4] powerpc: Fix 32 bits mm operations when not using BATs
Date: Wed, 18 Apr 2007 03:58:16 -0500 [thread overview]
Message-ID: <daf73c54d92c0be4096aa40b4ae00fcd@bga.com> (raw)
In-Reply-To: <20070322030114.D5B9FDDF2B@ozlabs.org>
In commit ee4f2ea48674b6c9d91bc854edc51a3e6a7168c4 Ben patched:
> diff --git a/arch/powerpc/mm/pgtable_32.c
> b/arch/powerpc/mm/pgtable_32.c
> index 95d3afe..f75f2fc 100644
> --- a/arch/powerpc/mm/pgtable_32.c
> +++ b/arch/powerpc/mm/pgtable_32.c
> @@ -282,16 +282,19 @@ int map_page(unsigned long va, phys_addr_t pa,
> int flags)
...
> + ktext = ((char *) v >= _stext && (char *) v < etext);
> + f = ktext ?_PAGE_RAM_TEXT : _PAGE_RAM;
> map_page(v, p, f);
> +#ifdef CONFIG_PPC_STD_MMU_32
> + if (ktext)
> + hash_preload(&init_mm, v, 0, 0x300);
> +#endif
We should preload text pages with trap 0x400, ISI, aka an
instruction storage miss, not 0x300, data storage miss, to
avoid any confusion with looking at the trap vs PAGE_EXEC.
Sorry for not catching this until it was applied.
milton
prev parent reply other threads:[~2007-04-18 8:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-22 2:59 [PATCH 2/4] powerpc: Fix 32 bits mm operations when not using BATs Benjamin Herrenschmidt
2007-03-22 5:44 ` Benjamin Herrenschmidt
2007-03-22 11:55 ` Segher Boessenkool
2007-03-22 12:00 ` Benjamin Herrenschmidt
2007-03-22 12:01 ` Benjamin Herrenschmidt
2007-04-18 8:58 ` Milton Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daf73c54d92c0be4096aa40b4ae00fcd@bga.com \
--to=miltonm@bga.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).