From: Scott Wood <oss@buserror.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Michael Ellerman" <mpe@ellerman.id.au>
Cc: kernel@pengturonix.de, Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/3] powerpc/platforms/83xx/suspend: Prevent unloading the driver
Date: Fri, 15 Jul 2022 13:41:12 -0500 [thread overview]
Message-ID: <db14059bfc4f94e7e1812cdba5290da1ad420e92.camel@buserror.net> (raw)
In-Reply-To: <20220707061441.193869-2-u.kleine-koenig@pengutronix.de>
On Thu, 2022-07-07 at 08:14 +0200, Uwe Kleine-König wrote:
> Returning an error in .remove() doesn't prevent a driver from being
> unloaded. On unbind this only results in an error message, but the
> device is remove anyhow.
>
> I guess the author's idea of just returning -EPERM in .remove() was to
> prevent unbinding a device. To achieve that set the suppress_bind_attrs
> driver property and drop the useless .remove callback.
I don't remember if I thought it would prevent removal, or if it was just the
only thing I could do to signal that removing it would be a bad idea (albeit
of relatively little consequence since it can't be built as a module).
suppress_bind_attrs didn't exist back then. :-)
In any case,
Acked-by: Scott Wood <oss@buserror.net>
-Scott
next prev parent reply other threads:[~2022-07-15 19:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 6:14 [PATCH 1/3] powerpc/platforms/83xx/suspend: Reorder to get rid of a forward declaration Uwe Kleine-König
2022-07-07 6:14 ` [PATCH 2/3] powerpc/platforms/83xx/suspend: Prevent unloading the driver Uwe Kleine-König
2022-07-07 8:44 ` Christophe Leroy
2022-07-15 18:41 ` Scott Wood [this message]
2022-07-07 6:14 ` [PATCH 3/3] powerpc/platforms/83xx/suspend: Remove write-only global variable Uwe Kleine-König
2022-07-07 8:49 ` Christophe Leroy
2022-07-07 8:43 ` [PATCH 1/3] powerpc/platforms/83xx/suspend: Reorder to get rid of a forward declaration Christophe Leroy
2022-07-29 13:03 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db14059bfc4f94e7e1812cdba5290da1ad420e92.camel@buserror.net \
--to=oss@buserror.net \
--cc=kernel@pengturonix.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).