From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] powerpc/ptdump: fix addresses display on PPC32
Date: Wed, 14 Aug 2019 14:51:27 +0200 [thread overview]
Message-ID: <db36b9fe-e9f8-0007-ff87-03ac6ae87a8b@c-s.fr> (raw)
In-Reply-To: <eb4d626514e22f85814830012642329018ef6af9.1565786091.git.christophe.leroy@c-s.fr>
Michael,
Le 14/08/2019 à 14:36, Christophe Leroy a écrit :
> Commit 453d87f6a8ae ("powerpc/mm: Warn if W+X pages found on boot")
> wrongly changed KERN_VIRT_START from 0 to PAGE_OFFSET, leading to a
> shift in the displayed addresses.
>
> Lets revert that change to resync walk_pagetables()'s addr val and
> pgd_t pointer for PPC32.
>
> Fixes: 453d87f6a8ae ("powerpc/mm: Warn if W+X pages found on boot")
Either this patch or patch 2 of the series has to go into fixes.
If you prefer next patch for fixes, then this one can be squashed into
patch 3 which drops the PPC32 hacked definition of KERN_VIRT_START
Christophe
> Cc: stable@vger.kernel.org
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> arch/powerpc/mm/ptdump/ptdump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/ptdump/ptdump.c b/arch/powerpc/mm/ptdump/ptdump.c
> index 6a88a9f585d4..3ad64fc11419 100644
> --- a/arch/powerpc/mm/ptdump/ptdump.c
> +++ b/arch/powerpc/mm/ptdump/ptdump.c
> @@ -27,7 +27,7 @@
> #include "ptdump.h"
>
> #ifdef CONFIG_PPC32
> -#define KERN_VIRT_START PAGE_OFFSET
> +#define KERN_VIRT_START 0
> #endif
>
> /*
>
next prev parent reply other threads:[~2019-08-14 12:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 12:36 [PATCH 1/5] powerpc/ptdump: fix addresses display on PPC32 Christophe Leroy
2019-08-14 12:36 ` [PATCH 2/5] powerpc/ptdump: fix walk_pagetables() address mismatch Christophe Leroy
2019-08-14 12:36 ` [PATCH 3/5] powerpc/ptdump: drop dummy KERN_VIRT_START on PPC32 Christophe Leroy
2019-08-14 12:36 ` [PATCH 4/5] powerpc/ptdump: get out of note_prot_wx() when CONFIG_PPC_DEBUG_WX is not selected Christophe Leroy
2019-08-14 12:36 ` [PATCH 5/5] powerpc/ptdump: drop non vital #ifdefs Christophe Leroy
2019-08-14 12:51 ` Christophe Leroy [this message]
2019-08-22 13:09 ` [PATCH 1/5] powerpc/ptdump: fix addresses display on PPC32 Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db36b9fe-e9f8-0007-ff87-03ac6ae87a8b@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox