From: Christian Zigotzky <chzigotzky@xenosoft.de>
To: Bjorn Helgaas <helgaas@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Olof Johansson <olof@lixom.net>
Subject: [PATCH 0/1] PCI set flag PCI_SCAN_ALL_PCIE_DEVS for P.A. Semi boards
Date: Fri, 16 Mar 2018 13:10:43 +0100 [thread overview]
Message-ID: <dc228918-652a-e24c-ce7b-8d1b30153d3b@xenosoft.de> (raw)
In-Reply-To: <20171201232716.GA18780@bhelgaas-glaptop.roam.corp.google.com>
On 02 December 2017 at 00:27PM, Bjorn Helgaas wrote:
> On Fri, Dec 01, 2017 at 11:08:46PM +0100, Christian Zigotzky wrote:
>> On 30.11.2017 23:42, Bjorn Helgaas wrote:
>>>
>>> 00:11.0 claims to be a PCIe Root Port leading to [bus 05-06]. That
>>> means there's a Link (presumably this A-Link II Express thing), and the
>>> downstream end of the Link *should* be a PCIe Upstream Port on bus 05,
>>> but no such device is visible. I suppose the SB600 does implement
>>> some sort of PCIe Port there, but keeps it invisible to software, and
>>> at the same time, contains an invisible bridge that connects the Link
>>> to all the conventional PCI devices on bus 05.
>>>
>>> When we scan bus 05, we do this:
>>>
>>> pci_scan_child_bus_extend(bus=05)
>>> for (devfn = 0; devfn < 0x100; devfn += 8)
>>> pci_scan_slot(05, 00.0)
>>> pci_scan_single_device
>>> pci_scan_device(05, 00.0) # fails; no 05:00.0
>>> pci_scan_slot(05, 01.0)
>>> only_one_child(bus=05)
>>> parent = 00:11.0
>>> pci_pcie_type(00:11.0) == ROOT_PORT # returns true
>>>
>>> Since only_one_child() sees that 00:11.0 is a Root Port, we give up
>>> before we even get to the PCI_SCAN_ALL_PCIE_DEVS test.
>>>
>>> I *think* something like the patch below should make this work if you
>>> use the "pci=pcie_scan_all" parameter. We have some x86 DMI quirks
>>> that set PCI_SCAN_ALL_PCIE_DEVS automatically. I don't know how to do
>>> something similar on powerpc, but maybe you do?
>>>
>>
>> Hi Bjorn,
>>
>> I tested your new patch today. It boots with the boot argument
>> "pci=pcie_scan_all". Well done! :-)
>>
>> It doesn't boot without the boot argument "pci=pcie_scan_all".
>
> Thanks for testing that. I'll merge a similar patch for v4.16.
>
> I don't think using "pci=pcie_scan_all" is really an acceptable
> long-term answer for you, though. Is there some way we can identify
> at run-time whether we're on a Nemo system? If so, we can make this
> happen automatically.
>
> Bjorn
>
Hi Bjorn,
Hi All,
Olof Johansson has created a patch for us. With this patch,
"pci=pcie_scan_all" executes automatically on P.A. Semi boards. We don't
need to add 'pci=pcie_scan_all' to the
kernel boot arguments anymore. Could you please add Olof's patch to the
official kernel source code?
arch/powerpc/platforms/pasemi/pci.c | 2 ++
1 file changed, 2 insertions(+)
Thanks,
Christian
next prev parent reply other threads:[~2018-03-16 12:10 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 7:47 [PATCH] SB600 for the Nemo board has non-zero devices on non-root bus Christian Zigotzky
2017-11-23 13:31 ` Michael Ellerman
2017-11-29 19:28 ` Christian Zigotzky
2017-11-29 19:46 ` Bjorn Helgaas
2017-11-29 20:45 ` Christian Zigotzky
2017-11-29 22:34 ` Bjorn Helgaas
2017-11-29 23:39 ` Christian Zigotzky
2017-11-30 22:42 ` Bjorn Helgaas
2017-12-01 22:08 ` Christian Zigotzky
2017-12-01 23:27 ` Bjorn Helgaas
2017-12-02 12:54 ` Christian Zigotzky
2017-12-02 23:00 ` Olof Johansson
2017-12-02 23:02 ` Olof Johansson
2017-12-03 9:43 ` Christian Zigotzky
2017-12-06 8:37 ` Christian Zigotzky
2017-12-06 11:03 ` Christian Zigotzky
2017-12-06 12:57 ` Michael Ellerman
2017-12-06 21:06 ` Bjorn Helgaas
2017-12-08 11:59 ` Michael Ellerman
2017-12-09 18:03 ` Christian Zigotzky
2017-12-15 8:04 ` Christian Zigotzky
2017-12-15 20:25 ` Bjorn Helgaas
2017-12-16 7:18 ` Christian Zigotzky
2017-12-22 9:57 ` Christian Zigotzky
2017-12-22 10:22 ` Christian Zigotzky
2017-12-22 11:19 ` Michael Ellerman
2017-12-22 12:11 ` Christian Zigotzky
2018-06-04 14:10 ` Michael Ellerman
2017-12-06 12:44 ` [PATCH] " Michael Ellerman
2017-12-06 15:53 ` Olof Johansson
2017-12-08 11:57 ` Michael Ellerman
2018-03-16 12:10 ` Christian Zigotzky [this message]
2018-03-16 12:55 ` [PATCH 1/1] PCI set flag PCI_SCAN_ALL_PCIE_DEVS for P.A. Semi boards Christian Zigotzky
2018-03-19 19:13 ` Bjorn Helgaas
2018-03-19 20:46 ` Christian Zigotzky
2018-03-19 22:32 ` Michael Ellerman
2018-03-21 6:44 ` Christian Zigotzky
2018-03-25 20:55 ` Darren Stevens
2018-04-16 4:29 ` [PATCH 1/1] " Christian Zigotzky
2017-12-04 11:40 ` SB600 for the Nemo board has non-zero devices on non-root bus Darren Stevens
2017-12-04 13:31 ` Christian Zigotzky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc228918-652a-e24c-ce7b-8d1b30153d3b@xenosoft.de \
--to=chzigotzky@xenosoft.de \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).