From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D601DC282DD for ; Thu, 23 May 2019 18:59:31 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 085D221773 for ; Thu, 23 May 2019 18:59:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="dJuJaIP9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 085D221773 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 458zM42xpXzDqc5 for ; Fri, 24 May 2019 04:59:28 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=c-s.fr (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@c-s.fr; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=c-s.fr header.i=@c-s.fr header.b="dJuJaIP9"; dkim-atps=neutral Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 458zKj2jBdzDqWm for ; Fri, 24 May 2019 04:58:17 +1000 (AEST) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 458zKd3HMlzB09Zg; Thu, 23 May 2019 20:58:13 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=dJuJaIP9; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id uerfZO1uIocw; Thu, 23 May 2019 20:58:13 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 458zKd20PmzB09Zf; Thu, 23 May 2019 20:58:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1558637893; bh=/pJKg62Qcc7neDqGxc6BXb9I0aurpmtVSccNASUHRI0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=dJuJaIP9S9dlQCOcNfUe0l057Y1+FA/bbTmVtpyrsJiiLhso3ah/GSy55EGpnA1l6 W2/aLhqVRkIZgHC9TfMEji7kWaZuZDIB8FnAv30dF11/wwcNbKH81Ve1KlOq7tr4TX LKepxwKV/weTlthSb/uDFsoV9+AHhvFf/zi2hJ48= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 545F88B875; Thu, 23 May 2019 20:58:13 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id piQvM3Hqxltm; Thu, 23 May 2019 20:58:13 +0200 (CEST) Received: from PO15451 (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 1DB828B869; Thu, 23 May 2019 20:58:12 +0200 (CEST) Subject: Re: [BISECTED] kexec regression on PowerBook G4 To: Aaro Koskinen References: <20190521221859.GC3621@darkstar.musicnaut.iki.fi> <90f3557b-400b-60b5-9ff8-d5605adeee79@c-s.fr> <20190522201310.GB456@darkstar.musicnaut.iki.fi> <20190522223335.Horde.JIF8kbX8AwL8wErArEvEcg1@messagerie.si.c-s.fr> <20190522211724.GC456@darkstar.musicnaut.iki.fi> <20190523172717.GA5234@darkstar.musicnaut.iki.fi> From: Christophe Leroy Message-ID: Date: Thu, 23 May 2019 20:58:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190523172717.GA5234@darkstar.musicnaut.iki.fi> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 23/05/2019 à 19:27, Aaro Koskinen a écrit : > Hi, > > On Thu, May 23, 2019 at 07:33:38AM +0200, Christophe Leroy wrote: >> Ok, the Oops confirms that the error is due to executing the kexec control >> code which is located outside the kernel text area. >> >> My yesterday's proposed change doesn't work because on book3S/32, NX >> protection is based on setting segments to NX, and using IBATs for kernel >> text. >> >> Can you try the patch I sent out a few minutes ago ? >> (https://patchwork.ozlabs.org/patch/1103827/) > > It now crashes with "BUG: Unable to handle kernel instruction fetch" > and the faulting address is 0xef13a000. > Ok. Can you try with both changes at the same time, ie the mtsrin(...) and the change_page_attr() ? I suspect that allthough the HW is not able to check EXEC flag, the SW will check it before loading the hash entry. Christophe