From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE434C43331 for ; Fri, 3 Apr 2020 14:44:33 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CC9820675 for ; Fri, 3 Apr 2020 14:44:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="LdgOBpgV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CC9820675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48v2l31YnjzDqjh for ; Sat, 4 Apr 2020 01:44:31 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=c-s.fr (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@c-s.fr; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=c-s.fr header.i=@c-s.fr header.a=rsa-sha256 header.s=mail header.b=LdgOBpgV; dkim-atps=neutral Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48v2VP6s0ZzDqgS for ; Sat, 4 Apr 2020 01:33:33 +1100 (AEDT) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 48v2VJ02pqz9vBTZ; Fri, 3 Apr 2020 16:33:28 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=LdgOBpgV; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id qohEeScBKu3E; Fri, 3 Apr 2020 16:33:27 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 48v2VH5l7Wz9vBTX; Fri, 3 Apr 2020 16:33:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1585924407; bh=YHfep6fRmWTQ628Du5m3Bj55eqaX1GQfXJKDyD5Kf6M=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=LdgOBpgVDFdabeMJxsuYBTxXHXQpVaX6EIwd1SgXc1UIMxzw9oO7aUpO9XVYr8Qz4 ZUCufbF5X5UCYSj3k4WpLRK117FcYEizagCS4RWIqS+GNzG59gZOGDyoyErb0d1sy/ MNoxGZHNZEoRDRiMg37wiUj4r0skB8Qq39I56oHk= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 14BB18B956; Fri, 3 Apr 2020 16:33:29 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id v7wnzdwVjQyx; Fri, 3 Apr 2020 16:33:29 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 5E0E68B951; Fri, 3 Apr 2020 16:33:28 +0200 (CEST) Subject: Re: [PATCH v2 06/14] powerpc/pseries/ras: FWNMI_VALID off by one To: Nicholas Piggin , linuxppc-dev@lists.ozlabs.org References: <20200403132622.130394-1-npiggin@gmail.com> <20200403132622.130394-7-npiggin@gmail.com> From: Christophe Leroy Message-ID: Date: Fri, 3 Apr 2020 16:33:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200403132622.130394-7-npiggin@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mahesh Salgaonkar , Ganesh Goudar , Mahesh Salgaonkar Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 03/04/2020 à 15:26, Nicholas Piggin a écrit : > This was discovered developing qemu fwnmi sreset support. This > off-by-one bug means the last 16 bytes of the rtas area can not > be used for a 16 byte save area. > > It's not a serious bug, and QEMU implementation has to retain a > workaround for old kernels, but it's good to tighten it. > > Acked-by: Mahesh Salgaonkar > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/platforms/pseries/ras.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c > index c74d5e740922..9a37bda47468 100644 > --- a/arch/powerpc/platforms/pseries/ras.c > +++ b/arch/powerpc/platforms/pseries/ras.c > @@ -395,10 +395,11 @@ static irqreturn_t ras_error_interrupt(int irq, void *dev_id) > /* > * Some versions of FWNMI place the buffer inside the 4kB page starting at > * 0x7000. Other versions place it inside the rtas buffer. We check both. > + * Minimum size of the buffer is 16 bytes. > */ > #define VALID_FWNMI_BUFFER(A) \ > - ((((A) >= 0x7000) && ((A) < 0x7ff0)) || \ > - (((A) >= rtas.base) && ((A) < (rtas.base + rtas.size - 16)))) > + ((((A) >= 0x7000) && ((A) <= 0x8000 - 16)) || \ > + (((A) >= rtas.base) && ((A) <= (rtas.base + rtas.size - 16)))) Why not just change < to <= and leave the 0x7ff0 ? > > static inline struct rtas_error_log *fwnmi_get_errlog(void) > { > Christophe