From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in-13.arcor-online.net (mail-in-13.arcor-online.net [151.189.21.53]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.arcor.de", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 8936FDDE45 for ; Mon, 4 Jun 2007 18:41:13 +1000 (EST) In-Reply-To: <1180945726.10048.0.camel@localhost.localdomain> References: <1180406209.8139.13.camel@localhost.localdomain> <1180492466.12577.6.camel@localhost.localdomain> <1180503967.12577.20.camel@localhost.localdomain> <19325B38-202C-4837-9BE8-0ACA482F2605@kernel.crashing.org> <976AFF56-7590-46B9-ADCA-4FA6673D4C9B@kernel.crashing.org> <1180945726.10048.0.camel@localhost.localdomain> Mime-Version: 1.0 (Apple Message framework v623) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: From: Segher Boessenkool Subject: Re: [PATCH v2]: Fix e500 v2 core reboot bug Date: Mon, 4 Jun 2007 10:41:07 +0200 To: Zang Roy-r61911 Cc: linuxppc-dev list , Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , >> After some discussion on IRC I think the following is the suggested >> node we should add in. >> >> guts@e00000 { >> compatible = "fsl,mpc8548-guts"; >> reg = ; > one more zero! Yeah. >> fsl,has-rstcr; >> }; If "guts" is some kind of official name (i.e., the block is called that in the user manual), it looks okay to me. Otherwise, please change; in fact, just change the name anyway (not the compatible), to "shared-soc-regs" or something like that; "name" should be descriptive (but terse). Segher