From: Milton Miller <miltonm@bga.com>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: ppcdev <linuxppc-dev@ozlabs.org>
Subject: Re: [patch 5/6] ps3: ROM Storage Driver
Date: Wed, 20 Jun 2007 07:16:33 -0500 [thread overview]
Message-ID: <dcf4c6884c22627387c1ccf4a04158e3@bga.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0706191405190.4069@pademelon.sonytel.be>
On Jun 19, 2007, at 7:29 AM, Geert Uytterhoeven wrote:
> On Mon, 18 Jun 2007, Milton Miller wrote:
>>> +config PS3_ROM
>>> + tristate "PS3 ROM Storage Driver"
>>> + depends on PPC_PS3 && BLK_DEV_SR
>>> + select PS3_STORAGE
>>> + help
>>> + Include support for the PS3 ROM Storage.
>>> +
>>> + This support is required to access the PS3 BD/DVD/CD-ROM drive.
>>> + In general, all users will say Y or M.
>>> +
>>
>> Why does it depend on BLK_DEV_SR?
>
> Because it needs SCSI CD-ROM support.
>
To compile? I don't see any exports there.
My point is if it only relies on it to produce the device node, then
you should provide guidance in your help text but not make the module
build dependent on it.
milton
next prev parent reply other threads:[~2007-06-20 12:16 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-15 11:39 [patch 0/6] PS3 Storage Drivers for 2.6.23, take 2 Geert Uytterhoeven
2007-06-15 11:39 ` [patch 1/6] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver Geert Uytterhoeven
2007-06-15 13:27 ` Benjamin Herrenschmidt
2007-06-15 13:32 ` Geert Uytterhoeven
2007-06-18 16:25 ` [patch 1/6] ps3: Preallocate bootmem memory for the PS3 FLASH Milton Miller
2007-06-19 11:36 ` Geert Uytterhoeven
2007-06-15 11:39 ` [patch 2/6] ps3: Storage Driver Core Geert Uytterhoeven
2007-06-15 11:39 ` [patch 3/6] PS3: Storage device registration routines Geert Uytterhoeven
2007-06-15 11:39 ` [patch 4/6] ps3: Disk Storage Driver Geert Uytterhoeven
2007-06-15 14:35 ` David Woodhouse
2007-06-15 14:41 ` Arnd Bergmann
2007-06-15 14:43 ` Geert Uytterhoeven
2007-06-15 16:15 ` Alan Cox
2007-06-15 18:05 ` Geert Uytterhoeven
2007-06-15 21:19 ` David Miller
2007-06-15 22:40 ` James Bottomley
2007-06-15 23:08 ` David Miller
2007-06-15 23:28 ` James Bottomley
2007-06-15 23:37 ` David Miller
2007-06-19 5:56 ` Christoph Hellwig
2007-06-19 6:07 ` David Miller
2007-06-19 8:15 ` Christoph Hellwig
2007-06-15 23:11 ` Alan Cox
2007-06-16 6:21 ` Geert Uytterhoeven
2007-06-19 5:53 ` Christoph Hellwig
2007-06-19 6:03 ` David Miller
2007-06-19 7:06 ` Geert Uytterhoeven
2007-06-15 21:17 ` David Miller
2007-06-15 21:28 ` Jeff Garzik
2007-06-15 21:37 ` David Miller
2007-06-15 21:50 ` Jeff Garzik
2007-06-15 21:55 ` David Miller
2007-06-19 5:43 ` Christoph Hellwig
2007-06-19 12:51 ` Geert Uytterhoeven
2007-06-19 17:19 ` Christoph Hellwig
2007-06-15 11:39 ` [patch 5/6] ps3: ROM " Geert Uytterhoeven
2007-06-18 16:30 ` Milton Miller
2007-06-19 5:44 ` Christoph Hellwig
2007-06-19 12:29 ` Geert Uytterhoeven
2007-06-20 12:16 ` Milton Miller [this message]
2007-06-19 5:51 ` Christoph Hellwig
2007-06-15 11:39 ` [patch 6/6] ps3: FLASH " Geert Uytterhoeven
2007-06-18 16:30 ` Milton Miller
2007-06-19 12:02 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcf4c6884c22627387c1ccf4a04158e3@bga.com \
--to=miltonm@bga.com \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).