From: Randy Dunlap <rdunlap@infradead.org>
To: Herve Codina <herve.codina@bootlin.com>,
Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2 1/2] soc: fsl: cpm1: Fix TSA and QMC dependencies in case of COMPILE_TEST
Date: Thu, 25 May 2023 09:26:55 -0700 [thread overview]
Message-ID: <dd0e4fac-16ef-5ca6-db8d-21ecf1c0e802@infradead.org> (raw)
In-Reply-To: <20230523085902.75837-2-herve.codina@bootlin.com>
On 5/23/23 01:59, Herve Codina wrote:
> In order to compile tsa.c and qmc.c, CONFIG_CPM must be set.
>
> Without this dependency, the linker fails with some missing
> symbols for COMPILE_TEST configurations that need QMC without
> enabling CPM.
>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202305160221.9XgweObz-lkp@intel.com/
Fixes all of my CPM build issues. (with patch 2/2 also applied)
Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> ---
> drivers/soc/fsl/qe/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig
> index 7268c2fbcbc1..e0d096607fef 100644
> --- a/drivers/soc/fsl/qe/Kconfig
> +++ b/drivers/soc/fsl/qe/Kconfig
> @@ -36,7 +36,7 @@ config UCC
> config CPM_TSA
> tristate "CPM TSA support"
> depends on OF && HAS_IOMEM
> - depends on CPM1 || COMPILE_TEST
> + depends on CPM1 || (CPM && COMPILE_TEST)
> help
> Freescale CPM Time Slot Assigner (TSA)
> controller.
> @@ -47,7 +47,7 @@ config CPM_TSA
> config CPM_QMC
> tristate "CPM QMC support"
> depends on OF && HAS_IOMEM
> - depends on CPM1 || (FSL_SOC && COMPILE_TEST)
> + depends on CPM1 || (FSL_SOC && CPM && COMPILE_TEST)
> depends on CPM_TSA
> help
> Freescale CPM QUICC Multichannel Controller
--
~Randy
next prev parent reply other threads:[~2023-05-25 16:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 8:59 [PATCH v2 0/2] Fix COMPILE_TEST dependencies for CPM uart, TSA and QMC Herve Codina
2023-05-23 8:59 ` [PATCH v2 1/2] soc: fsl: cpm1: Fix TSA and QMC dependencies in case of COMPILE_TEST Herve Codina
2023-05-25 16:26 ` Randy Dunlap [this message]
2023-05-23 8:59 ` [PATCH v2 2/2] serial: cpm_uart: Fix a COMPILE_TEST dependency Herve Codina
2023-05-23 9:13 ` Jiri Slaby
2023-05-23 9:27 ` Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd0e4fac-16ef-5ca6-db8d-21ecf1c0e802@infradead.org \
--to=rdunlap@infradead.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=herve.codina@bootlin.com \
--cc=jirislaby@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=qiang.zhao@nxp.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).