From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xR2xz5SybzDqkF for ; Tue, 8 Aug 2017 02:27:51 +1000 (AEST) Subject: Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init() To: Geoff Levand , linuxppc-dev@lists.ozlabs.org Cc: Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , LKML , kernel-janitors@vger.kernel.org References: From: SF Markus Elfring Message-ID: Date: Mon, 7 Aug 2017 18:27:04 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , >> Omit an extra message for a memory allocation failure in this function. >> >> This issue was detected by using the Coccinelle software. > > NACK > > When a user asks me for help I would certainly like to get > 'Could not allocate cache tags' as apposed to nothing, Do you find the default allocation failure report insufficient? > since the return value of ps3vram_cache_init() is not checked. Are there any more update candidates to consider for better exception handling? Regards, Markus