From: Dan Malek <dan@embeddededge.com>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linuxppc-embedded list <linuxppc-embedded@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] ppc32: 8xx board-specific platform stuff for fs_enet
Date: Wed, 23 Nov 2005 15:18:17 -0500 [thread overview]
Message-ID: <ddea89e58026c4f55f1a05af602cba60@embeddededge.com> (raw)
In-Reply-To: <20051123120033.GA3551@logos.cnet>
On Nov 23, 2005, at 7:00 AM, Marcelo Tosatti wrote:
> The files in arch/ppc/8xx_io/ (which is what I think you refer to as
> candidates for drivers/), are:
I don't particularly like these macros, but I'm tired of fighting
about it. If you follow the usage path, you will see it's only
used in the CPM drivers, and I wish people would just use
the data structure pointers to access these ports/bits with
standard C code and then place any synchronization
instructions properly. There are some cases where you
have to be quite careful about how you read and write
some control registers, and I think this opens the possibility
to just be sloppy and make mistakes since the read/write
is hidden within the macro.
> Does anyone have hardware to test it? Dan?
Yes, I have hardware to test it. I will do that one of these days.
Thanks.
-- Dan
next prev parent reply other threads:[~2005-11-23 20:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-16 12:04 [PATCH] ppc32: 8xx board-specific platform stuff for fs_enet Vitaly Bordug
2005-11-17 13:58 ` Marcelo Tosatti
2005-11-18 14:09 ` Vitaly Bordug
2005-11-18 9:08 ` Marcelo Tosatti
2005-11-23 2:40 ` Paul Mackerras
2005-11-23 9:11 ` Marcelo Tosatti
2005-11-23 16:05 ` Kumar Gala
2005-11-23 12:00 ` Marcelo Tosatti
2005-11-23 18:25 ` 'Aristeu Sergio Rozanski Filho'
2005-11-23 20:18 ` Dan Malek [this message]
2005-11-23 15:39 ` Marcelo Tosatti
2005-11-30 7:08 ` Kumar Gala
2005-12-01 12:17 ` Marcelo Tosatti
2005-12-01 14:15 ` Dan Malek
2005-12-01 15:13 ` Kumar Gala
2005-11-23 16:14 ` Vitaly Bordug
2005-11-17 14:07 ` Marcelo Tosatti
2005-11-18 14:11 ` Vitaly Bordug
2005-11-18 9:05 ` Marcelo Tosatti
-- strict thread matches above, loose matches on Subject: below --
2005-11-18 16:19 Vitaly Bordug
2005-11-23 8:34 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddea89e58026c4f55f1a05af602cba60@embeddededge.com \
--to=dan@embeddededge.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).