From: David Hildenbrand <david@redhat.com>
To: Hari Bathini <hbathini@linux.ibm.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org
Cc: mike.kravetz@oracle.com, mahesh@linux.ibm.com,
sourabhjain@linux.ibm.com, osalvador@suse.de
Subject: Re: [PATCH v2 1/2] mm/cma: provide option to opt out from exposing pages on activation failure
Date: Thu, 13 Jan 2022 09:30:57 +0100 [thread overview]
Message-ID: <debd11c4-4a7a-e650-7bc6-965d58ef95cf@redhat.com> (raw)
In-Reply-To: <20220112193340.149020-2-hbathini@linux.ibm.com>
> +{
> + if (!cma)
> + return;
Do we really need that check for NULL?
> +
> + cma->reserve_pages_on_error = true;
> +}
> +
> /**
> * cma_init_reserved_mem() - create custom contiguous area from reserved memory
> * @base: Base address of the reserved area
> @@ -204,6 +214,7 @@ int __init cma_init_reserved_mem(phys_addr_t base, phys_addr_t size,
> cma->base_pfn = PFN_DOWN(base);
> cma->count = size >> PAGE_SHIFT;
> cma->order_per_bit = order_per_bit;
> + cma->reserve_pages_on_error = false;
I think you can drop that; should already be initialized to 0.
Apart from that
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-01-13 8:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 19:33 [PATCH v2 0/2] powerpc/fadump: handle CMA activation failure appropriately Hari Bathini
2022-01-12 19:33 ` [PATCH v2 1/2] mm/cma: provide option to opt out from exposing pages on activation failure Hari Bathini
2022-01-13 8:30 ` David Hildenbrand [this message]
2022-01-17 7:59 ` Hari Bathini
2022-01-12 19:33 ` [PATCH v2 2/2] powerpc/fadump: opt out from freeing pages on cma " Hari Bathini
2022-01-13 8:31 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=debd11c4-4a7a-e650-7bc6-965d58ef95cf@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hbathini@linux.ibm.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=mike.kravetz@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=osalvador@suse.de \
--cc=sourabhjain@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).