From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Geoff Levand <geoff@infradead.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment
Date: Wed, 18 Mar 2026 12:54:30 +0100 [thread overview]
Message-ID: <dfb53d65-ee34-47bf-b305-5694c7224ec7@oss.qualcomm.com> (raw)
In-Reply-To: <abqRvDiAI85w2bCe@gate>
On 18/03/2026 12:51, Segher Boessenkool wrote:
> On Tue, Mar 17, 2026 at 02:08:24PM +0100, Krzysztof Kozlowski wrote:
>> Return value of ps3_start_probe_thread() is not used, so code can be
>> simplified to fix W=1 clang warnings:
>>
>> arch/powerpc/platforms/ps3/device-init.c:953:6: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable]
>
> And this is exactly why -Werror is harmful. A boring harmless warning
> turned into a build break :-(
-Werror does not matter here. We do not want warnings either, assuming
of course they are correct.
So if this warning is correct, then patch should be applied and WERROR
is irrelevant.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-18 11:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 13:08 [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment Krzysztof Kozlowski
2026-03-17 13:08 ` [PATCH RESEND 2/2] powerpc/pasemi: Drop redundant res assignment Krzysztof Kozlowski
2026-03-17 14:32 ` [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment Geert Uytterhoeven
2026-03-18 11:51 ` Segher Boessenkool
2026-03-18 11:54 ` Krzysztof Kozlowski [this message]
2026-03-18 11:58 ` Segher Boessenkool
2026-03-18 12:03 ` Krzysztof Kozlowski
2026-03-18 12:12 ` Segher Boessenkool
2026-03-18 14:59 ` Krzysztof Kozlowski
2026-03-18 12:21 ` Christophe Leroy (CS GROUP)
2026-03-18 15:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfb53d65-ee34-47bf-b305-5694c7224ec7@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=chleroy@kernel.org \
--cc=geoff@infradead.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=maddy@linux.ibm.com \
--cc=morbo@google.com \
--cc=mpe@ellerman.id.au \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=npiggin@gmail.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox