From: Balbir Singh <bsingharora@gmail.com>
To: Reza Arbab <arbab@linux.vnet.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@samba.org>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Morton <akpm@linux-foundation.org>,
Bharata B Rao <bharata@linux.vnet.ibm.com>,
Nathan Fontenot <nfont@linux.vnet.ibm.com>,
Stewart Smith <stewart@linux.vnet.ibm.com>,
Alistair Popple <apopple@au1.ibm.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v3 4/5] powerpc/mm: restore top-down allocation when using movable_node
Date: Tue, 4 Oct 2016 11:48:30 +1100 [thread overview]
Message-ID: <e161a34e-4e58-42f5-49ed-3e7913189eb9@gmail.com> (raw)
In-Reply-To: <20160927001413.o72fqpfsnsxpu5qq@arbab-laptop>
On 27/09/16 10:14, Reza Arbab wrote:
> On Tue, Sep 27, 2016 at 07:12:31AM +1000, Benjamin Herrenschmidt wrote:
>> In any case, if the memory hasn't been hotplug, this shouldn't be necessary as we shouldn't be considering it for allocation.
>
> Right. To be clear, the background info I put in the commit log refers to x86, where the SRAT can describe movable nodes which exist at boot. They're trying to avoid allocations from those nodes before they've been identified.
>
> On power, movable nodes can only exist via hotplug, so that scenario can't happen. We can immediately go back to top-down allocation. That is the missing call being added in the patch.
>
Can we fix cmdline_parse_movable_node() to do the right thing? I suspect that
code is heavily x86 only in the sense that no other arch needs it.
Balbir Singh.
next prev parent reply other threads:[~2016-10-04 0:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 18:36 [PATCH v3 0/5] powerpc/mm: movable hotplug memory nodes Reza Arbab
2016-09-25 18:36 ` [PATCH v3 1/5] drivers/of: introduce of_fdt_is_available() Reza Arbab
2016-10-03 15:28 ` Rob Herring
2016-09-25 18:36 ` [PATCH v3 2/5] drivers/of: do not add memory for unavailable nodes Reza Arbab
2016-09-25 18:36 ` [PATCH v3 3/5] powerpc/mm: allow memory hotplug into a memoryless node Reza Arbab
2016-09-25 18:36 ` [PATCH v3 4/5] powerpc/mm: restore top-down allocation when using movable_node Reza Arbab
2016-09-26 15:47 ` Aneesh Kumar K.V
2016-09-26 20:48 ` Reza Arbab
2016-09-26 21:12 ` Benjamin Herrenschmidt
2016-09-27 0:14 ` Reza Arbab
2016-10-04 0:48 ` Balbir Singh [this message]
2016-10-04 20:23 ` Reza Arbab
2016-09-25 18:36 ` [PATCH v3 5/5] mm: enable CONFIG_MOVABLE_NODE on powerpc Reza Arbab
2016-09-26 15:48 ` Aneesh Kumar K.V
2016-09-26 21:15 ` Benjamin Herrenschmidt
2016-09-27 0:19 ` Reza Arbab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e161a34e-4e58-42f5-49ed-3e7913189eb9@gmail.com \
--to=bsingharora@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=apopple@au1.ibm.com \
--cc=arbab@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bharata@linux.vnet.ibm.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nfont@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=robh+dt@kernel.org \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).