From: Paolo Bonzini <pbonzini@redhat.com>
To: Joe Perches <joe@perches.com>, Paul Mackerras <paulus@ozlabs.org>
Cc: kvm-ppc@vger.kernel.org,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
Ram Pai <linuxram@us.ibm.com>,
linux-kernel@vger.kernel.org,
Sean Christopherson <sean.j.christopherson@intel.com>,
Bharata B Rao <bharata@linux.ibm.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Nicholas Piggin <npiggin@gmail.com>,
Laurent Dufour <ldufour@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/4] KVM: PPC: Book3S HV: Make struct kernel_param_ops definition const
Date: Mon, 19 Oct 2020 18:01:15 +0200 [thread overview]
Message-ID: <e1945b90-c97c-f998-56b2-e5635992848a@redhat.com> (raw)
In-Reply-To: <d130e88dd4c82a12d979da747cc0365c72c3ba15.1601770305.git.joe@perches.com>
On 04/10/20 02:18, Joe Perches wrote:
> This should be const, so make it so.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/powerpc/kvm/book3s_hv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
> index 4ba06a2a306c..2b215852cdc9 100644
> --- a/arch/powerpc/kvm/book3s_hv.c
> +++ b/arch/powerpc/kvm/book3s_hv.c
> @@ -111,7 +111,7 @@ module_param(one_vm_per_core, bool, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(one_vm_per_core, "Only run vCPUs from the same VM on a core (requires indep_threads_mode=N)");
>
> #ifdef CONFIG_KVM_XICS
> -static struct kernel_param_ops module_param_ops = {
> +static const struct kernel_param_ops module_param_ops = {
> .set = param_set_int,
> .get = param_get_int,
> };
>
Queued, thanks.
Paolo
next prev parent reply other threads:[~2020-10-19 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-04 0:18 [PATCH 0/4] treewide: Make definitions of struct kernel_param_ops const Joe Perches
2020-10-04 0:18 ` [PATCH 1/4] KVM: PPC: Book3S HV: Make struct kernel_param_ops definition const Joe Perches
2020-10-19 16:01 ` Paolo Bonzini [this message]
2020-10-04 1:19 ` Where is the declaration of buffer used in kernel_param_ops .get functions? Joe Perches
2020-10-04 1:36 ` Matthew Wilcox
2020-10-04 2:11 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1945b90-c97c-f998-56b2-e5635992848a@redhat.com \
--to=pbonzini@redhat.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=bharata@linux.ibm.com \
--cc=dave@stgolabs.net \
--cc=joe@perches.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=npiggin@gmail.com \
--cc=paulus@ozlabs.org \
--cc=sean.j.christopherson@intel.com \
--cc=tianjia.zhang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).