From: Krzysztof Kozlowski <krzk@kernel.org>
To: j.ne@posteo.net, Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Naveen N Rao <naveen@kernel.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>, Frank Li <Frank.Li@nxp.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 10/19] powerpc: dts: Add MPC8314E devicetree
Date: Fri, 10 Jan 2025 16:21:58 +0100 [thread overview]
Message-ID: <e1c8ebd5-b01d-4338-a465-889853d1ef9f@kernel.org> (raw)
In-Reply-To: <20250102-mpc83xx-v1-10-86f78ba2a7af@posteo.net>
On 02/01/2025 19:31, J. Neuschäfer via B4 Relay wrote:
> From: "J. Neuschäfer" <j.ne@posteo.net>
>
> The MPC8314E is a variant of the MPC8315E without SATA controllers.
>
> Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
> ---
> arch/powerpc/boot/dts/mpc8314e.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/powerpc/boot/dts/mpc8314e.dtsi b/arch/powerpc/boot/dts/mpc8314e.dtsi
> new file mode 100644
> index 0000000000000000000000000000000000000000..65a96a485dded5d4918d96b38778399d2f348190
> --- /dev/null
> +++ b/arch/powerpc/boot/dts/mpc8314e.dtsi
> @@ -0,0 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +// Copyright 2024 J. Neuschäfer
> +#include "mpc8315e.dtsi"
> +
> +/* MPC8314E does not support SATA */
> +/delete-node/ &sata0;
> +/delete-node/ &sata1;
You should not delete nodes. That's not really maintainable code. Either
this is in base DTSI or it does not. If it does exist, then this delete
is incorrect.
If it does not delete, you are not supposed to include other SoC/device
which is not the subset of this one, so your includes are not correct.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-10 15:22 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 18:31 [PATCH 00/19] powerpc: MPC83xx cleanup and LANCOM NWAPP2 board J. Neuschäfer via B4 Relay
2025-01-02 18:31 ` [PATCH 01/19] powerpc: Generalize MPC831x platform support J. Neuschäfer via B4 Relay
2025-01-06 13:50 ` Christophe Leroy
2025-01-07 22:45 ` J. Neuschäfer
2025-01-08 6:38 ` Christophe Leroy
2025-01-02 18:31 ` [PATCH 02/19] powerpc: dts: Extract mpc8315e.dtsi from mpc8315erdb.dts J. Neuschäfer via B4 Relay
2025-01-02 18:31 ` [PATCH 03/19] powerpc: dts: mpc8315e: Use IRQ_TYPE_* macros J. Neuschäfer via B4 Relay
2025-01-02 18:31 ` [PATCH 04/19] powerpc: dts: mpc8315e: Add labels to peripherals J. Neuschäfer via B4 Relay
2025-01-10 15:19 ` Krzysztof Kozlowski
2025-01-10 16:17 ` J. Neuschäfer
2025-01-02 18:31 ` [PATCH 05/19] powerpc: dts: mpc8315e: Disable peripherals by default J. Neuschäfer via B4 Relay
2025-01-02 18:31 ` [PATCH 06/19] powerpc: dts: mpc8315e: Add missing #cells properties to SPI bus J. Neuschäfer via B4 Relay
2025-01-02 18:31 ` [PATCH 07/19] powerpc: dts: mpc8315erdb: Add missing model property J. Neuschäfer via B4 Relay
2025-01-02 18:31 ` [PATCH 08/19] powerpc: boot: Enable FIT image generation J. Neuschäfer via B4 Relay
2025-01-06 13:52 ` Christophe Leroy
2025-01-07 23:00 ` J. Neuschäfer
2025-01-02 18:31 ` [PATCH 09/19] powerpc: boot: Build devicetrees when CONFIG_MPC831x=y J. Neuschäfer via B4 Relay
2025-01-06 13:55 ` Christophe Leroy
2025-01-07 23:24 ` J. Neuschäfer
2025-01-02 18:31 ` [PATCH 10/19] powerpc: dts: Add MPC8314E devicetree J. Neuschäfer via B4 Relay
2025-01-10 15:21 ` Krzysztof Kozlowski [this message]
2025-01-10 16:28 ` J. Neuschäfer
2025-01-02 18:31 ` [PATCH 11/19] dt-bindings: gpio: fsl,qoriq-gpio: Add compatible string fsl,mpc8314-gpio J. Neuschäfer via B4 Relay
2025-01-02 21:37 ` Linus Walleij
2025-01-03 8:13 ` Krzysztof Kozlowski
2025-01-02 18:31 ` [PATCH 12/19] powerpc: dts: mpc8315e: Add GPIO controller node J. Neuschäfer via B4 Relay
2025-01-02 18:31 ` [PATCH 13/19] gpio: mpc8xxx: Add MPC8314 support J. Neuschäfer via B4 Relay
2025-01-02 21:38 ` Linus Walleij
2025-01-04 14:21 ` J. Neuschäfer
2025-01-02 18:31 ` [PATCH 14/19] powerpc: mpc83xx: Switch to of_platform_populate J. Neuschäfer via B4 Relay
2025-01-02 18:51 ` Rob Herring
2025-01-04 14:50 ` J. Neuschäfer
2025-01-05 20:28 ` Rob Herring
2025-01-10 14:45 ` J. Neuschäfer
2025-01-02 18:31 ` [PATCH 15/19] dt-bindings: vendor-prefixes: Add LANCOM Systems GmbH J. Neuschäfer via B4 Relay
2025-01-03 8:12 ` Krzysztof Kozlowski
2025-01-02 18:31 ` [PATCH 16/19] powerpc: dts: Add LANCOM NWAPP2 board devicetree J. Neuschäfer via B4 Relay
2025-01-10 15:24 ` Krzysztof Kozlowski
2025-01-10 17:10 ` J. Neuschäfer
2025-01-19 22:03 ` J. Neuschäfer
2025-01-02 18:31 ` [PATCH 17/19] powerpc: Regenerate mpc83xx_defconfig J. Neuschäfer via B4 Relay
2025-01-02 18:31 ` [PATCH 18/19] powerpc: mpc83xx_defconfig: Enable NWAPP2 board features J. Neuschäfer via B4 Relay
2025-01-02 18:32 ` [PATCH 19/19] MAINTAINERS: Add entry for LANCOM board support J. Neuschäfer via B4 Relay
2025-01-03 15:20 ` [PATCH 00/19] powerpc: MPC83xx cleanup and LANCOM NWAPP2 board Rob Herring (Arm)
2025-01-06 20:23 ` (subset) " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1c8ebd5-b01d-4338-a465-889853d1ef9f@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=brgl@bgdev.pl \
--cc=christophe.leroy@csgroup.eu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j.ne@posteo.net \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).